Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limited support for OCaml 4.12 into omp1 #108

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Oct 8, 2020

Reusing part of #107

@ghost ghost assigned ceastlund Oct 8, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

The code looks good to me. There just seems to be some CI failures on older versions of OCaml due to references to Option.

@hhugo
Copy link
Contributor Author

hhugo commented Oct 19, 2020

Ci failure seems to be unrelated

@hhugo
Copy link
Contributor Author

hhugo commented Oct 20, 2020

CI failure still seem to be unrelated

@NathanReb NathanReb changed the base branch from 1.7 to 1.x October 23, 2020 08:43
@NathanReb NathanReb merged commit c086576 into ocaml-ppx:1.x Oct 23, 2020
NathanReb added a commit to NathanReb/opam-repository that referenced this pull request Oct 23, 2020
@hhugo hhugo deleted the omp1-412 branch October 23, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants