Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ppxlib (0.18.0) #17360

Merged
merged 4 commits into from
Oct 9, 2020

Conversation

NathanReb
Copy link
Contributor

Standard library for ppx rewriters

CHANGES:

@camelus
Copy link
Contributor

camelus commented Oct 6, 2020

Commit: a099ba1

A pull request by opam-seasoned @NathanReb.

☀️ All lint checks passed a099ba1
  • These packages passed lint tests: clim-ppx.0.3.0, hardcaml.v0.14.0, metapp.0.3.0, metaquot.0.3.0, mlt_parser.v0.14.0, ppx_bitstring.4.0.0, ppx_const.2.0, ppx_custom_printf.v0.13.0, ppx_custom_printf.v0.14.0, ppx_deriving_rpc.7.2.0, ppx_deriving_rpc.8.0.0, ppx_expect.v0.14.0, ppx_fields_conv.v0.14.1, ppx_getenv.2.0, ppx_irmin.2.2.0, ppx_optcomp.v0.13.0, ppx_optcomp.v0.14.0, ppx_protocol_conv.5.1.3, ppx_python.v0.13.0, ppx_sexp_conv.v0.14.1, ppx_sexp_message.v0.13.0, ppx_sexp_message.v0.14.0, ppx_yojson.1.0.0, ppxlib.0.18.0

☀️ Installability check (+1)
  • new installable packages (1): ppxlib.0.18.0

@mseri
Copy link
Member

mseri commented Oct 7, 2020

@NathanReb a few revdeps seem to fail with Pconst_string having an incorrect number of arguments or similar issues, like metapp, metaquot and ppx_bitstring, can you double check if they also need an upper bound before I merge the PR?

@NathanReb
Copy link
Contributor Author

Yeah it's expected that some other packages might break, I just added the bounds to the ones I sent patches to. I'll take a look tomorrow first thing in the morning !

@NathanReb
Copy link
Contributor Author

Where can I look at the revdeps failures? Some of the datakit builds seem to never have actually started, including ppxlib's revdeps one :/

@mseri
Copy link
Member

mseri commented Oct 8, 2020

Oh no. That is really unfortunate. I think the ci was restarted overnight and we lost the previous run

@NathanReb
Copy link
Contributor Author

I'll take care of it ASAP!

@NathanReb NathanReb force-pushed the release-ppxlib-0.18.0 branch from 337cea5 to a099ba1 Compare October 8, 2020 15:41
@NathanReb
Copy link
Contributor Author

I think I fixed them all!

@kit-ty-kate
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants