Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to ppxlib 0.22.0 #34

Closed
copy opened this issue Feb 17, 2021 · 2 comments
Closed

Adapt to ppxlib 0.22.0 #34

copy opened this issue Feb 17, 2021 · 2 comments

Comments

@copy
Copy link
Contributor

copy commented Feb 17, 2021

It's currently constrained to < "0.18.0":

% opam show ppx_protocol_conv |grep ppxlib
              "ppxlib" {>= "0.9.0" & < "0.18.0"}
@andersfugmann
Copy link
Owner

This limit was added as part of ocaml/opam-repository#17360. I cannot access the logs referenced in the PR, so I do not know the rationale for this, other than rev-deps was complaining about this package.

You are welcome to create a PR against the opam-repository. The code compiles just fine against ppxlib 0.22.0 (although the tests implicitly requires ppxlib 0.21.0)

@copy
Copy link
Contributor Author

copy commented Feb 17, 2021

Thanks. I went ahead and proposed to adjust the constraints on opam-repository: ocaml/opam-repository#18172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants