fix: Swap custom and transform processors in pipeline #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-enricogiorio
force-pushed
the
enrico/swapProcessors
branch
from
e3aa214
to
8a2aa85
Compare
xueweiz
approved these changes
Nov 1, 2024
|
This will only work once we release the agent with the "structured log body" patch. |
The observek8sattributes processor might edit the log body in-place, which might affect the value of facets computed by transform/object. Therefore, we swap the two processors in the pipeline to make sure observek8sattributes always acts before transform/object.
obs-gh-enricogiorio
force-pushed
the
enrico/swapProcessors
branch
from
8a2aa85
to
c98d16e
Compare
Local testing: my cluster sends Secret entities with obfuscated secrets' values in the facets after swapping processors.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is that the custom processor might edit the log body in-place and the transform processor will copy parts of the body over to the facets. Since the transform processor is more flexible, we want to edit things first and eventually add them as facets once they are modified.
Example: secrets obfuscation. We want to redact the secrets' values that can show up in the annotations. The transform processor blindly copies the annotations to facets. So we don't want the secrets to show up in the facets un-redacted.