-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Swap custom and transform processors in pipeline
The reason is that the custom processor might edit the log body in-place and the transform processor will copy parts of the body over to the facets. Since the transform processor is more flexible, we want to edit things first and eventually add them as facets once they are modified. Example: secrets obfuscation. We want to redact the secrets' values that can show up in the annotations. The transform processor blindly copies the annotations to facets. So we don't want the secrets to show up in the facets un-redacted.
- Loading branch information
1 parent
933b3d6
commit e3aa214
Showing
3 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters