Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: avoid tricky parsing of hard wrapped link #2706

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Feb 21, 2020

test PR for git lint problem

fixes #2707

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #2706 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2706      +/-   ##
==========================================
+ Coverage   62.77%   62.96%   +0.19%     
==========================================
  Files         381      381              
  Lines       35752    35752              
==========================================
+ Hits        22443    22513      +70     
+ Misses      10474    10433      -41     
+ Partials     2835     2806      -29
Impacted Files Coverage Δ
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/consensus/tendermint/roothash/roothash.go 65.54% <0%> (-6%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 84.61% <0%> (-5.13%) ⬇️
go/worker/storage/service_external.go 47.31% <0%> (-4.31%) ⬇️
go/oasis-node/cmd/debug/storage/storage.go 45.08% <0%> (-3.47%) ⬇️
go/runtime/committee/nodes.go 80.64% <0%> (-2.16%) ⬇️
go/common/grpc/grpc.go 77.59% <0%> (-1.25%) ⬇️
go/consensus/tendermint/tendermint.go 66.2% <0%> (-1.25%) ⬇️
go/worker/common/committee/group.go 80.98% <0%> (ø) ⬆️
go/storage/client/client.go 77.31% <0%> (+0.42%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5037df1...789933f. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/junk/test branch 6 times, most recently from 8582ec0 to 2b0fe21 Compare February 22, 2020 00:46
@pro-wh pro-wh requested a review from tjanez February 22, 2020 00:47
.github/workflows/ci-lint.yml Outdated Show resolved Hide resolved
provided Docker image which does this for you, [see below](
#using-the-development-docker-image)).
provided Docker image which does this for you,
[see below](#using-the-development-docker-image)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this is just visual/human issue or does any tool have problems with that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my IDE's shabby markdown mode ):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I see 🙂.

No worries, we can wrap it like you suggested.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@pro-wh
Copy link
Contributor Author

pro-wh commented Feb 24, 2020

alright codeowners please review

@pro-wh pro-wh merged commit b946fcc into master Feb 26, 2020
@pro-wh pro-wh deleted the pro-wh/junk/test branch February 26, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitlint/git lint commits selection working wrong
3 participants