Skip to content

Commit

Permalink
Makefile: add gitlint internals note
Browse files Browse the repository at this point in the history
  • Loading branch information
pro-wh committed Feb 24, 2020
1 parent 400f73d commit 978cc33
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ lint-targets := lint-go lint-git lint-md lint-changelog
lint-go:
@$(MAKE) -C go lint

# NOTE: gitlint internally uses git rev-list, where A..B is asymmetric difference, which is kind of the opposite of
# how git diff interprets A..B vs A...B.
lint-git: fetch-git
@COMMIT_SHA=`git rev-parse $(OASIS_CORE_GIT_ORIGIN_REMOTE)/$(RELEASE_BRANCH)` && \
echo "Running gitlint for commits from $(OASIS_CORE_GIT_ORIGIN_REMOTE)/$(RELEASE_BRANCH) ($${COMMIT_SHA:0:7})..."; \
Expand Down

0 comments on commit 978cc33

Please sign in to comment.