Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: avoid tricky parsing of hard wrapped link #2706

Merged
merged 4 commits into from
Feb 26, 2020
Merged

readme: avoid tricky parsing of hard wrapped link #2706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
189ce5a
readme: avoid tricky parsing of hard wrapped link
pro-wh Feb 21, 2020
06828e2
add changelog
pro-wh Feb 21, 2020
4867f58
lint: use asymmetric difference to find new commits
pro-wh Feb 22, 2020
789933f
Makefile: add gitlint internals note
pro-wh Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2706.trivial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
readme: Avoid tricky parsing of hard wrapped link
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,12 @@ lint-targets := lint-go lint-git lint-md lint-changelog
lint-go:
@$(MAKE) -C go lint

# NOTE: gitlint internally uses git rev-list, where A..B is asymmetric difference, which is kind of the opposite of
# how git diff interprets A..B vs A...B.
lint-git: fetch-git
@COMMIT_SHA=`git rev-parse $(OASIS_CORE_GIT_ORIGIN_REMOTE)/$(RELEASE_BRANCH)` && \
echo "Running gitlint for commits from $(OASIS_CORE_GIT_ORIGIN_REMOTE)/$(RELEASE_BRANCH) ($${COMMIT_SHA:0:7})..."; \
gitlint --commits $(OASIS_CORE_GIT_ORIGIN_REMOTE)/$(RELEASE_BRANCH)...HEAD
gitlint --commits $(OASIS_CORE_GIT_ORIGIN_REMOTE)/$(RELEASE_BRANCH)..HEAD
tjanez marked this conversation as resolved.
Show resolved Hide resolved
pro-wh marked this conversation as resolved.
Show resolved Hide resolved

lint-md:
@npx markdownlint-cli '**/*.md' --ignore .changelog/
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ Prerequisites:

* Linux (if you are not on Linux, you will need to either set up a VM with the
proper environment or, if Docker is available for your platform, use the
provided Docker image which does this for you, [see below](
#using-the-development-docker-image)).
provided Docker image which does this for you,
[see below](#using-the-development-docker-image)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this is just visual/human issue or does any tool have problems with that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my IDE's shabby markdown mode ):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I see 🙂.

No worries, we can wrap it like you suggested.


* System packages:
* [Bubblewrap](https://github.com/projectatomic/bubblewrap) (at least version
Expand Down