feat: add support for multi domain locales #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: i18n dir resolve * feat: i18n dir resolve * test: add restructure test * refactor: file resolution * fix: layer option validation * docs: describe breaking folder structure change * fix: layer validation * chore: update lockfile * test: change fixture structure * feat: `restructureDir` option * docs: describe restructure and compatible option
* fix: rename locale property `iso` to `language` * refactor: rename parameters * fix: locale `language` merging * docs: expand `iso` rename explanation
…les#3061) * fix: route localization with `differentDomains` * fix: prevent route removal * fix: `switchLocalePath` resolution for `differentDomains` * docs: update notes to clarify `differentDomains` case
…es per domain Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
…trategies Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
9 tasks
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
|
Thanks! Can you target the |
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
Developed by: Social Deal (@socialdeal) Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
|
@BobbieGoede we updated the branch/pr to the main branch (V9) :) |
BobbieGoede
approved these changes
Aug 19, 2024
|
Thanks again! This looks good and doesn't seem to conflict with existing functionality, I'll see if I can merge and publish a new minor release for v8 soon. For v9 we may do some refactoring and possibly change the way this functionality is configured, I think there's still some undefined behavior when multiple layers use the new locale options, and not sure what the desired merging behavior would be. |
BobbieGoede
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Vincent de Vreede <[email protected]> Co-authored-by: DarthGigi <[email protected]>
antoinezanardi
referenced
this pull request
in antoinezanardi/werewolves-assistant-web-next
Sep 10, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@nuxtjs/i18n](https://i18n.nuxtjs.org) ([source](https://redirect.github.com/nuxt-community/i18n-module)) | [`^8.4.0` -> `^8.5.2`](https://renovatebot.com/diffs/npm/@nuxtjs%2fi18n/8.4.0/8.5.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nuxt-community/i18n-module (@​nuxtjs/i18n)</summary> ### [`v8.5.2`](https://redirect.github.com/nuxt-modules/i18n/releases/tag/v8.5.2) [Compare Source](https://redirect.github.com/nuxt-community/i18n-module/compare/v8.5.1...v8.5.2) ##### 🐞 Bug Fixes - Cookie being reset on reload in ssg build - by [@​BobbieGoede](https://redirect.github.com/BobbieGoede) in [https://github.com/nuxt-modules/i18n/issues/3087](https://redirect.github.com/nuxt-modules/i18n/issues/3087) [<samp>(7ccaf)</samp>](https://redirect.github.com/nuxt-modules/i18n/commit/7ccaf160) ##### [View changes on GitHub](https://redirect.github.com/nuxt-modules/i18n/compare/v8.5.1...v8.5.2) ### [`v8.5.1`](https://redirect.github.com/nuxt-modules/i18n/releases/tag/v8.5.1) [Compare Source](https://redirect.github.com/nuxt-community/i18n-module/compare/v8.5.0...v8.5.1) ##### 🐞 Bug Fixes - Resolve plugin type import conflicts by updating module builder - by [@​danielroe](https://redirect.github.com/danielroe) in [#​3071](https://redirect.github.com/nuxt-community/i18n-module/issues/3071) ##### [View changes on GitHub](https://redirect.github.com/nuxt-modules/i18n/compare/v8.5.0...v8.5.1) ### [`v8.5.0`](https://redirect.github.com/nuxt-modules/i18n/releases/tag/v8.5.0) [Compare Source](https://redirect.github.com/nuxt-community/i18n-module/compare/v8.4.0...v8.5.0) ##### 🚀 Features - Add support for multi domain locales - by [@​DotwoodMedia](https://redirect.github.com/DotwoodMedia), **Vincent de Vreede** and **DarthGigi** in [https://github.com/nuxt-modules/i18n/issues/3065](https://redirect.github.com/nuxt-modules/i18n/issues/3065) [<samp>(93d62)</samp>](https://redirect.github.com/nuxt-modules/i18n/commit/93d62226) ##### [View changes on GitHub](https://redirect.github.com/nuxt-modules/i18n/compare/v8.4.0...v8.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/antoinezanardi/werewolves-assistant-web-next). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Antoine ZANARDI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Different domains with multiple languages each #1161
❓ Type of change
📚 Description
Resolves #1161 by allowing the same locale on multiple domains.
📝 Checklist
🗒️ Note
The developers of @socialdeal (@Vincentdevreede, @DotwoodMedia & @DarthGigi) has rebuilt the feature from #2914 due to excessive bugs.