Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple locales on multiple domains #2914

Closed

Conversation

DarthGigi
Copy link
Contributor

@DarthGigi DarthGigi commented Apr 16, 2024

πŸ”— Linked issue

#1161

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #1161 by allowing the same locale on multiple domains. Eg:

NL domain:
https://mydomain.nl/ -> https://mydomain.nl/ (nl language)
https://mydomain.nl/en -> https://mydomain.nl/en (en language)
https://mydomain.nl/de -> https://mydomain.nl/de (de language)

https://mydomain.nl/nl -> https://mydomain.nl/nl (404)

DE domain:
https://mydomain.de/ -> https://mydomain.nl/ (nl language)
https://mydomain.de/en -> https://mydomain.nl/en (en language)
https://mydomain.de/nl -> https://mydomain.nl/de (de language)

https://mydomain.de/de -> https://mydomain.de/de (404)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@DarthGigi DarthGigi changed the title feat: multiple locales on multiple domains [WIP] feat: multiple locales on multiple domains Apr 19, 2024
@DarthGigi DarthGigi changed the title [WIP] feat: multiple locales on multiple domains feat: multiple locales on multiple domains Apr 19, 2024
@DarthGigi
Copy link
Contributor Author

I've fixed the tests, all tests should pass now. Documentation has been added as well.

@PetroSilenius
Copy link

This would be a great functionality! I noticed there's no requested reviews, maybe you could resolve the conflicts and request someone to review this? πŸ˜„

@DarthGigi
Copy link
Contributor Author

This pull request has been deprecated, please see #3065

@DarthGigi DarthGigi closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different domains with multiple languages each
2 participants