-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple locales on multiple domains #2914
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦lity of default locales per domain
This was referenced Apr 16, 2024
DarthGigi
changed the title
feat: multiple locales on multiple domains
[WIP] feat: multiple locales on multiple domains
Apr 19, 2024
β¦ultiple locales on multiple domains
DarthGigi
changed the title
[WIP] feat: multiple locales on multiple domains
feat: multiple locales on multiple domains
Apr 19, 2024
I've fixed the tests, all tests should pass now. Documentation has been added as well. |
This would be a great functionality! I noticed there's no requested reviews, maybe you could resolve the conflicts and request someone to review this? π |
9 tasks
This pull request has been deprecated, please see #3065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#1161
β Type of change
π Description
Resolves #1161 by allowing the same locale on multiple domains. Eg:
π Checklist