Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode switchLocalePath during SSR replacement #3043

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Jul 26, 2024

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

This should resolve #3042, but if I'm overlooking something please let me know.

@kazupon
I created a v8 branch which diverts from main at 7930a27, I have also cherry picked some changes from the main branch where possible.

If this PR gets merged it will need to be added to the v8 branch as well, will the normal release flow work from that branch? ๐Ÿค”

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from kazupon July 26, 2024 10:32
@BobbieGoede BobbieGoede self-assigned this Jul 26, 2024
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
The release flow using GitHub Actions is difficult, so we need to release manually.

@kazupon kazupon merged commit be59c76 into nuxt-modules:main Jul 27, 2024
7 checks passed
@pmnzt
Copy link

pmnzt commented Jul 29, 2024

Something is broken about this function, it now returns nothing
@kazupon
@BobbieGoede

@BobbieGoede
Copy link
Collaborator Author

Something is broken about this function, it now returns nothing
@kazupon
@BobbieGoede

Can you open a new issue and provide a minimal reproduction? ๐Ÿ™

@pmnzt
Copy link

pmnzt commented Aug 4, 2024

Something is broken about this function, it now returns nothing
@kazupon
@BobbieGoede

Can you open a new issue and provide a minimal reproduction? ๐Ÿ™

here #3051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental switchLocalePathLinkSSR causing possible XSS vector
3 participants