feat: set locale domains via runtimeConfig (#2443)

[cjpearson]

🔗 Linked issue

#2443

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This change allows setting locale domains via the runtime config. Currently when enabling differentDomains the app must be recompiled for each environment because the domains are set at compile time. With this change a single build can be used on different environments with different .env files.

e.g.

production .env

NUXT_PUBLIC_I18N_LOCALES_EN_DOMAIN=en.example.test
NUXT_PUBLIC_I18N_LOCALES_DE_DOMAIN=de.example.test

staging .env

NUXT_PUBLIC_I18N_LOCALES_EN_DOMAIN=en.staging.example.test
NUXT_PUBLIC_I18N_LOCALES_DE_DOMAIN=de.staging.example.test

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[nuxt-studio]

✅ Live Preview ready!

Name	Edit	Preview	Latest Commit
i18n	Edit on Studio ↗︎	View Live Preview	e3f2788

[cjpearson]

Is this test maybe flaky? I can't reproduce it locally and it also seems to be causing the failures in #2442 and ee5e026

[BobbieGoede]

@cjpearson
Yes the tests are a bit flaky in general (tracked here #1998), so will be rerunning it. Fortunately it seems to only throw false failures and not the other way around 😅

[BobbieGoede]

Thanks for contributing!

I think this feature looks good, I prefer it over the approach currently described in the docs here: https://v8.i18n.nuxtjs.org/guide/different-domains#runtime-environment-variables

I think if you change/replace the example in the linked documentation to use this feature it would be perfect! What do you think @kazupon?

[cjpearson]

Thanks! I made a pass at updating the guide with an example

[kazupon]

Thank you for your contribution!
I think this feature looks good too.
we would like to merge this feature, when you will ready for example and docs :)

[cjpearson]

Hi @kazupon I updated the docs for runtime config and routing and added an example to the different domains guide. Is there anything else I should change in the docs?

[BobbieGoede]

I have raised the test job timeout, if you rebase your branch on next the tests should succeed (at least it won't fail because of the timeout)

[BobbieGoede]

Not sure why the tests keep failing repeatedly now, I know that it's not because of your code as they pass locally. Looks like the flaky test debt has caught up with us 😭, will take some time to look into this.

[kazupon]

Yeah.
The Other PRs such as #2441 are also flaky testing… we should fix that issue. 😿