Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky tests #2452

Merged
merged 1 commit into from
Sep 29, 2023
Merged

test: fix flaky tests #2452

merged 1 commit into from
Sep 29, 2023

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

#1998
#2446

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The playwright docs describe the page.waitForTimeout method as 'inherently flaky' and discourage its use. So I have replaced its usage with other more reliable assertions.

Also synced the test-utils I saw in nuxt/nuxt.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Sep 28, 2023
@BobbieGoede BobbieGoede changed the title text: fix flaky tests test: fix flaky tests Sep 28, 2023
@BobbieGoede BobbieGoede force-pushed the test/fix-flaky-tests branch 4 times, most recently from 606ff94 to d017a27 Compare September 28, 2023 21:45
kazupon
kazupon approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazing work! ❤️
Thank you so much!

@kazupon kazupon merged commit 9dae464 into nuxt-modules:next Sep 29, 2023
4 checks passed
@kazupon kazupon mentioned this pull request Sep 29, 2023
Merged
7 tasks
@BobbieGoede BobbieGoede mentioned this pull request Sep 30, 2023
Merged
7 tasks
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@BobbieGoede
text: fix flaky tests (nuxt-modules#2452)
67f6bf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees

@BobbieGoede BobbieGoede

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test action unreliable - action fails then succeeds without code change
2 participants
@BobbieGoede @kazupon