Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sherman Ho] iP #232

Open
wants to merge 107 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
3b19ba1
Add Gradle support
May 24, 2020
a75fcee
build.gradle: Update version to 8.29
Aug 29, 2020
d518a02
Done Level-1
nighoggDatatype Jan 20, 2021
bcd1275
Done Level-2
nighoggDatatype Jan 20, 2021
f4d6f0f
Added Task class, and cleaned up the code of warnings
nighoggDatatype Jan 20, 2021
179b869
Done Level-3
nighoggDatatype Jan 20, 2021
e707812
Refactored Task
nighoggDatatype Jan 20, 2021
c7cdb78
Further refactored Task to not deal with numbering
nighoggDatatype Jan 20, 2021
a171f30
Done A-Inheritance
nighoggDatatype Jan 20, 2021
d8b325f
Done Level-4, with some refactoring
nighoggDatatype Jan 20, 2021
557f98c
Whoops, renamed Events to Event and actually include Event as creatio…
nighoggDatatype Jan 20, 2021
7f652e5
Added test data, found bugs immediately in need of testing, unicode d…
nighoggDatatype Jan 20, 2021
558f9b7
Somewhat fixed unicode, probably need to fix how files are compared c…
nighoggDatatype Jan 20, 2021
691306e
Removed rendundant line
nighoggDatatype Jan 20, 2021
4856b15
Fixed another bug I missed
nighoggDatatype Jan 20, 2021
819aea7
Added some error checking
nighoggDatatype Jan 20, 2021
dec65f3
Minor bugfix on leakage
nighoggDatatype Jan 20, 2021
945ec43
Added Empty Argument Handling
nighoggDatatype Jan 20, 2021
7fb940a
Fixed bug to do with single arg commands
nighoggDatatype Jan 20, 2021
6db18be
Implemented Delete
nighoggDatatype Jan 20, 2021
6563d2c
Fixed bug with event deliminator
nighoggDatatype Jan 28, 2021
6d3e2d1
Add minimal code to implement saving.
nighoggDatatype Jan 28, 2021
eab0390
Fix hash calculation of CheckList for better saving
nighoggDatatype Jan 28, 2021
b985269
Remove duke.txt from tracking
nighoggDatatype Jan 28, 2021
100297e
Add date time parsing to Deadline
nighoggDatatype Jan 28, 2021
4ea7bf4
Merge branch 'branch-Level-7'
nighoggDatatype Jan 28, 2021
2aae990
Merge branch 'branch-Level-8'
nighoggDatatype Jan 28, 2021
a66f65a
Add graceful handling of badly formatted date input
nighoggDatatype Jan 28, 2021
494dc33
Fix bug where feedback on done item was absent
nighoggDatatype Jan 28, 2021
1edba8d
Add some Class needed for the increment A-MoreOOP
nighoggDatatype Jan 29, 2021
079455b
Add flag to detect edits
nighoggDatatype Jan 29, 2021
69d2fb3
Move some Ui code into its own class
nighoggDatatype Jan 31, 2021
52ab2af
Refactor java files into packages
nighoggDatatype Jan 31, 2021
893c5e7
Rename TaskListFileUtils to Storage for Class req
nighoggDatatype Jan 31, 2021
cfefbd8
Made isDone only changable via a setter function to true.
nighoggDatatype Jan 31, 2021
e32afc4
Intergrate previously disconnected Object Oriented classes
nighoggDatatype Jan 31, 2021
c1cf9f3
Allow more relaxed parsing rules
nighoggDatatype Jan 31, 2021
eb5747d
Move Error printing into Ui Class
nighoggDatatype Jan 31, 2021
5e0abc5
Move last ui elements to Ui class
nighoggDatatype Jan 31, 2021
d5405aa
Add Skeleton Test Code
nighoggDatatype Jan 31, 2021
f1e59d5
Add minimal Test Code to satisfy req
nighoggDatatype Feb 2, 2021
abb945f
Add Basic search framework code
nighoggDatatype Feb 4, 2021
7a7c782
Make search more intuitive
nighoggDatatype Feb 4, 2021
568e901
Minor spelling correction, from overeager refactor
nighoggDatatype Feb 4, 2021
4f53630
Add possibly incomplete Javadoc, Detailed message pending
nighoggDatatype Feb 5, 2021
a33d08c
Finish adding javadoc to every public method except main
nighoggDatatype Feb 5, 2021
856473f
Fix import statements
nighoggDatatype Feb 5, 2021
d269a67
Fix spacing for code formatting
nighoggDatatype Feb 8, 2021
42cc0d0
Fixed Array Formatting
nighoggDatatype Feb 8, 2021
24aeb95
Merge branch 'branch-Level-9'
nighoggDatatype Feb 9, 2021
89afdd5
Add JavaDoc for commandMessage
nighoggDatatype Feb 9, 2021
1e5d21c
Merge branch 'branch-A-JavaDoc'
nighoggDatatype Feb 9, 2021
003cfda
Merge branch 'branch-A-CodingStandard'
nighoggDatatype Feb 9, 2021
621e63f
Add missing import that somehow slipped past me
nighoggDatatype Feb 11, 2021
9b30ce7
Merge remote-tracking branch 'remotes/upstream/add-gradle-support' in…
nighoggDatatype Feb 12, 2021
14bc7ac
Merge branch 'branch-A-Gradle'
nighoggDatatype Feb 12, 2021
e7457a9
Add Checkstyle according to guide
nighoggDatatype Feb 12, 2021
10af3b6
Edit checkstyle to enforce SCREAMING_SNAKE_CASE for private constants
nighoggDatatype Feb 12, 2021
bb690a7
Add supressions.xml to allow gradle to work
nighoggDatatype Feb 12, 2021
5998f67
Modify main code to satisfy automated checkStyle validation only
nighoggDatatype Feb 12, 2021
514a694
Merge branch 'branch-A-CheckStyle'
nighoggDatatype Feb 12, 2021
725faea
Address concerns in reviews for my first PR
nighoggDatatype Feb 12, 2021
68d8318
Fix naming and bug when searching long word
nighoggDatatype Feb 12, 2021
e17d7d6
Set up gradle for JavaFX
nighoggDatatype Feb 12, 2021
05f73fc
Add skeleton for JavaFx
nighoggDatatype Feb 13, 2021
b1bec18
Refactor code so that MainWindow handled output over Ui
nighoggDatatype Feb 13, 2021
01fffc3
Add Material from Tutorial to create MVP for UI
nighoggDatatype Feb 13, 2021
d78dbd7
Merge branch 'branch-Level-10'
nighoggDatatype Feb 13, 2021
14f02eb
Fix checkStyle for test code
nighoggDatatype Feb 13, 2021
18cf047
Fix minor Checkstyle issue
nighoggDatatype Feb 13, 2021
b1c6d6d
Fix build.gradle to make shadowJar work
nighoggDatatype Feb 13, 2021
076010a
Make first attempt to improve Code Quality
nighoggDatatype Feb 14, 2021
eefd33e
Use more descriptive variable names for addTask
nighoggDatatype Feb 15, 2021
bb44eb1
Add Asserts for TaskList. Other classes in progress maybe
nighoggDatatype Feb 15, 2021
cc14009
Add more asserts
nighoggDatatype Feb 16, 2021
877e896
Remove erronous assert
nighoggDatatype Feb 16, 2021
5790efb
Handle out of bounds error discovered during assert creation
nighoggDatatype Feb 16, 2021
a977e38
Add Stream and Lambda
nighoggDatatype Feb 16, 2021
57ccda8
Apply SLAP to TaskList::AddTask
nighoggDatatype Feb 16, 2021
e8a0bc6
Move File string generation from Storage to TaskList
nighoggDatatype Feb 16, 2021
4e8de88
Make Storage a proper object, from a static interface
nighoggDatatype Feb 16, 2021
6f4d8ad
Remove some completed comments and fix some Javadocs
nighoggDatatype Feb 16, 2021
37c31dc
Remove overloaded error handling function
nighoggDatatype Feb 16, 2021
a7d3eb0
Remove unused method
nighoggDatatype Feb 16, 2021
732447d
Add missing return description for javadoc
nighoggDatatype Feb 16, 2021
e90e3a8
Remove unnecessary field
nighoggDatatype Feb 16, 2021
a0313e1
Add final to variables where possible
nighoggDatatype Feb 16, 2021
cf57033
Add spacing in javadoc where appropriate
nighoggDatatype Feb 16, 2021
6c11a8e
Fix typos
nighoggDatatype Feb 16, 2021
c0ab2df
Improve code quality
nighoggDatatype Feb 16, 2021
6bb1aa1
Fix bug to do with uppercase searching
nighoggDatatype Feb 16, 2021
438d93c
Add more final to variables
nighoggDatatype Feb 16, 2021
dd21308
Remove redundant code discovered during testing asserts
nighoggDatatype Feb 17, 2021
e9ae6af
Merge pull request #2 from nighoggDatatype/branch-A-CodeQuality
nighoggDatatype Feb 17, 2021
a9ac758
Merge branch 'master' into branch-A-Assertions
nighoggDatatype Feb 17, 2021
4d4f3b0
Fix minor javadoc mangling
nighoggDatatype Feb 17, 2021
1a4f6f5
Merge pull request #4 from nighoggDatatype/branch-A-Assertions
nighoggDatatype Feb 17, 2021
f472d0d
Merge pull request #3 from nighoggDatatype/branch-A-Streams-Lambda
nighoggDatatype Feb 17, 2021
41f5db3
Add new formatting options for Deadline dates, and adjusted error mes…
nighoggDatatype Feb 17, 2021
97dcd14
Fix bug where non lowercase commands with zero args were not recognized
nighoggDatatype Feb 17, 2021
c4157f2
Merge branch 'branch-BCD-Extension'
nighoggDatatype Feb 17, 2021
452b578
Ensure entire duke dialog can be seen at all times
nighoggDatatype Feb 18, 2021
7f615c4
Fix incorrect addition of newline when generating list in stream
nighoggDatatype Feb 18, 2021
003db68
Clean up messages from poor porting to GUI
nighoggDatatype Feb 18, 2021
df960cd
Merge branch 'branch-A-BetterGui'
nighoggDatatype Feb 18, 2021
0083b41
Add Documentation for Duke
nighoggDatatype Feb 19, 2021
06eeccc
Set theme jekyll-theme-cayman
nighoggDatatype Feb 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
plugins {
id 'java'
id 'application'
id 'checkstyle'
id 'com.github.johnrengelman.shadow' version '5.1.0'
}

repositories {
mavenCentral()
}

dependencies {
testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter-api', version: '5.5.0'
testRuntimeOnly group: 'org.junit.jupiter', name: 'junit-jupiter-engine', version: '5.5.0'
String javaFxVersion = '11'

implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'win'
implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'mac'
implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'linux'
implementation group: 'org.openjfx', name: 'javafx-controls', version: javaFxVersion, classifier: 'win'
implementation group: 'org.openjfx', name: 'javafx-controls', version: javaFxVersion, classifier: 'mac'
implementation group: 'org.openjfx', name: 'javafx-controls', version: javaFxVersion, classifier: 'linux'
implementation group: 'org.openjfx', name: 'javafx-fxml', version: javaFxVersion, classifier: 'win'
implementation group: 'org.openjfx', name: 'javafx-fxml', version: javaFxVersion, classifier: 'mac'
implementation group: 'org.openjfx', name: 'javafx-fxml', version: javaFxVersion, classifier: 'linux'
implementation group: 'org.openjfx', name: 'javafx-graphics', version: javaFxVersion, classifier: 'win'
implementation group: 'org.openjfx', name: 'javafx-graphics', version: javaFxVersion, classifier: 'mac'
implementation group: 'org.openjfx', name: 'javafx-graphics', version: javaFxVersion, classifier: 'linux'
}

test {
useJUnitPlatform()

testLogging {
events "passed", "skipped", "failed"

showExceptions true
exceptionFormat "full"
showCauses true
showStackTraces true
showStandardStreams = false
}
}

application {
mainClassName = "duke.Launcher"
}

shadowJar {
archiveBaseName = "duke"
archiveClassifier = null
}

checkstyle {
toolVersion = '8.29'
}

run{
standardInput = System.in
}
Loading