Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sherman Ho] iP #232

Open
wants to merge 107 commits into
base: master
Choose a base branch
from

Commits on Jul 23, 2020

  1. Add Gradle support

    damithc authored and damithc committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3b19ba1 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. build.gradle: Update version to 8.29

    damithc committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    a75fcee View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Done Level-1

    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    d518a02 View commit details
    Browse the repository at this point in the history
  2. Done Level-2

    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    bcd1275 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f4d6f0f View commit details
    Browse the repository at this point in the history
  4. Done Level-3

    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    179b869 View commit details
    Browse the repository at this point in the history
  5. Refactored Task

    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    e707812 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c7cdb78 View commit details
    Browse the repository at this point in the history
  7. Done A-Inheritance

    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a171f30 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d8b325f View commit details
    Browse the repository at this point in the history
  9. Whoops, renamed Events to Event and actually include Event as creatio…

    …n. Good time for automated testing
    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    557f98c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7f652e5 View commit details
    Browse the repository at this point in the history
  11. Somewhat fixed unicode, probably need to fix how files are compared c…

    …ause line endings shouldn't matter
    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    558f9b7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    691306e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4856b15 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    819aea7 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    dec65f3 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    945ec43 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7fb940a View commit details
    Browse the repository at this point in the history
  18. Implemented Delete

    nighoggDatatype committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    6db18be View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Configuration menu
    Copy the full SHA
    6563d2c View commit details
    Browse the repository at this point in the history
  2. Add minimal code to implement saving.

    Code does not implement saving
    
    Need to persist the change across runs
    
    Let's:
    * Add and call code to load and save data
    * Add file safe string functions to tasks
    nighoggDatatype committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    6d3e2d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eab0390 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b985269 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    100297e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4ea7bf4 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'branch-Level-8'

    Source branch we are merging from spreads out Date parsing too wide
    
    This increases the possiblity for inconsistency
    
    Let's move the parsing of strings to LocalDate into the Deadline class
    nighoggDatatype committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    2aae990 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a66f65a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    494dc33 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Configuration menu
    Copy the full SHA
    1edba8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    079455b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. Configuration menu
    Copy the full SHA
    69d2fb3 View commit details
    Browse the repository at this point in the history
  2. Refactor java files into packages

    Currently, the project src files are all in one single src folder.
    
    This makes it very unclear what files are logically together and clutter the folder view.
    
    Let's
    * Create a top level package 'duke'
    * Create the sub-packages 'command', 'exception' and 'task'
    * Leave the files; 'Duke', 'Parser', 'TaskList', 'TaskListFileUtils' and 'Ui' in the top level package 'duke'.
    
    Note that I only place files that will have more than one related file into packages.
    I currently do not have any packages with only one file for now.
    Whether that is best practice or not is unknown, and may change in the future.
    nighoggDatatype committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    52ab2af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    893c5e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cfefbd8 View commit details
    Browse the repository at this point in the history
  5. Intergrate previously disconnected Object Oriented classes

    The created object oriented classes is disconnected from the actual Duke main function
    
    There is a requirement for OOP to be used extentively by CS2103T
    
    Let's
    * Remove ill-formatted strings due to indiscriminate package refactoring
    * Properly flesh out Ui class functionality
    * Intergrate prevously created class into Duke
    * Edit TaskList and Storage to accomidate each other
    * Edit TaskList and Ui to accomidate error printing
    nighoggDatatype committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    e32afc4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c1cf9f3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eb5747d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5e0abc5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d5405aa View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Configuration menu
    Copy the full SHA
    f1e59d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Configuration menu
    Copy the full SHA
    abb945f View commit details
    Browse the repository at this point in the history
  2. Make search more intuitive

    Search is currently only a wrapper on contains()
    
    This is bad because this breaks intuition (At least my intuition) about
    how searching should be done. For example: "in" should not match "Beating Minecraft"
    and "minecraft" should match it, but both of those cases are unfulfilled.
    
    Let's:
    * Attempt to check description on a per word basis from the start of the word
    ** Allow this to be overriden by the presence of multiple spaces
    * Do lowercase matching for everything by default
    ** Allow capital letters in the search to override this.
    
    The reason we allow exceptions is because we sometimes want more specific searching rules.
    nighoggDatatype committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    7a7c782 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    568e901 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Configuration menu
    Copy the full SHA
    4f53630 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a33d08c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    856473f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Configuration menu
    Copy the full SHA
    d269a67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42cc0d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Configuration menu
    Copy the full SHA
    24aeb95 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89afdd5 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'branch-A-JavaDoc'

    Added JavaDoc to new functions and made some functions private
    nighoggDatatype committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    1e5d21c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    003cfda View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Configuration menu
    Copy the full SHA
    621e63f View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Configuration menu
    Copy the full SHA
    9b30ce7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14bc7ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7457a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    10af3b6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb690a7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5998f67 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    514a694 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    725faea View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    68d8318 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e17d7d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Configuration menu
    Copy the full SHA
    05f73fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1bec18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    01fffc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d78dbd7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    14f02eb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    18cf047 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b1c6d6d View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Configuration menu
    Copy the full SHA
    076010a View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Configuration menu
    Copy the full SHA
    eefd33e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb44eb1 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Add more asserts

    nighoggDatatype committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    cc14009 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    877e896 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5790efb View commit details
    Browse the repository at this point in the history
  4. Add Stream and Lambda

    nighoggDatatype committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a977e38 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    57ccda8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e8a0bc6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4e8de88 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6f4d8ad View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    37c31dc View commit details
    Browse the repository at this point in the history
  10. Remove unused method

    nighoggDatatype committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    a7d3eb0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    732447d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e90e3a8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a0313e1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cf57033 View commit details
    Browse the repository at this point in the history
  15. Fix typos

    nighoggDatatype committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6c11a8e View commit details
    Browse the repository at this point in the history
  16. Improve code quality

    nighoggDatatype committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    c0ab2df View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6bb1aa1 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    438d93c View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Configuration menu
    Copy the full SHA
    dd21308 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from nighoggDatatype/branch-A-CodeQuality

    Large improvements to code quality
    nighoggDatatype authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    e9ae6af View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into branch-A-Assertions

    Add one additional assertion for bad code path
    
    Fix at least some of the code quality issues present in branch-A-Assertions
    nighoggDatatype committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    a9ac758 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4d4f3b0 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #4 from nighoggDatatype/branch-A-Assertions

    Add assertions and introduce 2 bug fixes
    nighoggDatatype authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    1a4f6f5 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3 from nighoggDatatype/branch-A-Streams-Lambda

    Add Streams and Lambdas
    nighoggDatatype authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    f472d0d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    41f5db3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    97dcd14 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c4157f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    452b578 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f615c4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    003db68 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df960cd View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Configuration menu
    Copy the full SHA
    0083b41 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06eeccc View commit details
    Browse the repository at this point in the history