[Sherman Ho] iP #232
Open
[Sherman Ho] iP #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. Good time for automated testing
…ause line endings shouldn't matter
Code does not implement saving Need to persist the change across runs Let's: * Add and call code to load and save data * Add file safe string functions to tasks
Source branch we are merging from spreads out Date parsing too wide This increases the possiblity for inconsistency Let's move the parsing of strings to LocalDate into the Deadline class
Large improvements to code quality
Add one additional assertion for bad code path Fix at least some of the code quality issues present in branch-A-Assertions
Add assertions and introduce 2 bug fixes
Add Streams and Lambdas
…sages accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done Week 2 work. Submitting pull request