Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotations in Dockerfile example #1717

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

mohammad7t
Copy link
Contributor

Docker build raises error without those quotations.

@aviatesk
Copy link
Member

@mhsekhavat Thanks for your contribution !
Could you tell me your OS ?

I think this may cause something like this.
In short, the need for quotations may depend on an user's OS.

@wadethestealth wadethestealth added awaiting update Waiting for response/new news and removed reviewable ✔️ labels Jul 25, 2019
@mohammad7t
Copy link
Contributor Author

@aviatesk My OS is Debian Linux.

As docker documentation says, exec form will be parsed as JSON:

Note: The exec form is parsed as a JSON array, which means that you must use double-quotes (“) around words not single-quotes (‘).

@wadethestealth
Copy link
Member

@mhsekhavat thanks for the contribution

@wadethestealth wadethestealth merged commit a9d0671 into nteract:master Jul 26, 2019
@wadethestealth wadethestealth removed the awaiting update Waiting for response/new news label Jul 26, 2019
@aviatesk
Copy link
Member

@mhsekhavat
Thanks for your description and contributions ! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📃 Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants