Skip to content

Commit

Permalink
Merge pull request #1717 from mhsekhavat/patch-1
Browse files Browse the repository at this point in the history
Add missing quotations in Dockerfile example
  • Loading branch information
wadethestealth authored Jul 26, 2019
2 parents 54e5f89 + eb85403 commit a9d0671
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions docs/Usage/RemoteKernelConnection.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ RUN chmod +x /tini
ENV JUPYTER_TOKEN=my_secret_token # you can also pass this at runtime

EXPOSE 8888
ENTRYPOINT [/tini, --]
ENTRYPOINT ["/tini", "--"]
# --no-browser & --port aren't strictly necessary. presented here for clarity
CMD [jupyter-notebook, --no-browser, --port=8888]
CMD ["jupyter-notebook", "--no-browser", "--port=8888"]
# if running as root, you need to explicitly allow this:
# CMD [jupyter-notebook, --allow-root, --no-browser, --port=8888]
# CMD ["jupyter-notebook", "--allow-root", "--no-browser", "--port=8888"]

```

Expand All @@ -90,8 +90,8 @@ version: '2'
services:
hydro:
build: .
entrypoint: [/tini, --]
command: [jupyter-notebook, --allow-root, --no-browser, --port=8888]
entrypoint: ["/tini", "--"]
command: ["jupyter-notebook", "--allow-root", "--no-browser", "--port=8888"]
ports:
- 8888:8888
environment:
Expand Down Expand Up @@ -151,8 +151,8 @@ RUN chmod +x /tini
ENV JUPYTER_TOKEN=my_secret_token # you can also pass this at runtime
EXPOSE 8888
ENTRYPOINT [/tini, --]
CMD [jupyter-notebook, --no-browser, --port=8888]
ENTRYPOINT ["/tini", "--"]
CMD ["jupyter-notebook", "--no-browser", "--port=8888"]
RUN pip install markdown # <- installing new package
```
Expand Down

0 comments on commit a9d0671

Please sign in to comment.