Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing quotations in Dockerfile example #1717

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Add missing quotations in Dockerfile example #1717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea912f6
Add missing quotations in Dockerfile example
mohammad7t Jul 20, 2019
eb85403
Update RemoteKernelConnection.md
mohammad7t Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/Usage/RemoteKernelConnection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ RUN chmod +x /tini
ENV JUPYTER_TOKEN=my_secret_token # you can also pass this at runtime

EXPOSE 8888
ENTRYPOINT [/tini, --]
ENTRYPOINT ["/tini", "--"]
# --no-browser & --port aren't strictly necessary. presented here for clarity
CMD [jupyter-notebook, --no-browser, --port=8888]
CMD ["jupyter-notebook", "--no-browser", "--port=8888"]
# if running as root, you need to explicitly allow this:
# CMD [jupyter-notebook, --allow-root, --no-browser, --port=8888]
# CMD ["jupyter-notebook", "--allow-root", "--no-browser", "--port=8888"]

```

Expand All @@ -90,8 +90,8 @@ version: '2'
services:
hydro:
build: .
entrypoint: [/tini, --]
command: [jupyter-notebook, --allow-root, --no-browser, --port=8888]
entrypoint: ["/tini", "--"]
command: ["jupyter-notebook", "--allow-root", "--no-browser", "--port=8888"]
ports:
- 8888:8888
environment:
Expand Down Expand Up @@ -151,8 +151,8 @@ RUN chmod +x /tini
ENV JUPYTER_TOKEN=my_secret_token # you can also pass this at runtime

EXPOSE 8888
ENTRYPOINT [/tini, --]
CMD [jupyter-notebook, --no-browser, --port=8888]
ENTRYPOINT ["/tini", "--"]
CMD ["jupyter-notebook", "--no-browser", "--port=8888"]

RUN pip install markdown # <- installing new package
```
Expand Down