NNS changes from C# #442
Merged
NNS changes from C# #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
This was referenced Oct 31, 2024
Merged
contracts/nns/contract.go
Outdated
| @@ -629,7 +629,8 @@ func Resolve(name string, typ recordtype.Type) []string { | |||
| } | |||
|
|
|||
| ctx := storage.GetReadOnlyContext() | |||
| return resolve(ctx, nil, name, typ, 2) | |||
| res := []string{} | |||
There was a problem hiding this comment.
the compiler understands inline nil but not empty slice?
There was a problem hiding this comment.
hm, yes, why not just []string{} as an arg?
contracts/nns/contract.go
Outdated
| @@ -461,16 +463,30 @@ func saveDomain(ctx storage.Context, name, email string, refresh, retry, expire, | |||
| putSoaRecord(ctx, name, email, refresh, retry, expire, ttl) | |||
| } | |||
|
|
|||
| // Renew increases domain expiration date. | |||
| func Renew(name string) int64 { | |||
| // RenewDefault increases domain expiration date for 1 year. | |||
contracts/nns/contract.go
Outdated
| return Renew(name, 1) | ||
| } | ||
|
|
||
| // Renew increases domain expiration date up to the specified amount of years. |
| // Renew increases domain expiration date up to the specified amount of years. | ||
| func Renew(name string, years int) int64 { | ||
| if years < 1 || years > 10 { | ||
| panic("invalid renewal period value") |
There was a problem hiding this comment.
limit not mentioned in docs
carpawell
previously approved these changes
Nov 12, 2024
contracts/nns/contract.go
Outdated
| @@ -629,7 +629,8 @@ func Resolve(name string, typ recordtype.Type) []string { | |||
| } | |||
|
|
|||
| ctx := storage.GetReadOnlyContext() | |||
| return resolve(ctx, nil, name, typ, 2) | |||
| res := []string{} | |||
There was a problem hiding this comment.
hm, yes, why not just []string{} as an arg?
|
Let's merge #420 then, some changes are present there and if we don't have any questions there it'd simplify things a bit. |
|
@roman-khimov, done, can be rebased, also linter asks for attention. |
Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov
force-pushed
the
nns-upd-breaking
branch
from
ddf8767
to
70d910f
Compare
Port neo-project/non-native-contracts#13. Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov
force-pushed
the
nns-upd-breaking
branch
from
70d910f
to
507a41a
Compare
Port neo-project/non-native-contracts#11. Signed-off-by: Anna Shaleva <[email protected]>
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
nns-upd-breaking
branch
from
507a41a
to
87a9e16
Compare
carpawell
approved these changes
Nov 12, 2024
cthulhu-rider
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates and replaces #267. Most of the changes are already merged via other PRs, but:
Otherwise they're OK to stay here for now (binaries/bindings not updated till we make decisions).