NameService: minor improvements, part 6 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
added a commit
to AnnaShaleva/neofs-contract
that referenced
this pull request
Sep 15, 2022
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
nns-upd-6
branch
from
53c0512
to
4a769b1
Compare
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 16, 2022
Follow the neo-project#11 notation, close neo-project#24.
AnnaShaleva
force-pushed
the
nns-upd-6
branch
from
4a769b1
to
d633cda
Compare
Ref. #25 (comment) @superboyiii, Rebased onto current master and doesn't depend on the rest of "Minor NNS improvements" PRs set, can be merged immediately. Although, this PR is less important than the remaining parts 2-5. |
Let me try it. |
|
Tested OK. |
superboyiii
approved these changes
Sep 26, 2022
erikzhang
approved these changes
Sep 27, 2022
roman-khimov
pushed a commit
to nspcc-dev/neofs-contract
that referenced
this pull request
Oct 31, 2024
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov
pushed a commit
to nspcc-dev/neofs-contract
that referenced
this pull request
Nov 12, 2024
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov
pushed a commit
to nspcc-dev/neofs-contract
that referenced
this pull request
Nov 12, 2024
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov
pushed a commit
to nspcc-dev/neofs-contract
that referenced
this pull request
Nov 12, 2024
Port neo-project/non-native-contracts#31. Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sixth part of NNS contract update.
Includes:
Renewnotification event, close Renew() miss an event when success #24.