Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): full support custom secure host for module federation #25288

Merged
merged 1 commit into from
May 28, 2024

Conversation

vadimka123
Copy link
Contributor

Related Issue(s)

Fixes #
#21210

@vadimka123 vadimka123 requested a review from a team as a code owner May 23, 2024 07:07
@vadimka123 vadimka123 requested a review from Coly010 May 23, 2024 07:07
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 24, 2024 6:38am

Copy link

nx-cloud bot commented May 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 25b2244. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run e2e-webpack:e2e
nx run e2e-react-module-federation:e2e
nx run e2e-vue:e2e
nx run e2e-storybook:e2e
nx run e2e-release:e2e
nx run e2e-rollup:e2e
nx run e2e-remix:e2e
nx run e2e-plugin:e2e
✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@vadimka123
Copy link
Contributor Author

@xiongemi , can you please review?

@ndcunningham
Copy link
Contributor

LGTM @Coly010 do you have any concerns?

@Coly010 Coly010 merged commit b9e190d into nrwl:master May 28, 2024
6 checks passed
ndcunningham pushed a commit that referenced this pull request May 28, 2024
FrozenPandaz pushed a commit that referenced this pull request May 28, 2024
…5288)

## Related Issue(s)

Fixes #
#21210

Co-authored-by: Vadim Goy <[email protected]>
(cherry picked from commit b9e190d)
Copy link

github-actions bot commented Jun 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants