fix(react): full support custom secure host for module federation (#2…

…5288) ## Related Issue(s) Fixes # #21210 Co-authored-by: Vadim Goy <[email protected]> (cherry picked from commit b9e190d)
nrwl · May 28, 2024 · 345a651 · 345a651
1 parent c3ca5a0
commit 345a651
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -127,19 +127,23 @@ async function startRemotes(
       } => typeof r !== 'string' && r.remoteName === app
     )?.configuration;
 
+    const defaultOverrides = {
+      ...(options.host ? { host: options.host } : {}),
+      ...(options.ssl ? { ssl: options.ssl } : {}),
+      ...(options.sslCert ? { sslCert: options.sslCert } : {}),
+      ...(options.sslKey ? { sslKey: options.sslKey } : {}),
+    };
     const overrides =
       target === 'serve'
         ? {
             watch: true,
-            ...(options.host ? { host: options.host } : {}),
-            ...(options.ssl ? { ssl: options.ssl } : {}),
-            ...(options.sslCert ? { sslCert: options.sslCert } : {}),
-            ...(options.sslKey ? { sslKey: options.sslKey } : {}),
             ...(isUsingModuleFederationDevServerExecutor
               ? { isInitialHost: false }
               : {}),
+            ...defaultOverrides,
           }
-        : {};
+        : { ...defaultOverrides };
+
     remoteIters.push(
       await runExecutor(
         {