fix(react): full support custom secure host for module federation

nrwl · May 23, 2024 · 1fcbe6b · 1fcbe6b
1 parent 261b0ff
commit 1fcbe6b
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -127,19 +127,21 @@ async function startRemotes(
       } => typeof r !== 'string' && r.remoteName === app
     )?.configuration;
 
+    const defaultOverrides = {
+      ...(options.host ? { host: options.host } : {}),
+      ...(options.ssl ? { ssl: options.ssl } : {}),
+      ...(options.sslCert ? { sslCert: options.sslCert } : {}),
+      ...(options.sslKey ? { sslKey: options.sslKey } : {}),
+    };
     const overrides =
       target === 'serve'
         ? {
-            watch: true,
-            ...(options.host ? { host: options.host } : {}),
-            ...(options.ssl ? { ssl: options.ssl } : {}),
-            ...(options.sslCert ? { sslCert: options.sslCert } : {}),
-            ...(options.sslKey ? { sslKey: options.sslKey } : {}),
-            ...(isUsingModuleFederationDevServerExecutor
-              ? { isInitialHost: false }
-              : {}),
-          }
-        : {};
+          watch: true,
+          ...(isUsingModuleFederationDevServerExecutor ? { isInitialHost: false } : {}),
+          ...defaultOverrides,
+        }
+        : { ...defaultOverrides };
+
     remoteIters.push(
       await runExecutor(
         {