-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devkit): respect expectComments when parsing json #21584
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 29298ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
[This change](https://github.com/nrwl/nx/pull/10538/files#diff-7f0343ab5195423aded5b2ed7b98cef5fd459edbb66227eb67f0c0fa25eaf3a4L40-L50) introduced a small performance regression by removing the check for the `expectComments` flag.
@FrozenPandaz Do you need an issue for this? Or is a PR sufficient? |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This change introduced a small performance regression by removing the check for the
expectComments
flag.Current Behavior
Passing
expectComments
toparseJson
does nothing.Expected Behavior
Passing
expectComments
toparseJson
should bypass the optimisticJSON.parse
since in those cases it is expected to fail.Related Issue(s)