Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): respect expectComments when parsing json #21584

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

llwt
Copy link
Contributor

@llwt llwt commented Feb 4, 2024

This change introduced a small performance regression by removing the check for the expectComments flag.

Current Behavior

Passing expectComments to parseJson does nothing.

Expected Behavior

Passing expectComments to parseJson should bypass the optimistic JSON.parse since in those cases it is expected to fail.

Related Issue(s)

@llwt llwt requested a review from a team as a code owner February 4, 2024 10:47
@llwt llwt requested a review from FrozenPandaz February 4, 2024 10:47
Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 6, 2024 4:32pm

@llwt
Copy link
Contributor Author

llwt commented Feb 7, 2024

@FrozenPandaz Do you need an issue for this? Or is a PR sufficient?

@AgentEnder AgentEnder merged commit ead05ad into nrwl:master Feb 22, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
@llwt llwt deleted the patch-3 branch July 1, 2024 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants