Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseJson utility does not respect expectComments #21914

Closed
3 of 4 tasks
llwt opened this issue Feb 21, 2024 · 2 comments
Closed
3 of 4 tasks

parseJson utility does not respect expectComments #21914

llwt opened this issue Feb 21, 2024 · 2 comments

Comments

@llwt
Copy link
Contributor

llwt commented Feb 21, 2024

Current Behavior

When passing expectJson to parseJson, an attempt is made to JSON.parse

Expected Behavior

When passing expectJson to parseJson, JSON.parse is skipped and jsonc-parser is directly used

GitHub Repo

No response

Steps to Reproduce

See test case here: https://github.com/nrwl/nx/pull/21584/files

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 18.15.0
   OS     : darwin-arm64
   pnpm   : 8.9.2
   
   nx (global)        : 18.0.1
   nx                 : 17.3.0-rc.1
   @nx/js             : 0.0.1
   @nx/jest           : 0.0.1
   @nx/eslint         : 0.0.1
   @nx/workspace      : 0.0.1
   @nx/angular        : 0.0.1
   @nx/cypress        : 0.0.1
   @nx/detox          : 0.0.1
   @nx/devkit         : 0.0.1
   @nx/esbuild        : 17.3.0-rc.1
   @nx/eslint-plugin  : 17.3.0-rc.1
   @nx/expo           : 0.0.1
   @nx/express        : 0.0.1
   @nx/nest           : 0.0.1
   @nx/next           : 0.0.1
   @nx/node           : 0.0.1
   @nx/playwright     : 17.3.0-rc.1
   @nx/plugin         : 0.0.1
   @nx/react          : 0.0.1
   @nx/react-native   : 0.0.1
   @nx/rollup         : 0.0.1
   @nx/remix          : 0.0.1
   @nx/storybook      : 0.0.1
   @nrwl/tao          : 0.0.1
   @nx/vite           : 0.0.1
   @nx/vue            : 0.0.1
   @nx/web            : 0.0.1
   @nx/webpack        : 0.0.1
   typescript         : 5.3.3
   ---------------------------------------
   Community plugins:
   @monodon/rust      : 1.3.2
   @ngrx/effects      : 17.0.1
   @ngrx/router-store : 17.0.1
   @ngrx/store        : 17.0.1
   ---------------------------------------
   Local workspace plugins:
   	 @nx/workspace-plugin
   	 @nx/react-native
   	 @nx/playwright
   	 @nx/storybook
   	 @nx/workspace
   	 @nx/angular
   	 @nx/cypress
   	 @nx/esbuild
   	 @nx/express
   	 @nx/webpack
   	 @nx/eslint
   	 @nx/plugin
   	 @nx/rollup
   	 @nx/detox
   	 @nx/react
   	 @nx/remix
   	 @nx/expo
   	 @nx/jest
   	 @nx/nest
   	 @nx/next
   	 @nx/node
   	 @nx/nuxt
   	 @nx/vite
   	 @nx/vue
   	 @nx/web
   	 @nx/js
   	 nx
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nrwl/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
     - @nx/[email protected]
   
   To fix this, run `nx migrate [email protected]`

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Test added and fix applied in this PR: #21584

@llwt llwt added the type: bug label Feb 21, 2024
@AgentEnder
Copy link
Member

Fixed by #21584

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants