fix(core): fix missing top-level dependencies in publishable libs #17730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daiscog
force-pushed
the
bugfix-missing-top-level-deps
branch
from
b5f5c88 to
9819e61
Compare
Fix dependencies sometimes being omitted from the list of top-level dependencies when they are both top-level and transitive closed 17729
daiscog
force-pushed
the
bugfix-missing-top-level-deps
branch
from
9819e61 to
20c7df1
Compare
AgentEnder
approved these changes
Jan 29, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dependencies sometimes being omitted from the list of top-level dependencies when they are both top-level and transitive
Fixes #17729
This is the same fix as #14832 but in the
jspackage (the previous fix was in theworkspacepackage).An alternative fix would be to make the
jspackage delegate to theworkspaceone to avoid the code duplication.