collectDependencies marks some top-level deps as not top-level (angular builder)

[daiscog]

Current Behavior

When automatically addiing peerDependencies to the built package.json files for publishable libs, some top-level dependencies can be missing if they are also dependencies of other dependencies.

Expected Behavior

All top-level dependencies are included in the peerDependencies section of the built package.json, even if they are also dependencies of other dependencies.

GitHub Repo

No response

Steps to Reproduce

With publishable Angular libs where:

`lib-a` imports from `lib-b` and also from npm package `@external/package`
`lib-b` imports from npm package `@external/package`

After running nx run lib-a:build, the dist package.json file for the lib does not contain @external/package in the peerDependencies, even though lib-a imports from it.

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 16.16.0
   OS     : darwin x64
   npm    : 8.11.0
   Hasher : Native
   
   nx                      : 16.3.2
   @nx/js                  : 16.3.2
   @nx/jest                : 16.3.2
   @nx/linter              : 16.3.2
   @nx/workspace           : 16.3.2
   @nrwl/angular           : 16.3.2
   @nx/cypress             : 16.3.2
   @nx/devkit              : 16.3.2
   @nrwl/eslint-plugin-nx  : 16.3.2
   @nrwl/tao               : 16.3.2
   @nx/webpack             : 16.3.2
   typescript              : 4.8.4
   ---------------------------------------
   Community plugins:
   @ng-bootstrap/ng-bootstrap       : 13.1.1
   @ngrx/effects                    : 14.3.3
   @ngrx/store                      : 14.3.3
   ---------------------------------------

Failure Logs

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

Same as #14513 which fixed the issue in @nx/workspace (which is what the Angular package builder used back in nx 14) - however, it seems out the affected buggy code is duplicated in the @nx/js pacakge as well, and the Angular builder delegates to that package now.

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.