fix(core): fix missing top-level dependencies

[daiscog]

Fix dependencies sometimes being omitted from the list of top-level dependencies when they are both top-level and transitive

closed #14513

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2023 6:27pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a08ca36. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --base= --head=
• nx affected --target=e2e --base=37038463ed7a33411ade8aaca6510a3c5be56ac3 --head=a08ca36672d9aa13f2f92b0b8e64652c3d45132b --parallel=1
• nx affected --target=test --base=37038463ed7a33411ade8aaca6510a3c5be56ac3 --head=a08ca36672d9aa13f2f92b0b8e64652c3d45132b --parallel=1
• nx affected --target=build --base=37038463ed7a33411ade8aaca6510a3c5be56ac3 --head=a08ca36672d9aa13f2f92b0b8e64652c3d45132b --parallel=3
• nx run-many -t check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=37038463ed7a33411ade8aaca6510a3c5be56ac3 --head=a08ca36672d9aa13f2f92b0b8e64652c3d45132b --parallel=3
• nx-cloud record -- nx format:check --base=37038463ed7a33411ade8aaca6510a3c5be56ac3 --head=a08ca36672d9aa13f2f92b0b8e64652c3d45132b
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[AgentEnder]

Hey @daiscog! This looks good. You have some conflicts, and circle seems to be having some issues on this PR. Can you rebase and push it back up? If Circle still fails we may have to cherry-pick it over to a different branch.

[daiscog]

Hi @AgentEnder

Sorry for the delay. I've now rebased with resolved conflicts.

I am seeing a lot of seemingly unrelated test failures when running nx affected --target=test locally though.

I've also had to push with --no-verify as I'm getting the following error otherwise:

I believe I've followed all contribution instructions correctly. Not sure if I'm missing something. 🤷‍♂️

[daiscog]

@AgentEnder Circle is running now, but there's a failed test for something unrelated to the PR (scaffolding an SSR MF project)

All tests passing now. :)

[daiscog]

@AgentEnder anything else I can do to help get this over the line?

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.