Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more strict options #8121

Closed
7 of 18 tasks
puku0x opened this issue Dec 11, 2021 · 3 comments
Closed
7 of 18 tasks

Enable more strict options #8121

puku0x opened this issue Dec 11, 2021 · 3 comments
Labels
outdated scope: misc Misc issues type: feature

Comments

@puku0x
Copy link
Contributor

puku0x commented Dec 11, 2021 •
edited
Loading

Description

Angular recently added two strict options for new projects. angular/angular-cli#21538

Motivation

Those options are enabled by default in the latest Angular.
They look great in terms of the type safety. Why not apply them to all other frameworks that Nx supports?

Suggested Implementation

  1. Fix existing generators
  2. Add --strict option to other generators

The current status of supporting the two strict options.

Alternate Implementations

Hard coding to the templates? Sounds nice.
https://github.com/angular/angular-cli/blob/4bf3cd76f11840ab0fa808a95cde0f5c8681087f/packages/schematics/angular/workspace/files/tsconfig.json.template#L6-L12
This was referenced Dec 11, 2021
Merged
Merged
@AgentEnder AgentEnder added the scope: misc Misc issues label Dec 11, 2021
@jaysoo
Copy link
Member

jaysoo commented Dec 15, 2021

Merged, thanks!

@jaysoo jaysoo closed this as completed Dec 15, 2021
@puku0x
Copy link
Contributor Author

puku0x commented Dec 15, 2021

@jaysoo Thank you for taking a look at this issue. I will create other PRs to ensure strict mode later.

@puku0x puku0x mentioned this issue Dec 15, 2021
Merged
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated scope: misc Misc issues type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaysoo @puku0x @AgentEnder