Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): update complier options for strict mode #8126

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Dec 11, 2021

Current Behavior

@nrwl/angular:application and @nrwl/angular:library generators don't add following two new compiler options for strict mode.

Expected Behavior

noImplicitOverride and noPropertyAccessFromIndexSignature are enabled for the newly created projects.

Related Issue(s)

#8121

@vercel
Copy link

vercel bot commented Dec 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7GbUpr14pa5xaDRCDaXtp6oGg2mx
✅ Preview: Canceled

@puku0x puku0x marked this pull request as ready for review December 11, 2021 12:56
@puku0x puku0x mentioned this pull request Dec 11, 2021
18 tasks
@jaysoo
Copy link
Member

jaysoo commented Dec 15, 2021

Thanks!

@jaysoo jaysoo merged commit e77c498 into nrwl:master Dec 15, 2021
@puku0x puku0x deleted the 8121-feat-angular-update-strict-options branch December 15, 2021 03:40
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants