Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@nx/web:app "strict" option #9238

Closed
1 task
ziacik opened this issue Mar 8, 2022 · 7 comments · Fixed by #23457
Closed
1 task

@nx/web:app "strict" option #9238

ziacik opened this issue Mar 8, 2022 · 7 comments · Fixed by #23457
Assignees
@ndcunningham
Labels
community This is a good first issue for contributing outdated scope: react Issues related to React support for Nx type: feature

Comments

@ziacik
Copy link
Contributor

ziacik commented Mar 8, 2022 •
edited
Loading

Description

@nrwl/js:lib, @nrwl/react:app and many others have a "strict" option, @nrwl/web:app should have one too.

Motivation

To have consistency between generators, and to be able to generate strict apps, by default.
@puku0x puku0x mentioned this issue Mar 11, 2022
Closed
18 tasks
@AgentEnder AgentEnder added the scope: react Issues related to React support for Nx label Mar 11, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Nov 17, 2022
@ziacik
Copy link
Contributor Author

ziacik commented Nov 17, 2022

Don't close, please.

@github-actions github-actions bot removed the stale label Nov 18, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jul 26, 2023
@ziacik
Copy link
Contributor Author

ziacik commented Jul 27, 2023

Not stale. Still no strict option in @nx/web:application generator, still generated with non-strict tsconfigs. In 16.5.5.

@github-actions github-actions bot removed the stale label Jul 28, 2023
@ziacik ziacik changed the title @nrwl/web:app "strict" option @nx/web:app "strict" option Jul 30, 2023
@FrozenPandaz FrozenPandaz added the community This is a good first issue for contributing label Apr 2, 2024
@FrozenPandaz
Copy link
Collaborator

Would someone in the community like to open a PR?

@ziacik
Copy link
Contributor Author

ziacik commented Apr 28, 2024

I might try to make this one.

ndcunningham added a commit that referenced this issue May 16, 2024
@ndcunningham
fix(web): Add strict mode
172249e 
closes: #9238
@ndcunningham ndcunningham mentioned this issue May 16, 2024
Merged
ndcunningham added a commit that referenced this issue May 16, 2024
@ndcunningham
fix(web): Add strict mode
6f63600 
closes: #9238
ndcunningham added a commit that referenced this issue May 16, 2024
@ndcunningham
fix(web): Add strict mode
b1b67b7 
closes: #9238
ndcunningham added a commit that referenced this issue May 16, 2024
@ndcunningham
fix(web): Add strict mode
9b575b0 
closes: #9238
ndcunningham added a commit that referenced this issue May 17, 2024
@ndcunningham
fix(web): Add strict mode (#23457)
0f47f03 
This PR adds the option of `strict` when using `@nx/web:app` generator.

It also updates the application generator by separating utility
functions into their own modules.


closes: #9238
ndcunningham added a commit that referenced this issue May 17, 2024
@ndcunningham
fix(web): Add strict mode for @nx/web
eef3603 
Reference: #9238
@ndcunningham ndcunningham mentioned this issue May 17, 2024
Merged
FrozenPandaz pushed a commit that referenced this issue May 21, 2024
@ndcunningham @FrozenPandaz
fix(web): Add strict mode (#23457)
2116acb 
This PR adds the option of `strict` when using `@nx/web:app` generator.

It also updates the application generator by separating utility
functions into their own modules.

closes: #9238
(cherry picked from commit 0f47f03)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ndcunningham ndcunningham

Labels
community This is a good first issue for contributing outdated scope: react Issues related to React support for Nx type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(web): Add strict mode nrwl/nx
4 participants
@ndcunningham @ziacik @AgentEnder @FrozenPandaz