Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): add noImplicitOverride and noPropertyAccessFromIndexSignature to workspace tsconfig #21538

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

alan-agius4
Copy link
Collaborator

With this change, when the workspace is created in strict mode (the default) we add the following additional tsconfig options;

Closes #21279

…cessFromIndexSignature` to workspace tsconfig

With this change, when the workspace is created in strict mode (the default) we add the following  additional tsconfig options;
- [noImplicitOverride](https://www.typescriptlang.org/tsconfig#noImplicitOverride)
- [noPropertyAccessFromIndexSignature](https://www.typescriptlang.org/tsconfig#noPropertyAccessFromIndexSignature)

Closes #21279
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 9, 2021
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@alan-agius4 alan-agius4 requested a review from clydin August 9, 2021 17:14
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 9, 2021
@alan-agius4 alan-agius4 merged commit 3ba13f4 into angular:master Aug 9, 2021
@alan-agius4 alan-agius4 deleted the tsconfig-options branch August 9, 2021 18:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable more linter checks in tsconfig.json by default
2 participants