-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nx/js:tsc build fails on Windows with Yarn PnP after 19.6.1 #27656
Comments
It looks like |
…rue (#28083) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Sometimes tslib is missing even though it is needed for typechecks. ## Expected Behavior tslib is installed when needed. i.e. `importHelpers: true` ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27656
Hello, thanks for the reply This is working as expected either on 19.6.0 or in 19.6.1 without PnP without adding the dependency at root level I also tried with 19.8.2 and still experience the same error. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
Typescript compilation fails when migrating from nx 19.6.0 to 19.6.1 on Windows with Yarn PnP
Expected Behavior
The build should be successful as on 19.6.0
GitHub Repo
https://github.com/fpaul-1A/test-nx-pnp-windows/tree/19.6.1
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
The issue doesn't appear with
nodeLinker: node-modules
.Also, it seems to be somehow related to this modification #27300, the build succeeds when reverting the change on
tsc.impl.ts
The text was updated successfully, but these errors were encountered: