cleanup(js): fix test cases on windows

[robertIsaac]

Current Behavior

running nx test js fail on windows

Expected Behavior

running nx test js succeed

side notes

1. I was skipping packages/js/src/plugins/typescript/plugin.spec.ts because it makes all tests fail, and even in wsl it's very flaky, it fail 90% of the times, but I couldn't figure out why
   I think it's worth looking at from someone with more experience with the repo
2. for some of the cases that I fixed I'm not sure if I should change the code to always return / or should change the test to adapt / in linux and \ in windows, so please if I mistaken one of them let me know and I will do it the other way around but I believe it should be fine since in windows foo/bar does work as a path still

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Aug 14, 2024 3:53pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6a98430. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx affected --targets=lint,test,build,e2e,e2e-ci --base=54f52bb8e89fe5940564641106c4fd3ce687db91 --head=6a984301191022717cde29a7641ad3cb8ab8b219 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=54f52bb8e89fe5940564641106c4fd3ce687db91 --head=6a984301191022717cde29a7641ad3cb8ab8b219
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[leosvelperez]

@robertIsaac thanks for sending these fixes! Could you please rebase the PR? I believe some of the fixes here might have already landed on master as part of other changes.

[robertIsaac]

@leosvelperez done

[robertIsaac]

and @leosvelperez
about packages/js/src/plugins/typescript/plugin.spec.ts test
do you have any idea how to fix

  ● Plugin: @nx/js/typescript › should create nodes for root tsconfig.json files                                                                                                                                                 
                                                                                                                                                                                                                                 
    EBUSY: resource busy or locked, rmdir 'C:\Users\rober\AppData\Local\Temp\typescript-plugin5yXujB'

      82 |
      83 |   cleanup() {
    > 84 |     rmSync(this.tempDir, { recursive: true });
         |           ^
      85 |     setWorkspaceRoot(this.previousWorkspaceRoot);
      86 |   }
      87 |

      at TempFs.cleanup (../nx/src/internal-testing-utils/temp-fs.ts:84:11)
      at Object.<anonymous> (src/plugins/typescript/plugin.spec.ts:32:12)

and if this file is enabled, almost all of the tests fail

with it being ignored (using xdescribe)

Test Suites: 1 skipped, 29 passed, 29 of 30 total
Tests:       33 skipped, 266 passed, 299 total
Snapshots:   229 passed, 229 total
Time:        15.468 s
Ran all test suites.

with it being active

Test Suites: 27 failed, 3 passed, 30 total
Tests:       31 failed, 17 passed, 48 total
Snapshots:   15 failed, 53 passed, 68 total
Time:        3.904 s, estimated 20 s

[leosvelperez]

and @leosvelperez
about packages/js/src/plugins/typescript/plugin.spec.ts test
do you have any idea how to fix

I'm unsure about that one. Let's merge this and I'll try to set some time next week to check it.

[leosvelperez]

Thanks for the contribution!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.