-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add release key for Bryan English #42102
Conversation
Adds Bryan English and his public key to the README for releases.
Is the most recent release signed with this key? If so, I suppose we might want to fast-track so that someone checking the integrity of a download doesn't fail to find the relevant key in the README file. |
@Trott No, it was signed by @BethGriggs as per https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#adding-new-releasers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Landed in bcc523e |
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Notable changes: * (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) nodejs#42093 * (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) nodejs#41310 * (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) nodejs#35025 * doc: add release key for Bryan English (Bryan English) nodejs#42102 Dependency Updates: * deps: update nghttp2 to 1.47.0 (Yash Ladha) nodejs#42127 * deps: upgrade npm to 8.5.2 (npm team) nodejs#42122 New Collaborators: * doc: add JakobJingleheimer to collaborators list (Jacob Smith) nodejs#42185 * doc: move bnoordhuis back to collaborators (Ben Noordhuis) nodejs#42064 PR-URL: nodejs#42254
Notable changes: * (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) #42093 * (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) #41310 * (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) #35025 * doc: add release key for Bryan English (Bryan English) #42102 Dependency Updates: * deps: update nghttp2 to 1.47.0 (Yash Ladha) #42127 * deps: upgrade npm to 8.5.2 (npm team) #42122 New Collaborators: * doc: add JakobJingleheimer to collaborators list (Jacob Smith) #42185 * doc: move bnoordhuis back to collaborators (Ben Noordhuis) #42064 PR-URL: #42254
Notable changes: * doc: * add release key for Bryan English (Bryan English) #42102
Notable changes: * doc: * add release key for Bryan English (Bryan English) #42102
Notable changes: * doc: * add release key for Bryan English (Bryan English) #42102
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Adds Bryan English and his public key to the README for releases. PR-URL: nodejs#42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
Notable changes: * (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) nodejs#42093 * (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) nodejs#41310 * (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) nodejs#35025 * doc: add release key for Bryan English (Bryan English) nodejs#42102 Dependency Updates: * deps: update nghttp2 to 1.47.0 (Yash Ladha) nodejs#42127 * deps: upgrade npm to 8.5.2 (npm team) nodejs#42122 New Collaborators: * doc: add JakobJingleheimer to collaborators list (Jacob Smith) nodejs#42185 * doc: move bnoordhuis back to collaborators (Ben Noordhuis) nodejs#42064 PR-URL: nodejs#42254
Notable changes: * doc: * add release key for Bryan English (Bryan English) nodejs#42102 PR-URL: nodejs#42200
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas) PR-URL: #42899
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (@devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas) PR-URL: #42899
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
Adds Bryan English and his public key to the README for releases.