Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14 backport] deps: V8: cherry-pick cc9a8a37445e #41826

Closed
wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Feb 2, 2022

Original commit message:

fix overflow check in error formatting

Bug: v8:12494
Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Gus Caplan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#78909}

Refs: v8/v8@cc9a8a3

Original commit message:

    fix overflow check in error formatting

    Bug: v8:12494
    Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Gus Caplan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78909}

Refs: v8/v8@cc9a8a3
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v14.x v8 engine Issues and PRs related to the V8 dependency. labels Feb 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2022

@devsnek devsnek requested a review from mcollina February 3, 2022 14:38
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richardlau richardlau force-pushed the v14.x-staging branch 2 times, most recently from 30ba86c to 7f2825b Compare March 17, 2022 23:36
juanarbol pushed a commit that referenced this pull request Apr 28, 2022
Original commit message:

    fix overflow check in error formatting

    Bug: v8:12494
    Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Gus Caplan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78909}

Refs: v8/v8@cc9a8a3

PR-URL: #41826
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
@juanarbol
Copy link
Member

juanarbol commented Apr 28, 2022

Thank you!

Landed in 39e44f8 🎉

@juanarbol juanarbol closed this Apr 28, 2022
juanarbol added a commit that referenced this pull request Apr 28, 2022
Notable changes

V8:
V8 had a stack overflow issue affecting the `vm` module, cherry-picking `941b023
from V8 solves this issue.

Learn more at: #41826

Contributed by @devsnek

Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting v8/v8@367b0c1
from V8.

Learn more at: #42637

Contributed by Gabriel Schulhof (@legendecas)

PR-url: TBD
@juanarbol juanarbol mentioned this pull request Apr 28, 2022
juanarbol pushed a commit that referenced this pull request May 1, 2022
Original commit message:

    fix overflow check in error formatting

    Bug: v8:12494
    Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Gus Caplan <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78909}

Refs: v8/v8@cc9a8a3

PR-URL: #41826
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
juanarbol added a commit that referenced this pull request May 1, 2022
Notable Changes

doc:

* New release key for Bryan English
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v16.14.17`.
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
juanarbol added a commit that referenced this pull request May 1, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v16.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
juanarbol added a commit that referenced this pull request May 1, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v16.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
juanarbol added a commit that referenced this pull request May 2, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)
juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by @devsnek

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (@devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 4, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
juanarbol added a commit that referenced this pull request May 4, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
@aduh95 aduh95 deleted the cherrypick-41823-14x branch April 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants