-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v17.7.0 release proposal #42254
v17.7.0 release proposal #42254
Conversation
Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
PR-URL: #42049 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]>
PR-URL: #42073 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]>
Fixes: #34031 PR-URL: #42055 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
PR-URL: #42018 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #41310 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #42063 Refs: #42059 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #42064 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #41779 Refs: #41760 PR-URL: #41782 Reviewed-By: Matteo Collina <[email protected]>
Add explanation of case to be careful of in order to avoid native memory being kept alive. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42035 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
This should process the 4 oldest feature requests. Once we've confirmed these are ok we can adjust the days before an issue is marked as stale. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42082 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fix: #42040 PR-URL: #42053 Fixes: #42040 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #42041 Refs: https://coverage.nodejs.org/coverage-26f9a91cc9b178d3/lib/events.js.html#L156 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #42066 Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #42068 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #42092 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #41861 Fixes: #41774 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
The IncomingMessage.headers property was made non-enumerable in PR #35281. PR-URL: #42095 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
Add some test262 tests for `every`, add some `length` checks. Turns out properties need to be writable after all according to the test262 tests. PR-URL: #41974 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #41950 Fixes: #41950 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #35025 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #41404 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #42110 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
The subprocess might exit before the data is flushed. Run the assertion after the `'end'` event is emitted. PR-URL: #42046 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Building with ninja would speed up the build We have the documenation about building with ninja, but not easily discoverable. And present this early to the contributors. PR-URL: #41840 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #42078 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Original commit message: [riscv64] use callee save register in regexp Bug: v8:12502 Change-Id: I8d1b599fc945e276b70901953368768594470204 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3343861 Reviewed-by: ji qiu <[email protected]> Commit-Queue: ji qiu <[email protected]> Cr-Commit-Position: refs/heads/main@{#78421} Refs: v8/v8@b663343 PR-URL: #42067 Refs: v8/v8@77d5154 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
Original commit message: [riscv64] Move explicit specialization into .cc file Building with Gcc-10 causes error "explicit specialization in non-namespace scope". This change fixes it. Bug: v8:12649 Change-Id: I36b2b042b336c2dfd32ba5541fdbbdb8dc8b4fd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3473997 Reviewed-by: ji qiu <[email protected]> Commit-Queue: ji qiu <[email protected]> Cr-Commit-Position: refs/heads/main@{#79185} Refs: v8/v8@77d5154 PR-URL: #42067 Refs: v8/v8@b663343 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
- set the days so that we process ~ 40 issues so that we can see what kind of feedback we get on saying we are going to close stale feature requests - set the label to stale instead of stalled so that there is no race with the action that closes stalled issues - fix the links to the feature management doc Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42085 Reviewed-By: Mestery <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Refs: #41541 PR-URL: #42096 Refs: #41541 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mestery <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
With where are in the release cycle I don't want to have to go through all the testing again and cause additional work/delays. Those changes should get into the next release scheduled in two week's time. |
Release build on 8843725: https://ci-release.nodejs.org/job/iojs+release/8300 |
Notable changes: * (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) #42093 * (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) #41310 * (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) #35025 * doc: add release key for Bryan English (Bryan English) #42102 Dependency Updates: * deps: update nghttp2 to 1.47.0 (Yash Ladha) #42127 * deps: upgrade npm to 8.5.2 (npm team) #42122 New Collaborators: * doc: add JakobJingleheimer to collaborators list (Jacob Smith) #42185 * doc: move bnoordhuis back to collaborators (Ben Noordhuis) #42064 PR-URL: #42254
Force push to update commit message only. Rebuild on 05c2520: https://ci-release.nodejs.org/job/iojs+release/8301 |
Test runs:
|
Notable changes: * (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) #42093 * (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) #41310 * (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) #35025 * doc: add release key for Bryan English (Bryan English) #42102 Dependency Updates: * deps: update nghttp2 to 1.47.0 (Yash Ladha) #42127 * deps: upgrade npm to 8.5.2 (npm team) #42122 New Collaborators: * doc: add JakobJingleheimer to collaborators list (Jacob Smith) #42185 * doc: move bnoordhuis back to collaborators (Ben Noordhuis) #42064 PR-URL: #42254
Notable changes: * (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) nodejs#42093 * (SEMVER-MINOR) net: add new options to net.Socket and net.Server (Paolo Insogna) nodejs#41310 * (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) nodejs#35025 * doc: add release key for Bryan English (Bryan English) nodejs#42102 Dependency Updates: * deps: update nghttp2 to 1.47.0 (Yash Ladha) nodejs#42127 * deps: upgrade npm to 8.5.2 (npm team) nodejs#42122 New Collaborators: * doc: add JakobJingleheimer to collaborators list (Jacob Smith) nodejs#42185 * doc: move bnoordhuis back to collaborators (Ben Noordhuis) nodejs#42064 PR-URL: nodejs#42254
2022-03-09, Version 17.7.0 (Current), @BethGriggs prepared by @sxa
Notable Changes
2b354223d4
] - (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) #42093a2926c477a
] - (SEMVER-MINOR) net: add new options tonet.Socket
andnet.Server
(Paolo Insogna) #4131086248f1178
] - (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) #35025a4969d5c37
] - doc: add release key for Bryan English (Bryan English) #42102Dependency Updates
0b8efea182
] - deps: update nghttp2 to 1.47.0 (Yash Ladha) #42127ccacf99e5c
] - deps: upgrade npm to 8.5.2 (npm team) #42122New Collaborators
3df001fa93
] - doc: add JakobJingleheimer to collaborators list (Jacob Smith) #421850ce00ca5e1
] - doc: move bnoordhuis back to collaborators (Ben Noordhuis) #42064Commits
d05758f79f
] - buffer: improve blob read performance (Xuguang Mei) #421170bbb44741b
] - build: drop shortened URL from lint-commit-message (Richard Lau) #421684e9fac6539
] - build: fix usage of input in feature action (Michael Dawson) #42150853cbd99b8
] - build: increase max ops for stale feature action (Michael Dawson) #421303fc3f521d6
] - build: add corepack to the auto-updated dependencies (Maël Nison) #42090ec4c0de6d1
] - build: last test of the stale feature action (Michael Dawson) #4208503ebca86d9
] - build: update feature close action for testing (Michael Dawson) #42082c9ea6a9261
] - crypto: validatethis
value forwebcrypto.getRandomValues
(Antoine du Hamel) #417602b354223d4
] - (SEMVER-MINOR) crypto: add KeyObject.prototype.equals method (Filip Skokan) #42093288f627c46
] - crypto: clarifyrequire("crypto").getRandomValues
is Node.js specific (Antoine du Hamel) #417820b8efea182
] - deps: update nghttp2 to 1.47.0 (Yash Ladha) #42127ccacf99e5c
] - deps: upgrade npm to 8.5.2 (npm team) #421221359f60338
] - deps: V8: cherry-pick 77d515484864 (Lu Yahan) #42067769e2a486f
] - deps: V8: cherry-pick b66334313c8b (Lu Yahan) #42067fc7d429516
] - doc: update stale feature messages (Michael Dawson) #422176183749861
] - doc: remove erroneous comma in cluster explainer (Tobias Nießen) #42238555da9b658
] - doc: remove "considered" for clarity (Rich Trott) #4221805c3ff5e76
] - doc: clarify that some modules don't work when compiled without ssl (Antoine du Hamel) #42198a6c1abf7e1
] - doc: add note about nghttp2 hd pair size (Rafael Silva) #4217204d2c74c8a
] - doc: use parenthesis instead of em dash (Antoine du Hamel) #422026a74fa91bb
] - doc: add next-10 to strategic initiatives (Michael Dawson) #42167ee027391e7
] - doc: add missing single-quotes tohttp.OutgoingMessage
(Juan José Arboleda) #4216284859c4029
] - doc: fix typos (apeltop) #421463df001fa93
] - doc: add JakobJingleheimer to collaborators list (Jacob Smith) #42185ce86fc3006
] - doc: remove reference to obsolete security program (Rich Trott) #421445d010bcde2
] - doc: remove repeated a word (apeltop) #42138a32ec983c6
] - doc: make building with ninja more discoverable (Balakrishna Avulapati) #4184026fe61b6ad
] - doc: document change to IncomingMessage.headers enumerability (Arnold Zokas) #42095eb622a0761
] - doc: add meixg to triagers (Xuguang Mei) #42066bd04fc89da
] - doc: clarify persistent ref behavior (Michael Dawson) #420350ce00ca5e1
] - doc: move bnoordhuis back to collaborators (Ben Noordhuis) #420648b531dadb1
] - doc: clarify supported versus enabled TLS ciphers (Tobias Nießen) #420633789d668f7
] - doc: add missing api entries on performance (legendecas) #42018a4969d5c37
] - doc: add release key for Bryan English (Bryan English) #421028b94ea6e1c
] - doc,tools: improve navigability of API docs (Paolo Insogna) #414042e1231b831
] - errors: do not access .stack in debug (Benjamin Coe) #420968dd4878850
] - esm: fix base URL for network imports (Bradley Farias) #421312bc136d3cb
] - esm: fix relative imports for https (Bradley Farias) #42119576c1aea8e
] - fs: adjust defaultlength
forfs.readSync
and fsPromises/read
(Livia Medeiros) #42128041373696f
] - http: add default argument for Agent.prototype.getName (小菜) #419061de80872e8
] - http2: add edge case to GOAWAY request (Rafael Silva) #421909bc7a954fd
] - http2: close stream and session on frameError (Rafael Silva) #42147384872fdbd
] - lib: clean after the cancel algorithm throw error (Chen Gang) #41366f7ea75fd0a
] - lib: add legacy built-in functions to primordials (Antoine du Hamel) #420497f1c83e674
] - loader: fix esm resolve for symlink file (Xuguang Mei) #421975b23e67ad5
] - meta: update AUTHORS (Node.js GitHub Bot) #42227cad7dde9af
] - meta: update AUTHORS (Node.js GitHub Bot) #421427ed2c19cbb
] - meta: correct link to feature request document (Simen Bekkhus) #42092e0448da9a9
] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42068e3347dbaa8
] - meta: remove collaborator (Rich Trott) #4207396510b3411
] - module: prefer async/await in https imports (Benjamin Gruenbaum) #41950a2926c477a
] - (SEMVER-MINOR) net: add new options tonet.Socket
andnet.Server
(Paolo Insogna) #41310f107f8bf40
] - node-api: fix typo innode_api.cc
(Austin Kelleher) #42110c72c3f4bb1
] - perf_hooks: do not return all entries with getEntriesBy[Name|Type] (Xuguang Mei) #421047c49785348
] - process: fix named report export (madflow) #41861d6b1a4a235
] - repl: remove preview when press escape (meixg) #4205398b1be0ec2
] - src: return proper URLs from node_api_get_module_file_name (Anna Henningsen) #417580abc20b6cf
] - src: skip revoke_data_object if uuid is not found (Xuguang Mei) #42212ce409279d8
] - src: remove dead code in AddFingerprintDigest (Tobias Nießen) #421454c9f2b5d83
] - src: combine GetCurveASN1Name and GetCurveNistName (Tobias Nießen) #42118f0558d88fb
] - src: simplify TLSWrap::SetSession (Tobias Nießen) #4208797f5ceda84
] - src: prefer bool over int in crypto_common (Tobias Nießen) #42097382ffdade0
] - src: simplify arg type of AddFingerprintDigest (Tobias Nießen) #4210107de4ed641
] - src: do not ignore return value of BIO_reset (Tobias Nießen) #421033366618ce2
] - src: simplify GetExponentString (Tobias Nießen) #4212186248f1178
] - (SEMVER-MINOR) src: allow preventing InitializeInspector in env (Shelley Vohr) #3502506e5c0ee39
] - stream: use .chunk when calling adapters's writev (Xuguang Mei) #4216153338fe65c
] - stream: allow returning null from pipeline tail (Robert Nagy) #420788431fb90dc
] - stream: port more test262 tests (Benjamin Gruenbaum) #419740be3c61ae9
] - test: cover 32-bit sizes in generatePrime (Tobias Nießen) #42207ceb47d13ff
] - test: fix test-process-env-tz.js by using RegExp (Khaidi Chu) #42113f21fbeec2e
] - test: update V8 trace events test expectations (Nikolaos Papaspyrou) #42120d0f68a398e
] - test: deflake test-common-expect-warning (Luigi Pinca) #42046482b2205b2
] - test: validateEventEmitterAsyncResource
methods throw on invalid this (Yoshiki Kurihara) #4204199301469ed
] - test: increase Fibonacci argument to 40 (Rich Trott) #42055c01134ed27
] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #4222641b6d9e95a
] - tools: update lint-md rollup dependencies (Node.js GitHub Bot) #4214128f636422e
] - tools: update eslint to 8.10.0 (Node.js GitHub Bot) #421439aeda47d9c
] - url: fix url.parse() for @hostname (Rich Trott) #42136ecb5980e2f
] - url, src: modify onespecial_back_slash
(Khaidi Chu) #42112