Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: backport 200315c from V8 upstream (v4.x) #4128

Closed
wants to merge 132 commits into from
Closed

deps: backport 200315c from V8 upstream (v4.x) #4128

wants to merge 132 commits into from

Conversation

vkurchatkin
Copy link
Contributor

Original commit message:

Make AstRawString deduplication encoding-agnostic.

R=[email protected]
BUG=v8:4450
LOG=N

Review URL: https://codereview.chromium.org/1411103006

Cr-Commit-Position: refs/heads/master@{#31624}

cc @nodejs/v8 @nodejs/lts

othiym23 and others added 30 commits November 14, 2015 16:49
@othiym23 @jasnell
deps: upgrade npm to 2.14.9
44d4a02 
Dependency upgrades.

PR-URL: nodejs#3686
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@thefourtheye
test: enhance fs-watch-recursive test
75b4613 
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: nodejs#2599
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@zyxar
build: fix configuring with prebuilt libraries
aef3d54 
Fix configure_library() to produce correct LDFLAGS when configuring with
prebuilt 3rd-party libraries (libuv, openssl, etc) using `pkg-config' or
`--shared-{LIBRARY}-includes=xxx --shared-{LIBRARY}-libpath=xxx'.

PR-URL: nodejs#3135
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
docs: fs - change links to buffer encoding to Buffer class anchor
5689630 
PR-URL: nodejs#2796
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis
doc: stdout/stderr can block when directed to file
38a5ae1 
Update the documentation for `process.stdout` and `process.stdout` to
clarify that writes can block when stdio is redirected to a file.  In
all other cases, it's non-blocking.

PR-URL: nodejs#3170
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@a0viedo
doc: add method links in events.markdown
22bfe22 
Added referenced method links.

PR-URL: nodejs#3187
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@hemanth
repl: To exit, press ^C again or type .exit.
bf48969 
When the user hits `^C` in the REPL show more info about `.exit`.

The idea was to give more info to the user when they hit ^C.
Current version just displays `(^C again to quit)` and most
of the users are not aware of the `.exit` command that would
Exit the repl.

PR-URL: nodejs#3368
Reviewed-By: James M Snell <[email protected]>
doc: add caveats of algs and key size in crypto
4a94c0a 
Add description of user responsibility in the choice of cypto
algorithms and its key length. Some of recommendations for the safer
use are also described.

PR-URL: nodejs#3479
Reviewed-By: James M Snell <[email protected]>
@silverwind
src: Revert "nix stdin _readableState.reading"
550c606 
This reverts 8cee8f5 which was causing stdin to behave strangely on
Windows 8 and 10. The suspected explanation for the issue is that there
might be a race condition occuring when stdin._readableState.reading is
set indirectly through `push('')`.

PR-URL: nodejs#3490
Fixes: nodejs#2996
Fixes: nodejs#2504
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@sitegui
doc: add note about timeout delay > TIMEOUT_MAX
d02365b 
When setTimeout() and setInterval() are called with `delay` greater than
TIMEOUT_MAX (2147483647), the supplied value is ignored and 1 is used
instead. Add a note about this in the timers docs.

PR-URL: nodejs#3512
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@birnam
doc:fix function param order in assert doc
dfc2707 
PR-URL: nodejs#3533
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
zlib: pass kind to recursive calls to flush
d1cedbd 
Bug spotted by @bnoordhuis while doing code review on nodejs#3534

Refs: nodejs#3534 (comment)
PR-URL: nodejs#3534
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@CraigCav
zlib: only apply drain listener if given callback
1543c78 
When stream.flush() is called without a callback, an empty listener is
being added. Since flush may be called multiple times to push SSE's
down to the client, multiple noop listeners are being added. This in
turn causes the memory leak detected message.

PR-URL: nodejs#3534
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
test: add test-zlib-flush-drain
84f8eb7 
This test assures that if flush is called while the zlib object needs
to be drained that it will defer the callback until after the drain.

PR-URL: nodejs#3534
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@baslr
doc: added what buf.copy returns
98762d2 
as of https://github.com/nodejs/node/blob/v5.x/src/node_buffer.cc#L555

buf.copy returns the number of bytes copied.

PR-URL: nodejs#3555
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@usta
Add missing va_end before return
935b8be 
PR-URL: nodejs#3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@phillipj
doc: made code spans more visible in the API docs
08ab9f3 
This makes the code spans in the API docs more visible and
therefore readable by adding some background color.

PR-URL: nodejs#3573
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@zertosh
module: remove unnecessary JSON.stringify
948af71 
`debuglog` uses `%j` as a placeholder for replacement with
`JSON.stringify`. So that `JSON.stringify` is only called when the
appropriate debug flag is on. The other `%s` changes are for style
consistency.

PR-URL: nodejs#3578
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@tomgco
doc: Updated streams simplified constructor API
bb20abb 
The examples for implementing the simplified constructor API
was missing some details on its correct usages.

PR-URL: nodejs#3602
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
@mcornac
test: fix path to module for repl test on Windows
c10f17f 
Use path join to construct the path instead of concatenating strings.
Replace backslash with double backslash so that they are escaped
correctly in the string passed to REPL.

PR-URL: nodejs#3608
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jas-
doc: fix crypto spkac function descriptions
b3b55a5 
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: nodejs#3614
Reviewed-By: Ben Noordhuis <[email protected]>
@evanlucas
repl: don't crash if cannot open history file
486d287 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: nodejs#3610
PR-URL: nodejs#3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@srl295
doc: rename iojs-* groups to nodejs-*
5a23bb5 
As per nodejs#2525 a bunch of WGs are renamed from iojs-* to nodejs-*.
Update the WORKING_GROUPS.md to match.

Note specifically iojs-cn and iojs-tw were renamed to nodejs-zh-CN and
nodejs-zh-TW respectively.

Fixes: nodejs#3247
PR-URL: nodejs#3634
Reviewed-By: James M Snell <[email protected]>
@jasnell
doc: fix wrong date and known issue in changelog.md
d410d58 
* A known issue was resolved but not removed from the list
* The wrong date was documented in the changelog for v4.2.2

PR-URL: nodejs#3650
Reviewed-By: Michaël Zasso <[email protected]>
test: fix test-net-persistent-keepalive for AIX
7009e01 
Fixed an intermittent issue on AIX where the 600ms timeout was reached
before the 'connection' event was fired. This resulted in a failure as
serverConnection would be undefined and the assert.equal would throw an
error. Changed the flow of the test so that the timeout is only set
after a connection has been made.

PR-URL: nodejs#3646
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@SPGB
doc: typo fix in readme.md
d7b4f75 
Minor typo fix in the list of keys

Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#3649
@hmalphettes
test: fix test-module-loading-error for musl
2570cb7 
When a compiled library file does not have the proper format,
musl returns the error message ENOEXEC as 'Exec format error' but
glibc returns 'file too short' if the file is under a certain size.

Reference:
http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46

This patch consists of tolerating musl's error.

PR-URL: nodejs#3657
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
doc: add LTS info to COLLABORATOR_GUIDE.md
9ce1f75 
There is currently no information in the Collaborators guide regarding
LTS. This commit adds some basic copy explaining what LTS is, what is
considered for LTS, and a simple way collaborators can help.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R. Loomis <[email protected]>
PR-URL: nodejs#3442
@jasnell
doc: update lts description in the collaborator guide
9970b76 
PR-URL: nodejs#3668
Reviewed-By: Julien Gilli <[email protected]>
test: Fix test-cluster-worker-exit.js for AIX
0fb40b4 
test fails intermittently due to the assertion that the 'disconnect'
event should come before the 'exit' event. This is caused be the
non-deteministic behaviour of pollset_poll[1] on AIX
(see deps/uv/src/unix/aix.c). This API makes no garauntee for the order
in which file descriptors are returned. On linux epoll_wait[2] is used,
which also does not make a garauntee on order of file descriptors
returned. In the failing case we recieve our file descriptor with a
callback of uv__signal_event (which causes JavaScript to receive the
exit event) before our file descriptor with uv__stream_io as its
callback (which in turn causes JavaScript receive the disconnect event).
This change simply removes the assertion that the disconnect event
happens before exit event and processes the test regardless of which
event comes first.

[1] https://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.ai
x.basetrf1/pollset.htm
[2] http://linux.die.net/man/2/epoll_pwait

PR-URL: nodejs#3666
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ofrobots added a commit to ofrobots/node that referenced this pull request Dec 4, 2015
@ofrobots
deps: upgrade to V8 4.7.80.25
c80a491 
Pick up the latest patch-level from V8 stable. This includes the following fix:

* v8/v8@c408ea7
  Make AstRawString deduplication encoding-agnostic.

  BUG=v8:4450
  LOG=N
  [email protected]
  [email protected]

  Review URL: https://codereview.chromium.org/1494293003

See also: nodejs#4128
@ofrobots ofrobots mentioned this pull request Dec 4, 2015
Closed
ofrobots added a commit that referenced this pull request Dec 5, 2015
@ofrobots
deps: upgrade to V8 4.7.80.25
e2dec98 
Pick up the latest patch-level from V8 stable. This includes the following fix:

* v8/v8@c408ea7
  Make AstRawString deduplication encoding-agnostic.

  BUG=v8:4450
  LOG=N
  [email protected]
  [email protected]

  Review URL: https://codereview.chromium.org/1494293003

See also: #4128

PR-URL: #4160
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
@ofrobots
Copy link
Contributor

@vkurchatkin Can you rebase this? This is already in master, but it still need to land in v5.x and v4.x.

@ofrobots
Copy link
Contributor

CI of the fix cherry-picked to v5.x: https://ci.nodejs.org/job/node-test-commit/1501/

vkurchatkin added a commit that referenced this pull request Dec 23, 2015
@vkurchatkin @ofrobots
deps: backport 200315c from V8 upstream
b4c51c5 
Original commit message:

  Make AstRawString deduplication encoding-agnostic.

  [email protected]
  BUG=v8:4450
  LOG=N

  Review URL: https://codereview.chromium.org/1411103006

  Cr-Commit-Position: refs/heads/master@{#31624}

Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: indutny - Fedor Indutny <[email protected]>
@ofrobots
Copy link
Contributor

Landed in v5.x as b4c51c5. I will let @nodejs/lts cherry-pick this for v4.x.

Note that this fix is also needed for https://bugs.chromium.org/p/v8/issues/detail?id=4635.

vkurchatkin added a commit that referenced this pull request Jan 7, 2016
@vkurchatkin
deps: backport 200315c from V8 upstream
126e054 
Original commit message:

  Make AstRawString deduplication encoding-agnostic.

  [email protected]
  BUG=v8:4450
  LOG=N

  Review URL: https://codereview.chromium.org/1411103006

  Cr-Commit-Position: refs/heads/master@{#31624}

Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: indutny - Fedor Indutny <[email protected]>
@MylesBorins
Copy link
Contributor

I've landed this commit into v4.x-staging and have run a CI job against it

https://ci.nodejs.org/job/node-test-commit/1638/

For comparison this CI job was run on HEAD just before adding this commit

https://ci.nodejs.org/job/node-test-commit/1637/

@MylesBorins MylesBorins closed this Jan 7, 2016
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@vkurchatkin
deps: backport 200315c from V8 upstream
c3a9d8a 
Original commit message:

  Make AstRawString deduplication encoding-agnostic.

  [email protected]
  BUG=v8:4450
  LOG=N

  Review URL: https://codereview.chromium.org/1411103006

  Cr-Commit-Position: refs/heads/master@{#31624}

Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: indutny - Fedor Indutny <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
2016-01-19, Version 4.2.5 "Argon" (LTS) Release
2b6386a 
Notable changes:

* assert
  -  accommodate ES6 classes that extend Error (Rich Trott) #4166
* build
  - add "--partly-static" build options (Super Zheng) #4152
* deps
  - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655
  - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128
  - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé)
* docs
  - various updates landed in 70 different commits!
* repl
  - attach location info to syntax errors (cjihrig) #4013
  - display error message when loading directory (Prince J Wesley) #4170
* tests
  - various updates landed in over 50 commits
* util
  - allow lookup of hidden values (cjihrig) #3988
MylesBorins pushed a commit that referenced this pull request Jan 20, 2016
2016-01-20, Version 4.2.5 "Argon" (LTS) Release
e6ca04c 
Notable changes:

* assert
  -  accommodate ES6 classes that extend Error (Rich Trott) #4166
* build
  - add "--partly-static" build options (Super Zheng) #4152
* deps
  - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655
  - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128
  - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé)
* docs
  - various updates landed in 70 different commits!
* repl
  - attach location info to syntax errors (cjihrig) #4013
  - display error message when loading directory (Prince J Wesley) #4170
* tests
  - various updates landed in over 50 commits
* util
  - allow lookup of hidden values (cjihrig) #3988

PR-URL: #4768
MylesBorins pushed a commit that referenced this pull request Jan 20, 2016
2016-01-20, Version 4.2.5 "Argon" (LTS) Release
d50a8a9 
Notable changes:

* assert
  -  accommodate ES6 classes that extend Error (Rich Trott) #4166
* build
  - add "--partly-static" build options (Super Zheng) #4152
* deps
  - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655
  - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128
  - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé)
* docs
  - various updates landed in 70 different commits!
* repl
  - attach location info to syntax errors (cjihrig) #4013
  - display error message when loading directory (Prince J Wesley) #4170
* tests
  - various updates landed in over 50 commits
* util
  - allow lookup of hidden values (cjihrig) #3988

PR-URL: #4768
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@ofrobots
deps: upgrade to V8 4.7.80.25
cfd9133 
Pick up the latest patch-level from V8 stable. This includes the following fix:

* v8/v8@c408ea7
  Make AstRawString deduplication encoding-agnostic.

  BUG=v8:4450
  LOG=N
  [email protected]
  [email protected]

  Review URL: https://codereview.chromium.org/1494293003

See also: nodejs#4128

PR-URL: nodejs#4160
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
2016-01-20, Version 4.2.5 "Argon" (LTS) Release
028e811 
Notable changes:

* assert
  -  accommodate ES6 classes that extend Error (Rich Trott) nodejs#4166
* build
  - add "--partly-static" build options (Super Zheng) nodejs#4152
* deps
  - backport 066747e from upstream V8 (Ali Ijaz Sheikh) nodejs#4655
  - backport 200315c from V8 upstream (Vladimir Kurchatkin) nodejs#4128
  - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé)
* docs
  - various updates landed in 70 different commits!
* repl
  - attach location info to syntax errors (cjihrig) nodejs#4013
  - display error message when loading directory (Prince J Wesley) nodejs#4170
* tests
  - various updates landed in over 50 commits
* util
  - allow lookup of hidden values (cjihrig) nodejs#3988

PR-URL: nodejs#4768
This was referenced Jul 13, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.