Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing va_end before return #3565

Closed
wants to merge 1 commit into from
Closed

Add missing va_end before return #3565

wants to merge 1 commit into from

Conversation

usta
Copy link
Contributor

@usta usta commented Oct 28, 2015

No description provided.

@evanlucas
Copy link
Contributor

/cc @mscdex

@mscdex
Copy link
Contributor

mscdex commented Oct 28, 2015

LGTM

@Fishrock123 Fishrock123 added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 28, 2015
@evanlucas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/673/

@jasnell
Copy link
Member

jasnell commented Nov 5, 2015

LGTM

jasnell pushed a commit that referenced this pull request Nov 5, 2015
@usta @jasnell
Add missing va_end before return
44a298b 
PR-URL: #3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 5, 2015

Landed in 44a298b

@jasnell jasnell closed this Nov 5, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 6, 2015
Closed
rvagg pushed a commit that referenced this pull request Nov 7, 2015
@usta @rvagg
Add missing va_end before return
59cd281 
PR-URL: #3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2015
@usta
Add missing va_end before return
935b8be 
PR-URL: #3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

landed in lts-v4.x-staging as 935b8be

@rvagg rvagg mentioned this pull request Nov 17, 2015
Closed
rvagg pushed a commit that referenced this pull request Dec 4, 2015
@usta @rvagg
Add missing va_end before return
815b395 
PR-URL: #3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
@usta @jasnell
Add missing va_end before return
907a13a 
PR-URL: #3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
@usta @jasnell
Add missing va_end before return
29e043c 
PR-URL: #3565
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@usta usta deleted the MisingClose branch February 12, 2016 22:27
@usta usta restored the MisingClose branch February 12, 2016 22:28
This was referenced Dec 7, 2023
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@usta @evanlucas @mscdex @jasnell @MylesBorins @Fishrock123