Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If NODE_REPL_HISTORY file cannot be opened, Node crashes #3610

Closed
bminer opened this issue Oct 30, 2015 · 2 comments
Closed

If NODE_REPL_HISTORY file cannot be opened, Node crashes #3610

bminer opened this issue Oct 30, 2015 · 2 comments
Labels
repl Issues and PRs related to the REPL subsystem.

Comments

@bminer
Copy link
Contributor

bminer commented Oct 30, 2015

If the NODE_REPL_HISTORY file cannot be opened (i.e. read-only file system, permission issue, etc.), Node simply crashes. This is probably an uncaught "error" event.

This behavior seems silly to me. The NODE_REPL_HISTORY file is a convenience, not a requirement. Even though it can be disabled by an environment flag, if it cannot be opened, it should silently fail. Or, perhaps, NODE_REPL_HISTORY should be disabled by default?

Thoughts?
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Oct 30, 2015
@Fishrock123
Copy link
Contributor

I guess it can just log you an error. I think this was brought up before?

@evanlucas evanlucas mentioned this issue Nov 2, 2015
Merged
@bminer
Copy link
Contributor Author

bminer commented Nov 2, 2015

@evanlucas - Thanks for the PR. Looks good to me!

evanlucas added a commit to evanlucas/node that referenced this issue Nov 3, 2015
@evanlucas
repl: don't crash if cannot open history file
a4a0efc 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: nodejs#3610
PR-URL: nodejs#3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas added a commit that referenced this issue Nov 7, 2015
@evanlucas @rvagg
repl: don't crash if cannot open history file
5073da0 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: #3610
PR-URL: #3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas added a commit that referenced this issue Nov 16, 2015
@evanlucas
repl: don't crash if cannot open history file
486d287 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: #3610
PR-URL: #3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas added a commit that referenced this issue Dec 4, 2015
@evanlucas @rvagg
repl: don't crash if cannot open history file
f5a1ab7 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: #3610
PR-URL: #3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas added a commit that referenced this issue Dec 17, 2015
@evanlucas @jasnell
repl: don't crash if cannot open history file
ff02b29 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: #3610
PR-URL: #3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
evanlucas added a commit that referenced this issue Dec 23, 2015
@evanlucas @jasnell
repl: don't crash if cannot open history file
b9b2f1a 
Previously, if we are unable to open the history file, an error would
be thrown. Now, print an error message that we could not open
the history file, but don't fail.

Fixes: #3610
PR-URL: #3630
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @bminer @Fishrock123