-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v15.13.0 proposal #37977
Merged
Merged
v15.13.0 proposal #37977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ESLint to 7.22.0 PR-URL: #37734 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This indicates to GNU binutils that it can unset the executable stack flag on the binary that it is building. PR-URL: #37688 Refs: #17933 Reviewed-By: Daniel Bevenius <[email protected]>
Move Y2K38-specific parts of test-fs-utimes to test-fs-utimes-y2K38.js. On non-Windows, check for Y2K38 support and skip if it is unsupported. Fixes: #36591 PR-URL: #37707 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Add a known_issues test for a known Windows issue. Refs: #13683 PR-URL: #37744 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #37765 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Signed-off-by: James M Snell <[email protected]> PR-URL: #37529 Fixes: #3462 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Signed-off-by: James M Snell <[email protected]> PR-URL: #37529 Fixes: #3462 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
fixes #37794 PR-URL: #37795 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
A gc may happen during environment teardown. Thus, during finalization initiated by environment teardown we must remove the V8 finalizer before calling the Node-API finalizer. Fixes: #37236 PR-URL: #37616 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Add support for timeout to spawn and fork. Fixes: #27639 PR-URL: #37256 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Instead of writing each Math function and keeping track, loop over Math functions and test each one of them. PR-URL: #37670 Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #37716 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
PR-URL: #37738 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Pooja D P <[email protected]>
'referred' was spelled as 'refered' PR-URL: #37741 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pooja D P <[email protected]>
PR-URL: #37773 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
If the shared openssl does not have the `OPENSSL_INFO_QUIC` define, then it definitely does not have the QUIC apis. This is only a partially accurate check because it does not detect if the shared openssl was actually *built* without the OPENSSL_NO_QUIC define set. Signed-off-by: James M Snell <[email protected]> PR-URL: #37682 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Reintroduces the ngtcp2 and nghttp3 dependencies, building those by default if the vendored-in openssl (with QUIC support) is used or the shared openssl defines `OPENSSL_INFO_QUIC`. Upates the version metadata to reflect whether ngtcp2 and nghttp3 are present. ngtcp2 as of ngtcp2/ngtcp2@2381f7f nghttp3 as of ngtcp2/nghttp3@66ad30f Signed-off-by: James M Snell <[email protected]> PR-URL: #37682 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
fixes: #37619 PR-URL: #37817 Fixes: #37619 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #37758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Signed-off-by: James M Snell <[email protected]> PR-URL: #37784 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Signed-off-by: James M Snell <[email protected]> Fixes: #25099 PR-URL: #37784 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Signed-off-by: James M Snell <[email protected]> PR-URL: #37784 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Conclude winter break and resume collaboratorship at start of spring. Refs: #36514 PR-URL: #37726 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #37793 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #37791 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #37798 Refs: whatwg/dom#960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Fixes: #37641 PR-URL: #37660 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #37761 Fixes: #36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fix an issue where AbortSignals are registered twice PR-URL: #37730 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot
added
tools
Issues and PRs related to the tools directory.
v15.x
labels
Mar 30, 2021
This comment has been minimized.
This comment has been minimized.
ruyadorno
added a commit
that referenced
this pull request
Mar 30, 2021
PR-URL: #37977 Notable changes: * buffer: * implement btoa and atob (James M Snell) #37529 * deps: * upgrade npm to 7.7.6 (Ruy Adorno) #37968 * doc: * add legacy status to stability index (James M Snell) #37784 * add @Linkgoron to collaborators (Nitzan Uziely) #37817 * http: * add http.ClientRequest.getRawHeaderNames() (simov) #37660
ruyadorno
force-pushed
the
v15.13.0-proposal
branch
from
March 30, 2021 03:17
2a38168
to
045dc91
Compare
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: #37865 Backport-PR-URL: #37985 Reviewed-By: Michaël Zasso <[email protected]>
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: #37864 Backport-PR-URL: #37985 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #37977 Notable changes: * buffer: * implement btoa and atob (James M Snell) #37529 * deps: * upgrade npm to 7.7.6 (Ruy Adorno) #37968 * doc: * add legacy status to stability index (James M Snell) #37784 * add @Linkgoron to collaborators (Nitzan Uziely) #37817 * http: * add http.ClientRequest.getRawHeaderNames() (simov) #37660
ruyadorno
force-pushed
the
v15.13.0-proposal
branch
from
March 31, 2021 02:21
045dc91
to
71a7722
Compare
targos
approved these changes
Mar 31, 2021
Sorry @bricss it is too late unfortunately 😞 |
richardlau
approved these changes
Mar 31, 2021
ruyadorno
added a commit
that referenced
this pull request
Mar 31, 2021
PR-URL: #37977 Notable changes: * buffer: * implement btoa and atob (James M Snell) #37529 * deps: * upgrade npm to 7.7.6 (Ruy Adorno) #37968 * doc: * add legacy status to stability index (James M Snell) #37784 * add @Linkgoron to collaborators (Nitzan Uziely) #37817 * http: * add http.ClientRequest.getRawHeaderNames() (simov) #37660
ruyadorno
added a commit
to ruyadorno/nodejs.org
that referenced
this pull request
Mar 31, 2021
ruyadorno
added a commit
to ruyadorno/nodejs.org
that referenced
this pull request
Mar 31, 2021
ruyadorno
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 31, 2021
targos
removed
build
Issues and PRs related to build files or the CI.
doc
Issues and PRs related to the documentations.
needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
tools
Issues and PRs related to the tools directory.
meta
Issues and PRs related to the general management of the project.
labels
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-03-31, Version 15.13.0 (Current), @ruyadorno
Notable Changes
npm run
andnpm exec
Commits
dc9cd43d8f
] - (SEMVER-MINOR) buffer: implement btoa and atob (James M Snell) #37529377830fd28
] - child_process: remove unused argument (Rich Trott) #37923cdfc1c8692
] - child_process: cleanup AbortSignal duplication (Nitzan Uziely) #3782395aa032413
] - (SEMVER-MINOR) child_process: add timeout to spawn and fork (Nitzan Uziely) #3725650fc6b9df0
] - crypto: clear errors in SignTraits::DeriveBits (Filip Skokan) #3782079259389a1
] - crypto: fix DiffieHellman argument validation (Antoine du Hamel) #3781011d45855cd
] - crypto: fix header name (Jiawen Geng) #37792c37806d0ba
] - crypto: use macro map for NodeCryptoError (Darshan Sen) #37758bfe3f21ee0
] - crypto: fix crypto.verify callback invocation with a private keyobject (Filip Skokan) #37795f2cef54b6f
] - deps: upgrade npm to 7.7.6 (Ruy Adorno) #37968ec82feb728
] - deps: upgrade npm to 7.7.5 (Ruy Adorno) #37919649e04c4a5
] - deps: upgrade npm to 7.7.4 (Ruy Adorno) #37897d5b472b70d
] - deps: upgrade npm to 7.7.0 (Ruy Adorno) #378799e6aa190e3
] - deps: add ngtcp2 and nghttp3 (James M Snell) #37682659fc5d684
] - doc: fix typos in lib/internal/bootstrap/pre_execution.js (marsonya) #37658ac60d018e2
] - doc: add more commands for cherry-picking and changelog to release docs (Danielle Adams) #377850fe3c7edd3
] - doc: spell out ICU acronym on first occurrence (Rich Trott) #37942364c8ac40d
] - doc: update GOVERNANCE.md for TSC Charter changes (Rich Trott) #37888e84252b35d
] - doc: reduce header nesting in async_hooks.md (Rich Trott) #37839a6f21e2cfc
] - doc: fix wording in outgoingMessage.write (Tobias Nießen) #3789430bc2e43e4
] - doc: add examples for WHATWG URL objects (James M Snell) #37822c0a424f3e9
] - doc: clarify when child process 'spawn' event is *not* emitted (Matthew Francis Brunetti) #378339defe10371
] - doc: fix legacy stability indicator display (Rich Trott) #37838f97a5dd22f
] - doc: use sentence-style capitlaztion in template header (Rich Trott) #3783771fde07274
] - doc: add Ayase-252 to triagers (Qingyu Deng) #377818f18133de0
] - doc: use sentence case in issues.md headers (marsonya) #375373376051a0e
] - doc: fix JS flavor selection (Antoine du Hamel) #37791b09d032683
] - doc: move Derek Lewis back to collaborators (Derek Lewis) #377266da0a0e85a
] - doc: apply style for legacy status (James M Snell) #37784185d4cd4aa
] - doc: revoke deprecation of legacy url, change status to legacy (James M Snell) #377849d160daa89
] - doc: add legacy status to stability index (James M Snell) #377844700042a9b
] - doc: add @Linkgoron to collaborators (Nitzan Uziely) #37817c4183bbea4
] - doc: fix AbortError example for timers (dbachko) #3773850f3ad1946
] - doc: fix typo in stream docs (Ian Kerins) #377162e82a97520
] - doc: add gyp maintain info (Jiawen Geng) #377653925458df7
] - doc,tools: use only one level 1 header per page (Rich Trott) #37839e9c161ce12
] - http: fix double AbortSignal registration (Nitzan Uziely) #37730a5205819d8
] - (SEMVER-MINOR) http: add http.ClientRequest.getRawHeaderNames() (simov) #376601c043272ea
] - http2: treat non-EOF empty frames like other invalid frames (Anna Henningsen) #37875a5bf7de6eb
] - http2: fix setting options before handle exists (Anna Henningsen) #37875af7489cb6c
] - lib: add brand checks to AbortController and AbortSignal (Mattias Buelens) #377206e2b60931c
] - lib: fix typo in internal/modules/esm/module_job.js (marsonya) #377733a440ecdf8
] - lib: fix typo in lib/internal/crypto/certificate.js (marsonya) #377413ab223dd32
] - node-api: fix crash in finalization (Michael Dawson) #37876d1a3e0efb6
] - node-api: stop ref gc during environment teardown (Gabriel Schulhof) #37616e60bd1a7dc
] - (SEMVER-MINOR) perf_hooks: make Performance extend EventTarget (Michaël Zasso) #37621b6ad8e4cc1
] - src: indent long help text properly (David Glasser) #3791113ecff63d6
] - src: document newer values for --unhandled-rejections flag (David Glasser) #37899bd87e195ed
] - src: fix typo in src code guide (Tobias Nießen) #379562da532cef8
] - src: report idle time correctly (Stephen Belanger) #37868836cb67945
] - src: add .note.GNU-stack section (James Addison) #376889557dda2eb
] - (SEMVER-MINOR) stream: pipeline accept Buffer as a valid first argument (Nitzan Uziely) #3773943c3b43ea3
] - stream: make Readable.from performance better (wwwzbwcom) #37609b0226b39f2
] - test: split promisified timers test for coverage purposes (Rich Trott) #37943e256c4d11d
] - test: fix typeof comparison (Rich Trott) #3792476ebc4bbd9
] - test: increase wiggle room for memory in test-worker-resource-limits (Rich Trott) #379015cdeb76708
] - test: add OpenSSL 3.0 checks to tls-passphrase (Daniel Bevenius) #3786033c35a38dc
] - test: add OpenSSL 3.0 checks to test-crypto-keygen (Daniel Bevenius) #3786086bf341a35
] - test: fix deprecation warning in test-doctool-html (Antoine du Hamel) #37858aa529b73b7
] - test: fix ibmi skip message (Tobias Nießen) #37821d9ab1d56ce
] - test: fix flaky test-vm-timeout-escape-promise-module-2 (Rich Trott) #378425d4c610727
] - test: remove duplicated test for eventtarget (himself65) #3785344490af948
] - test: relax Y2K38 check in test-fs-utimes-y2K38 (Richard Lau) #378259bc6fe7eb3
] - test: remove references to unsupported AIX versions (Richard Lau) #37826f07428ae51
] - test: remove skip for fixed test-benchmark-fs (Rich Trott) #378039f61cbd1fd
] - test: account for OOM risks in heapsnapshot-near-heap-limit tests (Joyee Cheung) #37761e85f311cf2
] - test: refactor code to use AbortSignal.abort() (Wassim Chegham) #377986ed9e0bd81
] - test: improve test-arm-math-illegal-instruction (marsonya) #37670505f9c95d1
] - (SEMVER-MINOR) test: app atob web platform tests (James M Snell) #37529a8edf1aafe
] - test: add known_issues test for path.posix.relative returns different results for *nix and Windows versions of node #13683 (Rich Trott) #377444487483d9d
] - test: fix test-fs-utimes on non-Y2K38 file systems (Rich Trott) #37707d44b268910
] - timers: fix arbitrary object clearImmediate errors (Nitzan Uziely) #37824b7e7384109
] - tools: improve valid-typeof lint rule (Rich Trott) #37924ca93e52783
] - tools: simplify eslint comma-dangle configuration (tools) (Rich Trott) #37883b5879efef1
] - tools: improve macos-firewall.sh output (Rich Trott) #37846dbc4804468
] - tools: simplify eslint comma-dangle configuration (Rich Trott) #378500f2e142946
] - tools: make genv8constants.py Python3-compatible (Michaël Zasso) #37835b6be472456
] - tools: update gitignore for CMake (Jiawen Geng) #377932227aa61ea
] - tools: partially detect quic support in shared_openssl (James M Snell) #3768201dcf4d1d8
] - tools: update ESLint to 7.22.0 (Colin Ihrig) #377343452618905
] - tty: validate file descriptor to avoid int32 overflow (Antoine du Hamel) #37809d33f446abd
] - util: remove unreachable inspect code (Rich Trott) #37941