Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: clear errors in SignTraits::DeriveBits #37820

Closed
wants to merge 1 commit into from
Closed

crypto: clear errors in SignTraits::DeriveBits #37820

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Mar 19, 2021

No description provided.

@panva panva requested a review from jasnell March 19, 2021 20:27
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 19, 2021
@panva
Copy link
Member Author

panva commented Mar 19, 2021 •
edited
Loading

Since I was not able to recreate the race condition that leads to the issue this fixes with the existing code, here's a failing CI run where another future change proposal is in effect. Here's the same but with this change in place.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 19, 2021
@panva
Copy link
Member Author

panva commented Mar 19, 2021

cc @nodejs/crypto

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36851/

@panva
Copy link
Member Author

panva commented Mar 20, 2021

CI 💚

@panva
Copy link
Member Author

panva commented Mar 25, 2021

Landed in 0ee2cea

@panva panva closed this Mar 25, 2021
panva added a commit that referenced this pull request Mar 25, 2021
@panva
crypto: clear errors in SignTraits::DeriveBits
0ee2cea 
PR-URL: #37820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
@panva @ruyadorno
crypto: clear errors in SignTraits::DeriveBits
5c0f24c 
PR-URL: #37820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
@panva @ruyadorno
crypto: clear errors in SignTraits::DeriveBits
50fc6b9 
PR-URL: #37820
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
@panva panva deleted the crypto-sig-derive-bits-stack branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @jasnell @tniessen @targos