deps: reintroduce ngtcp2 and nghttp3

[jasnell]

This builds on #37601. The first four commits are from that PR and will be dropped once that lands.

Reintroduce the ngtcp2 and nghttp3 dependencies, building those by default if the vendored-in openssl is used (with the QUIC apis) or the shared-openssl defines OPENSSL_INFO_QUIC (signaling QUIC support).

The Node.js version metadata is updated to reflect whether ngtcp2 and nghttp3 are present.

This does not include the rest of the QUIC implementation yet. This is just adding back the dependencies.

[jasnell]

@danbev @addaleax @mhdawson @mcollina @nodejs/quic ... please take a look

[targos]

Could you add documentation on how to update these dependencies?

[jasnell]

@targos .. it's already there. Take a look at the deps/ngtcp2/README.md

[targos]

@jasnell oh sorry, I assumed it would be located in doc/guides like for other dependencies.

[jasnell]

I was considering that but I'd really like to start keeping the documentation for that with the dependencies themselves. I can move it in to doc/guides if necessary

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36727/

[danbev]

Tested locally using the following patch to resolve the conflicts.

patch

diff --git a/node.gypi b/node.gypi
index f9dba2d4bd..7569705733 100644
--- a/node.gypi
+++ b/node.gypi
@@ -365,8 +365,18 @@
           # Set 1.0.0 as the API compability level to avoid the
           # deprecation warnings when using OpenSSL 3.0.
 	  'defines': ['OPENSSL_API_COMPAT=0x10000000L'],
-	}]]
-
+	}],
+        [ 'openssl_quic=="true" and node_shared_ngtcp2=="false"', {
+          'dependencies': [
+            './deps/ngtcp2/ngtcp2.gyp:ngtcp2'
+          ]
+        }],
+        [ 'openssl_quic=="true" and node_shared_nghttp3=="false"', {
+          'dependencies': [
+            './deps/ngtcp2/ngtcp2.gyp:nghttp3'
+          ]
+        }],
+      ]
     }, {
       'defines': [ 'HAVE_OPENSSL=0' ]
     }],
diff --git a/test/common/index.js b/test/common/index.js
index 89c4fcaaa9..894c8025e7 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -54,6 +54,8 @@ const hasCrypto = Boolean(process.versions.openssl) &&
 const hasOpenSSL3 = hasCrypto &&
     require('crypto').constants.OPENSSL_VERSION_NUMBER >= 805306368;
 
+const hasQuic = hasCrypto && !!process.config.variables.openssl_quic;
+
 // Check for flags. Skip this for workers (both, the `cluster` module and
 // `worker_threads`) and child processes.
 // If the binary was built without-ssl then the crypto flags are
@@ -730,6 +732,7 @@ const common = {
   hasIntl,
   hasCrypto,
   hasOpenSSL3,
+  hasQuic,
   hasMultiLocalhost,
   invalidArgTypeHelper,
   isAIX,

[mcollina]

lgtm

[jasnell]

I'll be landing this once the final CI test completes (assuming it does, it's going sloooooooow).

The next step will be reintroducing the QUIC implementation itself, which will be coming likely (hopefully) in the next two weeks.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36808/

[jasnell]

Landed in 65e8864...43f599b ... as a reminder, this is just the dependencies. The actual quic implementation will be coming soon