Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.3.0 proposal #30774

Merged
merged 180 commits into from
Dec 3, 2019
Merged

v13.3.0 proposal #30774

merged 180 commits into from
Dec 3, 2019

Commits on Nov 29, 2019

  1. src: use uv_async_t for WeakRefs

    Schedule a task on the main event loop, similar to what the HTML
    spec recommends for browsers.
    
    Alternative to #30198
    
    PR-URL: #30616
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    addaleax committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    9e9e48b View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2019

  1. crypto: remove redundant validateUint32 argument

    The third parameter should be a boolean indicating whether the number
    must be positive. Passing zero works, but is unnecessary, misleading
    and inconsistent with other uses of the same function.
    
    PR-URL: #30579
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    55c2ac7 View commit details
    Browse the repository at this point in the history
  2. test: refactor test-dgram-multicast-set-interface-lo.js

    Convert functions to arrow functions. Remove unused param('signal') from
    function.
    
    PR-URL: #30536
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Taylor Gagne authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    20ee499 View commit details
    Browse the repository at this point in the history
  3. doc: fix a typo in a date for version 13.2.0

    PR-URL: #30587
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Kirlat authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    19d192d View commit details
    Browse the repository at this point in the history
  4. src: fix signal handler crash on close

    PR-URL: #30582
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    codebytere authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    1916acb View commit details
    Browse the repository at this point in the history
  5. doc: simplify "is recommended" language in assert documentation

    Replace "X is not recommended" with  "Avoid X".
    Replace "It is recommended not to use X" with "Avoid X".
    
    PR-URL: #30558
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8ef629a View commit details
    Browse the repository at this point in the history
  6. test: replace setTimeout with setImmediate in stream test

    Replace setTimeout() with setImmediate() in
    test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0
    (if you comment out the `common` module, since it uses BigInts and those
    aren't supported in 8.6.0).
    
    PR-URL: #30561
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    e122d39 View commit details
    Browse the repository at this point in the history
  7. test: use arrow function for callback in stream test

    PR-URL: #30561
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    ebba322 View commit details
    Browse the repository at this point in the history
  8. test: remove string literal as message in strictEqual() in stream test

    This reveals the values that cause the assertion error, should it
    happen.
    
    PR-URL: #30561
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    103d01e View commit details
    Browse the repository at this point in the history
  9. test: move stream test to parallel

    I don't believe there's a reason test-stream-writable-clear-buffer needs
    to be in sequential. Move it to parallel.
    
    PR-URL: #30561
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    081b4e2 View commit details
    Browse the repository at this point in the history
  10. test: move explanatory comment to expected location in file

    Refs: #30561 (review)
    
    PR-URL: #30561
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    106235f View commit details
    Browse the repository at this point in the history
  11. test: add common.mustCall() to stream test

    Refs: https://github.com/nodejs/node/pull/30561/files#r348667256
    
    PR-URL: #30561
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    36671f9 View commit details
    Browse the repository at this point in the history
  12. src,doc: add C++ internals documentation

    This aims to help explain some of the internal patterns and utilities
    that we use. It is by no means exhaustive, and suggestions for
    additions are welcome.
    
    Some of this is based on the existing work from #26929.
    
    Refs: #26929
    
    PR-URL: #30552
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    f135c38 View commit details
    Browse the repository at this point in the history
  13. http: improve performance caused by primordials

    Refs: #29766
    
    This works on destructuring primordials whithin libs/_http_agent
    
    PR-URL: #30416
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    lrecknagel authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3b169f1 View commit details
    Browse the repository at this point in the history
  14. http: destructure primordials in lib/_http_server.js

    PR-URL: #30315
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    artmaks authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8256d38 View commit details
    Browse the repository at this point in the history
  15. src: fix -Wsign-compare warnings

    This commit addresses the following compilation warnings:
    
    ../src/node_crypto.cc:5053:3: warning: comparison of integers
    of different signs: 'unsigned int' and 'int' [-Wsign-compare]
      CHECK_EQ(n, BN_bn2binpad(r, data, n));
    
    ../src/node_crypto.cc:5054:3: warning: comparison of integers
    of different signs: 'unsigned int' and 'int' [-Wsign-compare]
      CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
    
    PR-URL: #30565
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    44f28ea View commit details
    Browse the repository at this point in the history
  16. repl: change var to let

    PR-URL: #30428
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    obelaifa authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    4e5818a View commit details
    Browse the repository at this point in the history
  17. events: improve performance caused by primordials

    PR-URL: #30577
    Refs: nodejs/code-and-learn#97
    Refs: #29766
    Refs: #29633
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    antimonyGu authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    0285aa0 View commit details
    Browse the repository at this point in the history
  18. fs: cover fs.opendir ERR_INVALID_CALLBACK

    PR-URL: #30307
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    darky authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    850c2a7 View commit details
    Browse the repository at this point in the history
  19. readline: change var to let

    PR-URL: #30435
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    dnlup authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    c50bbf5 View commit details
    Browse the repository at this point in the history
  20. http2: replace var with let/const

    PR-URL: #30417
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    pc3b3r authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    f7ca7e6 View commit details
    Browse the repository at this point in the history
  21. test: switch to object spread in common/benchmark.js

    PR-URL: #30309
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    palmires authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    f8dfa2d View commit details
    Browse the repository at this point in the history
  22. lib: replace var to let in cli_table.js

    PR-URL: #30400
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Jing19 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    502173b View commit details
    Browse the repository at this point in the history
  23. net: replaced vars to lets and consts

    PR-URL: #30401
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    nath1as authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    017280e View commit details
    Browse the repository at this point in the history
  24. test: test cover cases when trace is empty

    cover prepare_stack_trace in case when trace is empty
    PR-URL: #30311
    Reviewed-By: Gireesh Punathil <[email protected]>
    telenord authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    01e0571 View commit details
    Browse the repository at this point in the history
  25. cluster: replace var by let in shared_handle.js

    PR-URL: #30402
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    putxe authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    55fbe45 View commit details
    Browse the repository at this point in the history
  26. test: dns utils replace var

    PR-URL: #30405
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    ovhemert authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d6a4488 View commit details
    Browse the repository at this point in the history
  27. lib: replace var with let/const

    PR-URL: #30404
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Tembrechts authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    48fef42 View commit details
    Browse the repository at this point in the history
  28. test: change var to let in test-trace-events

    PR-URL: #30406
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    jonchurch authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8a9ee48 View commit details
    Browse the repository at this point in the history
  29. fs: change var to let

    PR-URL: #30407
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    alvarp authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8ee27ff View commit details
    Browse the repository at this point in the history
  30. http2: core.js replace var with let

    const has to be used in for in loop
    
    PR-URL: #30403
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    DanielSchuech authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    1a2ed4a View commit details
    Browse the repository at this point in the history
  31. lib: change var to let

    change var to let in test-tick-processor-unknown.js
    PR-URL: #30408
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    dktistakis authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    bdba03e View commit details
    Browse the repository at this point in the history
  32. lib: replace var with let/const

    PR-URL: #30409
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Driesss authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    0fd89cc View commit details
    Browse the repository at this point in the history
  33. test: replace var with let in pre_execution.js

    PR-URL: #30411
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Vunovati authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    7e7a816 View commit details
    Browse the repository at this point in the history
  34. test: use spread instead of object.assign

    PR-URL: #30412
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    19shubham11 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    9dab32f View commit details
    Browse the repository at this point in the history
  35. test: changed var to let in module-errors

    PR-URL: #30413
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    jrizza88 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d8da9da View commit details
    Browse the repository at this point in the history
  36. child_process: replace var with const/let in internal/child_process.js

    PR-URL: #30414
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    lcamargof authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    4b13bca View commit details
    Browse the repository at this point in the history
  37. lib: changed var to let

    PR-URL: #30427
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    obelaifa authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d277c37 View commit details
    Browse the repository at this point in the history
  38. test: use spread instead of Object.assign

    PR-URL: #30419
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    dnlup authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    2ecc735 View commit details
    Browse the repository at this point in the history
  39. http: replace var with let

    PR-URL: #30421
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Guilherme Goncalves authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    6848bfb View commit details
    Browse the repository at this point in the history
  40. test: change object assign to spread object

    change object assign to spread object in test-npm-install.js
    PR-URL: #30422
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    putxe authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    e401e8c View commit details
    Browse the repository at this point in the history
  41. doc: add note about debugging worker_threads

    PR-URL: #30594
    Fixes: #30197
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    7d98a59 View commit details
    Browse the repository at this point in the history
  42. cluster: replace var with let

    replace var with let in lib/internal/cluster/utils.js
    PR-URL: #30425
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Herrmann, Rene R. (656) authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    708e67a View commit details
    Browse the repository at this point in the history
  43. lib: use let instead of var

    use let instead of var for lib/internal/policy/manifest.js
    PR-URL: #30424
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    edspace authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3c041ed View commit details
    Browse the repository at this point in the history
  44. lib: change var to let in stream_base_commons

    PR-URL: #30426
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    marquicodes authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d024630 View commit details
    Browse the repository at this point in the history
  45. lib: main_thread_only change var to let

    PR-URL: #30398
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    matijagaspar authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    0b64e45 View commit details
    Browse the repository at this point in the history
  46. src: replaced var with let

    replaced var with let in lib/internal/cluter/master.js
    PR-URL: #30397
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Aldo Ambrosioni authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d194c0f View commit details
    Browse the repository at this point in the history
  47. test: code&learn var to let update

    PR-URL: #30436
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Nazaroni authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    dade906 View commit details
    Browse the repository at this point in the history
  48. lib: replace var with let

    PR-URL: #30396
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Dennis Saenger authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    797b938 View commit details
    Browse the repository at this point in the history
  49. tools: update ESLint to 6.7.1

    Update ESLint to 6.7.1
    
    PR-URL: #30598
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    5522467 View commit details
    Browse the repository at this point in the history
  50. tools: enable more eslint rules

    This commit enables these new in ESLint 6.7.0 rules:
    
    - no-constructor-return
    - no-dupe-else-if
    - no-setter-return
    
    PR-URL: #30598
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    84f7b5c View commit details
    Browse the repository at this point in the history
  51. doc: add note of caution about non-conforming streams

    PR-URL: #29895
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Yorkie Liu <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    ronag authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    00f7cc6 View commit details
    Browse the repository at this point in the history
  52. doc: document "Resume Build" limitation

    Compiled binaries for fanned CI builds on Windows and ARM are only kept
    for seven days.
    
    PR-URL: #30604
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    richardlau authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    426ca26 View commit details
    Browse the repository at this point in the history
  53. test: test for minimum ICU version consistency

    The minimum ICU version for Node.js must be at least the minimum ICU
    version for V8.
    
    PR-URL: #30608
    Refs: #30607
    Reviewed-By: Steven R Loomis <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    richardlau authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d651c7d View commit details
    Browse the repository at this point in the history
  54. test: use useful message argument in test function

    The message argument of two test functions in
    test-inspector-async-call-stack is useful but unused. Use it!
    
    PR-URL: #30618
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    97e6273 View commit details
    Browse the repository at this point in the history
  55. lib: adding perf notes js_stream_socket.js

    Leaving var in place of let for performance optimization
    in short loops in hot paths. Added comments explaining why.
    
    PR-URL: #30415
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    ryanj authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    ffe3040 View commit details
    Browse the repository at this point in the history
  56. test: change object assign by spread operator

    change object assign by spread operator in test-require-symlink.js
    PR-URL: #30438
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    putxe authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    60b17b4 View commit details
    Browse the repository at this point in the history
  57. http2: change var to let compact.js

    PR-URL: #30392
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    MariaEmma authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    30ef8e4 View commit details
    Browse the repository at this point in the history
  58. lib: replace var with let/const

    PR-URL: #30390
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Tijl5 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3796885 View commit details
    Browse the repository at this point in the history
  59. child_process: replace var with let/const

    PR-URL: #30389
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    dnlup authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    dae36a9 View commit details
    Browse the repository at this point in the history
  60. process: replace vars in per_thread.js

    PR-URL: #30385
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    EmaSuriano authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    5c40b2f View commit details
    Browse the repository at this point in the history
  61. lib: replace var w/ let

    replace var w/ let in lib/internal/error-serdes.js
    
    PR-URL: #30386
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    IAmEddieDean authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    b18b056 View commit details
    Browse the repository at this point in the history
  62. cluster: replace vars in child.js

    PR-URL: #30383
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    EmaSuriano authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    378c54f View commit details
    Browse the repository at this point in the history
  63. process: replace var with let/const

    PR-URL: #30382
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    deadbeef84 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    56248a8 View commit details
    Browse the repository at this point in the history
  64. util: use let instead of var for util/inspect.js

    PR-URL: #30399
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    lmammino authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    18e9b56 View commit details
    Browse the repository at this point in the history
  65. lib: replace var with let/const

    PR-URL: #30391
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    jens-cappelle authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    5120926 View commit details
    Browse the repository at this point in the history
  66. lib: use let instead of var

    this commit uses let instead of var for util.js & warning.js
    PR-URL: #30375
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    19shubham11 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    b545b91 View commit details
    Browse the repository at this point in the history
  67. doc: add explanation why keep var with for loop

    This comment will help contributors to understand why keeping var
    PR-URL: #30380
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    lrecknagel authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    329a821 View commit details
    Browse the repository at this point in the history
  68. test: dir class initialisation w/o handler

    Covering the case when init Dir class without passing
    handle paramd to constructor.
    
    PR-URL: #30313
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Dmitriy Kikinskiy authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d4b6170 View commit details
    Browse the repository at this point in the history
  69. esm: data URLs should ignore unknown parameters

    PR-URL: #30593
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    bfarias-godaddy authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    365f0ab View commit details
    Browse the repository at this point in the history
  70. test: move test-worker-prof to sequential

    Refs: #26401 (comment)
    
    PR-URL: #30628
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    949f2ad View commit details
    Browse the repository at this point in the history
  71. test: skip test-domain-error-types in debug mode temporariliy

    Until #30498 is resolved, skip
    test-domain-error-types on debug builds.
    
    PR-URL: #30629
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    70d6fa1 View commit details
    Browse the repository at this point in the history
  72. doc: update AUTHORS list

    PR-URL: #30672
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    devsnek authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8ab18b6 View commit details
    Browse the repository at this point in the history
  73. doc: add 13 and 12 to previous versions

    Remove Node.js 6 and add Node.js 12 and Node.js 13 to the previous
    versions of this document section
    
    PR-URL: #30590
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    andrewhughes101 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    e9f031c View commit details
    Browse the repository at this point in the history
  74. doc,deps: document how to maintain ICU in Node.js

    - update v8 guide to mention ICU
    - move content from the tools/icu/README.md but leave a pointer
    
    Fixes: #26108
    Co-Authored-By: Vse Mozhet Byt <[email protected]>
    PR-URL: #30607
    
    Reviewed-By: Ujjwal Sharma <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    srl295 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    b67759a View commit details
    Browse the repository at this point in the history
  75. doc: minor updates to releases.md

    PR-URL: #30636
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: Yorkie Liu <[email protected]>
    BethGriggs authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3d97883 View commit details
    Browse the repository at this point in the history
  76. doc: fixup incorrect flag name reference

    PR-URL: #30651
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    guybedford authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    809a2b0 View commit details
    Browse the repository at this point in the history
  77. doc: remove "this API is unstable" note for v8 serdes API

    As #30234 marked this as stable I think this line
    should be removed as well?
    
    Refs: #30234
    PR-URL: #30631
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    bruce-one authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    fcde497 View commit details
    Browse the repository at this point in the history
  78. fs: rename rimraf's maxBusyTries to maxRetries

    This is part of reworking the rimraf retry logic.
    
    Refs: #30580
    PR-URL: #30644
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    fa1f87b View commit details
    Browse the repository at this point in the history
  79. fs: make rimraf default to 0 retries

    This commit makes retries an opt-in feature by defaulting
    to no automatic retries. This will be particularly important
    once synchronous operations can sleep between attempts.
    
    Refs: #30580
    PR-URL: #30644
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    612a3a2 View commit details
    Browse the repository at this point in the history
  80. fs: remove rimraf's emfileWait option

    This commit removes the emfileWait option. EMFILE errors are
    now handled the same as any other retriable error.
    
    Refs: #30580
    PR-URL: #30644
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    51bc379 View commit details
    Browse the repository at this point in the history
  81. fs: add retryDelay option to rimraf

    This commit adds a retryDelay option to rimraf which configures
    the amount of time between retry operations.
    
    Refs: #30580
    PR-URL: #30644
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    f725953 View commit details
    Browse the repository at this point in the history
  82. fs: add ENFILE to rimraf retry logic

    Co-authored-by: Thang Tran <[email protected]>
    Fixes: #30482
    Refs: #30499
    Refs: #30580
    PR-URL: #30644
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    2 people authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3475f9b View commit details
    Browse the repository at this point in the history
  83. http2: replace direct array usage with struct for js_fields_

    PR-URL: #30534
    Fixes: #30505
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    e92afd9 View commit details
    Browse the repository at this point in the history
  84. http2: allow to configure maximum tolerated invalid frames

    PR-URL: #30534
    Fixes: #30505
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    092a3c2 View commit details
    Browse the repository at this point in the history
  85. test: update and harden http2-reset-flood

    * use new maxSessionInvalidFrames to lower the needed frames
    * slow down requests to generate less redundant after-session-close
      requests
    
    PR-URL: #30534
    Fixes: #30505
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    5ecfd94 View commit details
    Browse the repository at this point in the history
  86. http2: make maximum tolerated rejected streams configurable

    PR-URL: #30534
    Fixes: #30505
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    7d37bce View commit details
    Browse the repository at this point in the history
  87. tty: truecolor check moved before 256 check

    256 color would be return instead of 16m if both env variables were set
    
    * tty: improve color check order highest spec first
    * tty: add test for TERM and COLORTERM set
    * tty: move COLORTERM check outside TERM closure
    * tty: remove extra if check for COLORTERM
    
    Refs: #27609
    
    PR-URL: #30474
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    duncanhealy authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    1f10681 View commit details
    Browse the repository at this point in the history
  88. n-api: add missed nullptr check in napi_has_own_property

    PR-URL: #30626
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    cc5875b View commit details
    Browse the repository at this point in the history
  89. test: add regression test for signal handler removal in exit

    Refs: #30581
    Refs: #30582
    
    PR-URL: #30589
    Refs: #30581
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    0972fa3 View commit details
    Browse the repository at this point in the history
  90. test: add mustCall() to test-inspector-contexts

    In test-inspector-contexts, if mainContextPromise is modified such that
    the `method` argument is changed to something invalid, the test still
    passes and the second part of the test never runs. Use
    `common.mustCall()` to cause the test to fail if the second part of the
    test does not run.
    
    Refs: #30519 (comment)
    
    PR-URL: #30649
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3769632 View commit details
    Browse the repository at this point in the history
  91. test: check for session.post() errors in test-insepctor-context

    If session.post() generates an error, it is currently ignored. Add check
    for error by adding a callback to session.post() invocation.
    
    PR-URL: #30649
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3571e13 View commit details
    Browse the repository at this point in the history
  92. test: remove destructuring from test-inspector-contexts

    As I'm working with this test, I'm finding the destructuring of assert
    and vm to make this test harder to read/understand. So I'm taking the
    liberty of removing them.
    
    PR-URL: #30649
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    3e3ad39 View commit details
    Browse the repository at this point in the history
  93. test: add logging in case of infinite loop

    test-inspector-contexts may be entering an infinite loop (or very
    long-running loop) in CI, resulting in flakiness. Or maybe not. Add
    logging to find out.
    
    PR-URL: #30649
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    a2f440d View commit details
    Browse the repository at this point in the history
  94. n-api: implement napi_is_detached_arraybuffer

    This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
    specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer
    
    Closes: #29955
    
    PR-URL: #30613
    Fixes: #29955
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    lundibundi authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8171cef View commit details
    Browse the repository at this point in the history
  95. src,doc: fix broken links

    PR-URL: #30662
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    9d8d2e1 View commit details
    Browse the repository at this point in the history
  96. src: keep object alive in stream_pipe code

    This was overlooked in a489583.
    
    Refs: #30374
    
    PR-URL: #30666
    Fixes: #30643
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d54432f View commit details
    Browse the repository at this point in the history
  97. src: add more can_call_into_js() guards

    This is in preparation for running native `SetImmediate()`
    callbacks during shutdown.
    
    PR-URL: #30666
    Fixes: #30643
    Refs: #30374
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    94357db View commit details
    Browse the repository at this point in the history
  98. src: no SetImmediate from destructor in stream_pipe code

    Guard against running `SetImmediate()` from the destructor.
    The object will not be alive or usable in the callback,
    so it does not make sense to attempt to schedule the
    `SetImmediate()`.
    
    PR-URL: #30666
    Fixes: #30643
    Refs: #30374
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    bea2501 View commit details
    Browse the repository at this point in the history
  99. src: run native immediates during Environment cleanup

    This can be necessary, because some parts of the Node.js code base
    perform cleanup operations in the Immediate callbacks, e.g. HTTP/2.
    
    This resolves flakiness in an HTTP/2 test that failed when a
    `SetImmediate()` callback was not run or destroyed before the
    `Environment` destructor started, because that callback held a
    strong reference to the `Http2Session` object and the expectation
    was that no such objects exist once the `Environment` constructor
    starts.
    
    Another, slightly more direct, alternative would have
    been to clear the immediate queue rather than to run it. However,
    this approach seems to make more sense as code generally assumes
    that the `SetImmediate()` callback will always run; For example,
    N-API uses an immediate callback to call buffer finalization
    callbacks.
    
    Unref’ed immediates are skipped, as the expectation is generally
    that they may not run anyway.
    
    Fixes: #30643
    
    PR-URL: #30666
    Refs: #30374
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    6c249c0 View commit details
    Browse the repository at this point in the history
  100. module: fix specifier resolution algorithm

    Fixes: #30520
    
    PR-URL: #30574
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    pd4d10 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    2cf8a7f View commit details
    Browse the repository at this point in the history
  101. src: cleanup unused headers

    Node codebase has evolved a lot in the more than 10 years of its
    existence. As more features (and code) have been added, changed,
    removed, it's sometimes hard to keep track of what gets used and what
    not.
    
    This commits attempts to clean some of those potentially left-over
    headers using suggestions from  include-what-you-use
    
    Refs: #27531
    
    PR-URL: #30328
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    alferpal authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8ec0d75 View commit details
    Browse the repository at this point in the history
  102. inspector: properly shut down uv_async_t

    Closing in the Agent destructor is too late, because that happens
    when the Environment is destroyed, not when libuv handles are closed.
    
    This fixes a situation in which the same libuv loop is re-used for
    multiple Environment instances sequentially, e.g. in our cctest.
    
    PR-URL: #30612
    Reviewed-By: Eugene Ostroukhov <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    6322611 View commit details
    Browse the repository at this point in the history
  103. tls: allow empty subject even with altNames defined

    Behavior described in #11771
    is still true even though the issue is closed.
    
    This PR is to allow DNS and URI names, even when there is not a subject.
    
    Refs: #11771
    
    PR-URL: #22906
    Reviewed-By: James M Snell <[email protected]>
    jasonmacgowan authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    89e2c71 View commit details
    Browse the repository at this point in the history
  104. test: remove unused function argument from http test

    Remove unused `res` from test-http-server-consumed-timeout.
    
    PR-URL: #30677
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    49458de View commit details
    Browse the repository at this point in the history
  105. test: do not skip test-http-server-consumed-timeout

    test-http-server-consumed-timeout has code to that causes it to be
    skipped on busy machines. Instead, use an exponential backoff for the
    timeout if the machine is busy.
    
    PR-URL: #30677
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    ecb902f View commit details
    Browse the repository at this point in the history
  106. test: remove unnecessary common.platformTimeout() call

    Applying platformTimeout() to the interval is counterproductive. It
    should be applied to the request timeout duration only.
    
    PR-URL: #30677
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    00f532f View commit details
    Browse the repository at this point in the history
  107. test: move test-https-server-consumed-timeout to parallel

    Change the test to be robust in slow environments and move to parallel.
    The previous version of the test failed for me in parallel with just two
    or four simultaneous versions running. This version passes 96
    simultaneous versions running, but still fails as designed if the
    request writes fail to prevent the request timeout from occurring.
    
    PR-URL: #30677
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    a3b758d View commit details
    Browse the repository at this point in the history
  108. deps: V8: cherry-pick ca5b0ec

    Original commit message:
    
    [heap] Ensure SyntheticModule is initialized before next allocation
    
    Ensure that all fields of `SyntheticModule` are set before creating
    the exports hash table for it, because the latter may trigger
    garbage collection, leading to crashes.
    
    This has been causing failures in the Node.js CI over the last weeks,
    after making the creating of synthetic modules part of Node’s
    startup sequence.
    
    (I am generally not very familiar with this part of the V8
    code and there might be a better way, or possibly a way to add a
    reliable regression test, that I am not aware of.)
    
    Refs: #30498
    Refs: #30648
    Change-Id: I32da4b7bd888c6ec1421f34f5bd52e7bad154c1e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939752
    Commit-Queue: Ulan Degenbaev <[email protected]>
    Reviewed-by: Ulan Degenbaev <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#65247}
    
    Refs: https://github.com/v8/v8/commit/ \
    ca5b0ec2722d2af4551c01ca78921fa16a26ae72
    Fixes: #30498
    Fixes: #30648
    
    PR-URL: #30708
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    aa01ebd View commit details
    Browse the repository at this point in the history
  109. test: revert 6d022c1

    Revert "test: skip test-domain-error-types in debug mode temporariliy"
    This reverts commit 6d022c1.
    
    PR-URL: #30708
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    83861fb View commit details
    Browse the repository at this point in the history
  110. deps: V8: backport 93f189f19a03

    Original commit message:
    
        [ic] Fix non-GlobalIC store to interceptor on the global object
    
        We possibly need to load the global object from the global proxy as the holder
        of the named interceptor.
    
        Change-Id: I0f9f2e448630608ae853588f6751b55574a9efd9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930903
        Commit-Queue: Igor Sheludko <[email protected]>
        Reviewed-by: Igor Sheludko <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#65119}
    
    Refs: v8/v8@93f189f
    Fixes: #30586
    
    PR-URL: #30681
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    targos authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    456d250 View commit details
    Browse the repository at this point in the history
  111. deps: update llhttp to 2.0.1

    Changelog:
    
    * Optional SSE4.2 support (at compile time)
    * Lenient mode of operation
    
    PR-URL: #30553
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    indutny authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    d257448 View commit details
    Browse the repository at this point in the history
  112. http: set socket.server unconditionally

    This is useful for situations in which the socket was not
    created for HTTP, e.g. when using arbitrary `Duplex` streams.
    
    (The added test fails because previously, `socket.server.emit()`
    would not work for emitting the `clientError` event, as
    `socket.server` was `undefined`.)
    
    PR-URL: #30571
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    1d1d136 View commit details
    Browse the repository at this point in the history
  113. child_process: document kill() return value

    This commit documents the return value from subprocess.kill().
    
    PR-URL: #30669
    Refs: #30668
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    30a4f68 View commit details
    Browse the repository at this point in the history
  114. tls: add memory tracking support to SSLWrap

    PR-URL: #30548
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    0b0f023 View commit details
    Browse the repository at this point in the history
  115. src: use BaseObjectPtr to store SNI context

    Rather than relying on a link to the JS object, store a pointer to
    the C++ object directly.
    
    PR-URL: #30548
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    7bd587e View commit details
    Browse the repository at this point in the history
  116. src: inline SetSNICallback

    Refs: #30548 (comment)
    
    PR-URL: #30548
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    fc11db1 View commit details
    Browse the repository at this point in the history
  117. crypto: automatically manage memory for ECDSA_SIG

    Refs: #29292
    
    PR-URL: #30641
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    tniessen authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    4affc30 View commit details
    Browse the repository at this point in the history
  118. build: use Node.js instead of Node in configure

    PR-URL: #30642
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    80ada94 View commit details
    Browse the repository at this point in the history
  119. deps: patch V8 to 7.9.317.25

    Refs: v8/v8@7.9.317.23...7.9.317.25
    
    PR-URL: #30679
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    MylesBorins authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    b470354 View commit details
    Browse the repository at this point in the history
  120. doc: revise socket.connect() note

    Edit note in about `onread` option to `socket.connect()` for clarity.
    
    PR-URL: #30691
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Trott authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    87136c9 View commit details
    Browse the repository at this point in the history
  121. doc: address nits for src/README.md

    Refs: #30552 (review)
    
    PR-URL: #30693
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    1e7c567 View commit details
    Browse the repository at this point in the history
  122. doc: avoid proposal syntax in code example

    PR-URL: #30685
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    alexzherdev authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    20dbce1 View commit details
    Browse the repository at this point in the history
  123. doc: fix worker.resourceLimits type

    PR-URL: #30664
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    dnalborczyk authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    43e7857 View commit details
    Browse the repository at this point in the history
  124. doc: fix worker.resourceLimits indentation

    PR-URL: #30663
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    dnalborczyk authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    aca0119 View commit details
    Browse the repository at this point in the history
  125. doc: add missing 'added' versions to module.builtinModules

    PR-URL: #30562
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    watson authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    40b7621 View commit details
    Browse the repository at this point in the history
  126. buffer: release buffers with free callbacks on env exit

    Invoke the free callback for a given `Buffer` if it was created
    with one, and mark the underlying `ArrayBuffer` as detached.
    
    This makes sure that the memory is released e.g. when addons inside
    Workers create such `Buffer`s.
    
    PR-URL: #30551
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    e8af569 View commit details
    Browse the repository at this point in the history
  127. n-api: detach external ArrayBuffers on env exit

    Make sure that `ArrayBuffer`s created using
    `napi_create_external_arraybuffer` are rendered unusable
    after its memory has been released.
    
    PR-URL: #30551
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    be9788b View commit details
    Browse the repository at this point in the history
  128. test: port worker + buffer test to N-API

    This ports `test/addons/worker-buffer-callback` to N-API,
    with the small exception of using external `ArrayBuffer`s rather
    than external Node.js `Buffer`s.
    
    PR-URL: #30551
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    099d3fd View commit details
    Browse the repository at this point in the history
  129. dns: use length for building TXT string

    Rely on the length reported by C-Ares rather than `\0`-termination
    for creating the JS string for a dns TXT response.
    
    Fixes: #30688
    
    PR-URL: #30690
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    f37450f View commit details
    Browse the repository at this point in the history
  130. buffer: fix 6-byte writeUIntBE() range check

    Fixes: #30420
    
    PR-URL: #30459
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    mscdex authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    63eb4fe View commit details
    Browse the repository at this point in the history
  131. test:refactor createHook test

    PR-URL: #30568
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    JenyMzo authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    ba0115f View commit details
    Browse the repository at this point in the history
  132. src: remove unused variable in node_dir.cc

    PR-URL: #30267
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    gengjiawen authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    bccfd12 View commit details
    Browse the repository at this point in the history
  133. src: clean up node_file.h

    - Move inline functions into an `-inl.h` file
    - Move override function definitions into `.cc` files
    - Remove `using` statements from header files
    - Make data fields of classes private
    - Mark classes at the end of hierarchies as `final`
    
    This is also partially being done in an attempt to avoid
    a particular internal compiler error, see
    #30475 (comment)
    for details.
    
    PR-URL: #30530
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    be84cee View commit details
    Browse the repository at this point in the history
  134. http2: fix session memory accounting after pausing

    The ability to pause input processing was added in 8a4a193 but
    introduced a session memory accounting mismatch leading to potential
    NGHTTP2_ENHANCE_YOUR_CALM errors.
    
    After pausing
    (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871),
    the early return on line 873 skips the
    DecrementCurrentSessionMemory(stream_buf_.len) call below (line 878).
    
    When we later finished processing the input chunk
    (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858),
    we were calling DecrementCurrentSessionMemory(stream_buf_offset_) [line
    1875] which was a no-op since we just set stream_buf_offset_ to 0 [line
    1873].
    
    The correct amount to decrement by is still stream_buf_.len, since
    that's the amount we skipped previously (line 878).
    
    Fixes: #29223
    Refs: 164ac5b
    
    PR-URL: #30684
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Michael Lehenbauer authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    6f313f9 View commit details
    Browse the repository at this point in the history
  135. doc,n-api: mark napi_detach_arraybuffer as experimental

    As its actual release stage.
    
    PR-URL: #30703
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    legendecas authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    bfcc914 View commit details
    Browse the repository at this point in the history
  136. doc: documenting a bit more FreeBSD case

    FreeBSD provides more up to date compilers than
    the one provided by the system.
    
    PR-URL: #30325
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    devnexen authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    ad9f737 View commit details
    Browse the repository at this point in the history
  137. doc: fixed a typo in process.md

    If the process was not spawned with an IPC channel, `process.send`
    will be undefined and calling it as `process.send()` would throw error
    
    PR-URL: #30277
    Reviewed-By: Anna Henningsen <[email protected]>
    Harendra Singh authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    8fcb450 View commit details
    Browse the repository at this point in the history
  138. test: use arrow functions in addons tests

    Convert all anonymous callback functions in `test/addons/**/*.js`
    to use arrow functions, except for those in
    `test/addons/make-callback/test.js` (which reference `this`)
    
    `writing-tests.md` states to use arrow functions when appropriate.
    
    PR-URL: #30131
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    GaryGSC authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    4800b62 View commit details
    Browse the repository at this point in the history
  139. doc: clarify IncomingMessage.destroy() description

    State that the 'error' event is emitted on the underlying socket, not
    the IncomingMessage object.
    
    PR-URL: #30255
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    XMB5 authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    a25626c View commit details
    Browse the repository at this point in the history
  140. tools: add unified plugin changing links for html docs

    This commit introduces additional stage in the process of generating
    html docs from markdown files. Plugin transforms links to *.md files
    in the respository to links to *.html files in the online documentation.
    
    Fixes: #28689
    
    PR-URL: #29946
    Reviewed-By: Anna Henningsen <[email protected]>
    Marek Łabuz authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    5a6f836 View commit details
    Browse the repository at this point in the history
  141. doc: note that buf.buffer's contents might differ

    This bit me in a personal project since I had no reason to read the
    `buf.byteOffset` docs, so point readers there explicitly.
    
    PR-URL: #29651
    Reviewed-By: Anna Henningsen <[email protected]>
    strugee authored and addaleax committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    cbd5026 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2019

  1. lib: flatten access to primordials

    Store all primordials as properties of the primordials object.
    Static functions are prefixed by the constructor's name and prototype
    methods are prefixed by the constructor's name followed by "Prototype".
    For example: primordials.Object.keys becomes primordials.ObjectKeys.
    
    Backport-PR-URL: #30731
    PR-URL: #30610
    Refs: #29766
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    a4dfe3b View commit details
    Browse the repository at this point in the history
  2. lib: enforce use of Array from primordials

    PR-URL: #30635
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    5ef4dce View commit details
    Browse the repository at this point in the history
  3. util: fix inspection of errors with tampered name or stack property

    This makes sure that `util.inspect()` does not throw while inspecting
    errors that have the name or stack property set to a different type
    than string.
    
    Fixes: #30572
    
    PR-URL: #30576
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    BridgeAR authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    1040e72 View commit details
    Browse the repository at this point in the history
  4. util: fix .format() not always calling toString when it should be

    This makes sure that `util.format('%s', object)` will always call
    a user defined `toString` function. It was formerly not the case
    when the object had the function declared on the super class.
    
    At the same time this also makes sure that getters won't be
    triggered accessing the `constructor` property.
    
    PR-URL: #30343
    Fixes: #30333
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    BridgeAR authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    6a0dd1c View commit details
    Browse the repository at this point in the history
  5. lib: replace ArrayBuffer.isView by primordial ArrayBuffer

    PR-URL: #30692
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Kawacrepe authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    c09e3de View commit details
    Browse the repository at this point in the history
  6. lib: replace Date.now function by primordial DateNow

    PR-URL: #30689
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Tchoupinax authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    ae2c7d0 View commit details
    Browse the repository at this point in the history
  7. lib: enforce use of Boolean from primordials

    Refs: #30697
    
    PR-URL: #30698
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    892bde6 View commit details
    Browse the repository at this point in the history
  8. lib: use static Number properties from primordials

    PR-URL: #30686
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    5a9340d View commit details
    Browse the repository at this point in the history
  9. lib: enforce use of primordial Number

    PR-URL: #30700
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Sebastien-Ahkrin authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    de3a1c3 View commit details
    Browse the repository at this point in the history
  10. benchmark,doc,lib,test: prepare for padding lint rule

    Upcoming lint rule will require a blank line between consecutive
    functions. Add it in the places where we don't have it already.
    
    PR-URL: #30696
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    4cd4e7c View commit details
    Browse the repository at this point in the history
  11. tools: enforce blank line between functions

    Refs: #21128 (comment)
    
    PR-URL: #30696
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    941a91d View commit details
    Browse the repository at this point in the history
  12. test: increase coverage for trace_events.js

    Add a test case to increase the test coverage for lib/trace_events.js.
    
    Refs: https://codecov.io/gh/nodejs/node/src/ea7a6f9dbd05654fff3f8c474ac0f5126bc87376/lib/trace_events.js#L70...75
    
    PR-URL: #30705
    Refs: https://coverage.nodejs.org/coverage-ea7a6f9dbd05654f/lib/trace_events.js.html#L70
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Trott authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    93707c4 View commit details
    Browse the repository at this point in the history
  13. deps: V8: cherry-pick 0dfd9ea51241

    Original commit message:
    
        [coverage] Fix coverage with default arguments
    
        In the presence of default arguments, the body of the function gets
        wrapped into another block. This caused our trailing-range-after-return
        optimization to not apply, because the wrapper block had no source
        range assigned. This CL correctly assignes a source range to that block,
        which allows already present code to handle it correctly.
    
        Note that this is not a real coverage bug; we've just been reporting
        whitespace as uncovered. We're fixing it for consistency.
    
        Originally reported on github.com/bcoe/c8/issues/66
    
        Bug: v8:9952
        Change-Id: Iab3905f558eb99126e0dad8072d03d0a312fdcd3
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903430
        Commit-Queue: Sigurd Schneider <[email protected]>
        Reviewed-by: Toon Verwaest <[email protected]>
        Reviewed-by: Jakob Gruber <[email protected]>
        Cr-Commit-Position: refs/heads/master@{#64836}
    
    Refs: v8/v8@0dfd9ea
    
    PR-URL: #30713
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    bcoe authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    0ba877a View commit details
    Browse the repository at this point in the history
  14. stream: improve performance for sync write finishes

    Improve performance and reduce memory usage when a writable stream
    is written to with the same callback (which is the most common case)
    and when the write operation finishes synchronously (which is also
    often the case).
    
                                                             confidence improvement accuracy (*)    (**)   (***)
        streams/writable-manywrites.js sync='no' n=2000000                  0.99 %       ±3.20%  ±4.28%  ±5.61%
        streams/writable-manywrites.js sync='yes' n=2000000        ***    710.69 %      ±19.65% ±26.47% ±35.09%
    
    Refs: #18013
    Refs: #18367
    
    PR-URL: #30710
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    e968e26 View commit details
    Browse the repository at this point in the history
  15. http: make maximum header size configurable per-stream or per-server

    Make `maxHeaderSize` a.k.a. `--max-header-size` configurable now that
    the legacy parser is gone (which only supported a single global value).
    
    Refs: #30567
    
    PR-URL: #30570
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Denys Otrishko <[email protected]>
    addaleax authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    6257408 View commit details
    Browse the repository at this point in the history
  16. repl: fix referrer for dynamic import

    The ESM loader does not accept a directory as the referrer, it requires
    a path within the directory.  Add `/repl` to ensure relative dynamic
    imports can succeed.
    
    Fixes: #19570
    
    PR-URL: #30609
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Ben Coe <[email protected]>
    coreyfarrell authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    b91d22c View commit details
    Browse the repository at this point in the history
  17. wasi: introduce initial WASI support

    Co-authored-by: Gus Caplan <[email protected]>
    Co-authored-by: Daniel Bevenius <[email protected]>
    Co-authored-by: Jiawen Geng <[email protected]>
    Co-authored-by: Tobias Nießen <[email protected]>
    Co-authored-by: Chengzhong Wu <[email protected]>
    
    PR-URL: #30258
    Refs: #27850
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Wyatt Preul <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Daniel Bevenius <[email protected]>
    cjihrig authored and targos committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    9ec53cf View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. test: remove unused callback argument

    PR-URL: #30712
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    01ab031 View commit details
    Browse the repository at this point in the history
  2. test: simplify forEach() usage

    Use an array literal instead of using split() on a very short string.
    
    PR-URL: #30712
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    d69b9b7 View commit details
    Browse the repository at this point in the history
  3. test: remove unused callback argument

    PR-URL: #30712
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1222be8 View commit details
    Browse the repository at this point in the history
  4. test: correct header length subtraction

    In test-http-max-http-headers, a comment asks why we are subtracting 32
    from the length of the invalid-length-by-1 headers instead of just 1.
    Subtracting 1 seems to be correct and works.
    
    PR-URL: #30712
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1918b4e View commit details
    Browse the repository at this point in the history
  5. test: move test-http-max-http-headers to parallel

    test-http-max-http-headers seems to run fine in parallel, even with
    `tools/test.py -j 96 --repeat 192
    test/parallel/test-http-max-http-headers.js`.
    
    The same applies to `test-set-http-max-http-headers.js` which (as
    written) depends on `test-http-max-http-headers.js` being in the same
    directory. So that is being moved too.
    
    PR-URL: #30712
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1e199ce View commit details
    Browse the repository at this point in the history
  6. src: change header file in node_stat_watcher.cc

    change src/node_stat_watcher.cc to import `env-inl.h` instead of
    `env.h`.
    
    PR-URL: #29976
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    aug2uag authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    e65ad86 View commit details
    Browse the repository at this point in the history
  7. tls: introduce ERR_TLS_INVALID_CONTEXT

    It is trivially possible to cause an internal assertion error with
    tls.createSecurePair(). Throw a friendly error instead. Reserve internal
    assertions for things that we believe to be impossible.
    
    PR-URL: #30718
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    7aa1df7 View commit details
    Browse the repository at this point in the history
  8. doc: update socket.bufferSize text

    Edit text for clarity and readability.
    
    PR-URL: #30723
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    f46df0b View commit details
    Browse the repository at this point in the history
  9. doc: update README.md to fix active/maint times

    Update REAMDE.md to be consistent with the
    active/maintenance times (12/18) outlined in
    https://github.com/nodejs/Release#release-plan. This was missed
    when the times were swapped in the Node.js 12 timeframe.
    
    PR-URL: #30707
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    mhdawson authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    a8002d9 View commit details
    Browse the repository at this point in the history
  10. doc: update signature algorithm in release doc

    Updated doc to reflect what is now done in tools/release.sh
    
    PR-URL: #30673
    Reviewed-By: Rod Vagg <[email protected]>
    MylesBorins authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    61af1fc View commit details
    Browse the repository at this point in the history
  11. doc: revise REPL uncaught exception text

    Simplify the text about uncaught exceptions in the REPL.
    
    PR-URL: #30729
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Trott authored and targos committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    19b31c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. test: fix test-benchmark-streams

    test-benchmark-streams is currently failing because the `sync` option is
    not specified in the test, resulting in too many benchmarks running.
    
    PR-URL: #30757
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Trott authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    b5c7dad View commit details
    Browse the repository at this point in the history
  2. test: use arrow functions in async-hooks tests

    Convert all anonymous callback functions in `test/async-hooks/*.js`
    to use arrow functions.
    
    `writing-tests.md` states to use arrow functions when appropriate.
    
    PR-URL: #30137
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    GaryGSC authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    37c70ee View commit details
    Browse the repository at this point in the history
  3. doc: fix typographical error

    Insert missing word.
    
    PR-URL: #30735
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3d302ff View commit details
    Browse the repository at this point in the history
  4. build,win: add test-ci-native and test-ci-js

    PR-URL: #30724
    Refs: nodejs/build#1996
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    joaocgreis authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    6a53152 View commit details
    Browse the repository at this point in the history
  5. build,win: propagate error codes in vcbuild

    Don't exit vcbuild with error code 0 when cctest fails.
    
    PR-URL: #30724
    Refs: nodejs/build#1996
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    joaocgreis authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    0aae502 View commit details
    Browse the repository at this point in the history
  6. test: add an indicator isIBMi

    We have to skip some test cases on IBM i.
    On IBM i, process.platform and os.platform() both return aix,
    It is not enough to differentiate between IBM i and real AIX system.
    Also updated parallel/test-cluster-bind-privileged-port.js for test.
    
    PR-URL: #30714
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    dmabupt authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    81d81a5 View commit details
    Browse the repository at this point in the history
  7. test: add coverage for ERR_TLS_INVALID_PROTOCOL_VERSION

    There is currently no test that confirms that an invalid TLS protocol
    results in ERR_TLS_INVALID_PROTOCOL_VERSION. Add tests to check this for
    the `minVersion` and `maxVersion` options in `createSecureContext()`.
    
    Refs: https://codecov.io/gh/nodejs/node/src/c14c476614e3134867ddb997bdfe5a41ba668175/lib/_tls_common.js#L56
    Refs: https://coverage.nodejs.org/coverage-c14c476614e31348/lib/_tls_common.js.html#L56
    
    PR-URL: #30741
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and targos committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    49e047f View commit details
    Browse the repository at this point in the history
  8. build: add --without-node-code-cache configure option

    So that it's possible to build without code cache (in particular,
    without building mkcodecache) for testing.
    
    PR-URL: #30647
    Refs: #28845
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and BridgeAR committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    6545314 View commit details
    Browse the repository at this point in the history
  9. build: do not build mksnapshot and mkcodecache for --shared

    To build mkcodecache and mksnapshot (they are executables),
    we currently build libnode with unresolved symbols, then build
    the two exectuables with src/node_snapshot_stub.cc and
    src/node_code_cache_stub.cc. Each of them write a C++ file to
    disk when being run. We then use the generated C++ files & libnode
    (with unresolved symbols) to build the final Node executable.
    
    However, if libnode itself is the final product, then we should
    not build it with unresolved symbols.
    #28897 added the two stubs
    for the libnode target when the --shared configure option is used,
    but it did not get rid of the actions to build and run mksnapshot
    and mkcodecache for --shared, so to get it working we also
    need a patch to make sure --shared imply --without-node-code-cache
    and --without-node-snapshot, until we actually fix the TODO so that
    mksnapshot and mkcodecache do not use the libnode that way.
    
    PR-URL: #30647
    Refs: #28845
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and BridgeAR committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    648766b View commit details
    Browse the repository at this point in the history
  10. 2019-12-03, Version 13.3.0 (Current)

    Notable changes:
    
    * fs:
      * Reworked experimental recursive `rmdir()`  (cjihrig)
        #30644
        * The `maxBusyTries` option is renamed to `maxRetries`, and its
          default is set to 0. The `emfileWait` option has been removed,
          and `EMFILE` errors use the same retry logic as other errors.
          The `retryDelay` option is now supported. `ENFILE` errors are
          now retried.
    * http:
      * Make maximum header size configurable per-stream or per-server
        (Anna Henningsen) #30570
    * http2:
      * Make maximum tolerated rejected streams configurable (Denys
        Otrishko) #30534
      * Allow to configure maximum tolerated invalid frames (Denys
        Otrishko) #30534
    * wasi:
      * Introduce initial WASI support (cjihrig)
        #30258
    
    PR-URL: #30774
    BridgeAR committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    f5fe384 View commit details
    Browse the repository at this point in the history