test: skip test-domain-error-types in debug mode temporariliy #30629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Nov 24, 2019
lundibundi
reviewed
Nov 24, 2019
richardlau
approved these changes
Nov 25, 2019
richardlau
requested changes
Nov 25, 2019
addaleax
approved these changes
Nov 25, 2019
richardlau
approved these changes
Nov 25, 2019
Trott
added
the
author ready
|
With the |
|
Until nodejs#30498 is resolved, skip test-domain-error-types on debug builds. PR-URL: nodejs#30629 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 6d022c1 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Until #30498 is resolved, skip test-domain-error-types on debug builds. PR-URL: #30629 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 23, 2019
Until #30498 is resolved, skip test-domain-error-types on debug builds. PR-URL: #30629 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 31, 2019
Until #30498 is resolved, skip test-domain-error-types on debug builds. PR-URL: #30629 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #30498 is resolved, skip
test-domain-error-types on debug builds.
Not my first choice, but the frequency of failures in container+debug+shared-lib here is a problem.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes