Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: address nits for src/README.md #30693

Closed
wants to merge 1 commit into from
Closed

doc: address nits for src/README.md #30693

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #30552 (review)

@vsemozhetbyt

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 28, 2019
@cjihrig
Copy link
Contributor

cjihrig commented Nov 28, 2019

Partial duplicate of #30662.

@addaleax
Copy link
Member Author

addaleax commented Nov 28, 2019 •
edited
Loading

Ah, sorry. Git will rebase out your changes anyway (out of this PR) as they match 1:1, so I think this is still okay.

addaleax added a commit that referenced this pull request Nov 30, 2019
@addaleax
doc: address nits for src/README.md
0f42727 
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@addaleax
Copy link
Member Author

Landed in 0f42727

@addaleax addaleax closed this Nov 30, 2019
@addaleax addaleax deleted the cpp-readme-nits branch November 30, 2019 00:36
addaleax added a commit that referenced this pull request Nov 30, 2019
@addaleax
doc: address nits for src/README.md
1e7c567 
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@addaleax @targos
doc: address nits for src/README.md
5340a2d 
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@addaleax @MylesBorins
doc: address nits for src/README.md
670e4b5 
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@trivikr trivikr trivikr approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @cjihrig @benjamingr @gengjiawen @richardlau @trivikr @nodejs-github-bot