build: spawn make test-ci with -j1
#23733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
Do we know how much time a CI run takes with and without |
Good question (I don't see any significant change) with
|
| Job | Build # | Duration |
|---|---|---|
| node-compile-windows | build #21674 | ( 46 min ) |
| node-test-binary-windows | build #20858 | ( 13 min ) |
| node-test-commit | build #22448 | ( 1 hr 40 min ) |
| node-test-commit-arm | build #19316 | ( 39 min ) |
| node-test-commit-custom-suites-freestyle (test-worker) | build #1730 | ( 8 min 16 sec ) |
| node-test-commit-freebsd | build #21307 | ( 18 min ) |
| node-test-commit-linux | build #22483 | ( 1 hr 40 min ) |
| node-test-commit-linux-containered | build #7947 | ( 1 hr 39 min ) |
| node-test-commit-linuxone | build #6326 | ( 6 min 41 sec ) |
| node-test-commit-osx | build #22011 | ( 1 hr 3 min ) |
| node-test-commit-plinux | build #21033 | ( 8 min 32 sec ) |
| node-test-commit-smartos | build #21042 | ( 31 min ) |
| node-test-commit-windows-fanned | build #21620 | ( 1 hr 2 min ) |
| node-test-linter | build #22905 | ( 5 min 2 sec ) |
Without (daily master)
| Job | Build # | Duration |
|---|---|---|
| node-compile-windows | build #21670 | ( 45 min ) |
| node-test-binary-windows | build #20854 | ( 13 min ) |
| node-test-commit | build #22444 | ( 1 hr 23 min ) |
| node-test-commit-arm | build #19312 | ( 36 min ) |
| node-test-commit-custom-suites (test-internet) | build #724 | ( 1 min 59 sec ) |
| node-test-commit-custom-suites-freestyle (test-worker) | build #1725 | ( 9 min 5 sec ) |
| node-test-commit-freebsd | build #21303 | ( 17 min ) |
| node-test-commit-linux | build #22479 | ( 29 min ) |
| node-test-commit-linux-containered | build #7944 | ( 1 hr 22 min ) |
| node-test-commit-linuxone | build #6319 | ( 6 min 27 sec ) |
| node-test-commit-osx | build #22007 | ( 18 min ) |
| node-test-commit-plinux | build #21029 | ( 8 min 18 sec ) |
| node-test-commit-smartos | build #21038 | ( 27 min ) |
| node-test-commit-windows-fanned | build #21616 | ( 59 min ) |
| node-test-linter | build #22901 | ( 4 min 25 sec ) |
richardlau
reviewed
Oct 18, 2018
richardlau
approved these changes
Oct 19, 2018
joyeecheung
approved these changes
Oct 19, 2018
mmarchini
approved these changes
Oct 19, 2018
mmarchini
added
the
author ready
refack
removed
the
author ready
|
@refack any reason that this is not author ready? |
No CI since the most recent change? |
This need to be followed up in Jenkins, so mainly so this will not be landed by mistake. |
This was referenced Oct 19, 2018
All the sub targets have internal parallelism, so no performance loss. Also `make` doesn't to a good enough job of combining the output streams, or eliminate races. PR-URL: nodejs#23733 Fixes: nodejs#22006 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
|
Since this allowed us to restore |
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
All the sub targets have internal parallelism, so no performance loss. Also `make` doesn't to a good enough job of combining the output streams, or eliminate races. PR-URL: #23733 Fixes: #22006 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
This was referenced Oct 23, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Oct 29, 2018
All the sub targets have internal parallelism, so no performance loss. Also `make` doesn't to a good enough job of combining the output streams, or eliminate races. PR-URL: #23733 Fixes: #22006 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
|
landed in 10.x in 2cd68be |
|
just catching up on this. Did we end up fixing the addon build make+stdout problems with this change? nice work if so! |
Yes, but we have a deeper issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the subtasks have internal parallelism, so there is minimal loss.
Also
makedoesn't do a good enough job of combining the outputstreams, or eliminate races.
Fixes: #22006
Ref: #23423 (comment)
Ref: #23286 (comment)
/CC @nodejs/build @nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes