Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: prevent C++ linker from overwriting executable #22027

Closed
wants to merge 3 commits into from
Closed

build: prevent C++ linker from overwriting executable #22027

wants to merge 3 commits into from

Conversation

rubys
Copy link
Member

@rubys rubys commented Jul 30, 2018

Running make run-ci with multiple jobs, it is possible for the C++ linker
to be invoked while build-addons is running, this can result in intermittent
ENOENT failures when spawning nodeGyp. To prevent this, originally
provide a different name for the executable, and rename it to the correct
name only after the link completes successfully.

Fixes #22006. Kinda. Sorta.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 30, 2018
@Trott
Copy link
Member

Trott commented Jul 30, 2018

@nodejs/build-files

@Fishrock123
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/16085/

@targos
Copy link
Member

targos commented Jul 30, 2018

Are we sure it's only a Mac thing? I think I saw something similar on Linux when I was working on canary. I fixed it with git clean - fdx

@refack
Copy link
Contributor

refack commented Jul 30, 2018

I'm -0 on this. IMHO it just adds complexity to workaround the crux of the issue.

@joyeecheung
Copy link
Member

joyeecheung commented Jul 31, 2018 •
edited
Loading

IIRC, this is not mac-only but makefile-only - we have been seeing the executable being deleted back in the days when the addons were built in a loop in makefile instead of in the new JS scripts.

@Trott
Copy link
Member

Trott commented Jul 31, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16095/

@Trott
Copy link
Member

Trott commented Jul 31, 2018

Oh, wait, we need an entire new CI since there were changes since the last one.

CI: https://ci.nodejs.org/job/node-test-pull-request/16096/

@addaleax addaleax added test Issues and PRs related to the tests. addons Issues and PRs related to native addons. labels Aug 2, 2018
@rubys
Copy link
Member Author

rubys commented Aug 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16546/

@rubys @Trott
build: prevent C++ linker from overwriting executable
dd42812 
Running `make run-ci` with multiple jobs, it is possible for the C++ linker
to be invoked while build-addons is running, this can result in intermittent
ENOENT failures when spawning `nodeGyp`.  To prevent this, originally
provide a different name for the executable, and rename it to the correct
name only after the link completes successfully.

Fixes 22006.  Kinda.  Sorta.
@rubys @Trott
make it work on linux
eb76e9f
@rubys @Trott
refactor; and handle all non-windows platforms as 'unix'
0437cef
@Trott
Copy link
Member

Trott commented Aug 18, 2018

Rebased and force-pushed to fix the CI problem (unrelated to this PR).

CI: https://ci.nodejs.org/job/node-test-pull-request/16556/

@Trott
Copy link
Member

Trott commented Aug 18, 2018

@nodejs/gyp @nodejs/node-gyp Would be great to get a second review on this one.

Aside: Should we really have separate gyp and node-gyp teams or should that be merged into a single team?

@joyeecheung joyeecheung mentioned this pull request Aug 20, 2018
Closed
addaleax
addaleax reviewed Sep 2, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @refack, this is more of a workaround than a fix.

node.gyp
@@ -925,6 +931,25 @@
},
],
} ],
# When building executable on Unix operating systems, in order to
# avoid overwriting the executable while it it running, build it with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: is

@BridgeAR
Copy link
Member

BridgeAR commented Sep 6, 2018

Even though this is clearly a workaround: is there any solution in sight for the actual issue? If not, I do not see any downside in doing this for now.

Any other options about that?

@rubys
Copy link
Member Author

rubys commented Sep 6, 2018

With two approvals, I will merge this (after fixing the typo) on, say, ... Friday? ...unless there are any objections.

@refack
Copy link
Contributor

refack commented Oct 19, 2018 •
edited
Loading

I've found that #23733 will workaround this issue.
And that relanding #23255 #23156 will fix it, so I'm blocking this issue until we prove it's the only way.

@refack refack added the blocked PRs that are blocked by other issues or PRs. label Oct 19, 2018
@fhinkel
Copy link
Member

fhinkel commented Oct 26, 2019

Closing this due to inactivity. Pleas re-open if needed.

@fhinkel fhinkel closed this Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: flakiness in building addons with make