v6.14.2 proposal #19996
Merged
v6.14.2 proposal #19996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #18018 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
82bdf8f fixed an issue by silently modifying the `start` option for the case when only `end` is passed, in order to perform reads from a specified range in the file. However, that approach does not work for non-seekable files, since a numeric `start` option means that positioned reads will be used to read data from the file. This patch fixes that, and instead ends reading after a specified size by adjusting the read buffer size. This way we avoid re-introducing the bug that 82bdf8f fixed, and align behaviour with the native file stream mechanism introduced in #18936 as well. Backport-PR-URL: #19411 PR-URL: #19329 Fixes: #19240 Refs: #18121 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chen Gang <[email protected]>
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the test was moved to sequential. Refs: #13592 PR-URL: #19069 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Backport-PR-URL: #19115 PR-URL: #17735 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
When a test fails via `common.mustNotCall` it is sometimes hard to determine exactly what was called. This modification stores the caller's file and line number by using the V8 Error API to capture a stack at the time `common.mustNotCall()` is called. In the event of failure, this information is printed. This change also exposes a new function in test/common, `getCallSite()` which accepts a `function` and returns a `String` with the file name and line number for the function. Backport-PR-URL: #19355 PR-URL: #17257 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: #19375 Reviewed-By: Myles Borins <[email protected]>
PR-URL: #19042 Reviewed-By: Myles Borins <[email protected]>
Ensure that the parser is freed before emitting the 'connect' or 'upgrade' event. PR-URL: #18209 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18264 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
It makes more sense to provide instructions on how to update the PR branch before instructions on pushing the commit. PR-URL: #18355 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Welcome Gibson to the TSC! PR-URL: #18481 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18482 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Shorten text that is duplicated from website and supply link. PR-URL: #18483 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Useful for executing in a shell because it accepts arguments as an array instead of a string as exec does. Depending on the circumstances, that can prove to be useful if the arguments are already prepared. PR-URL: #18384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
x86_64 is a standard arch descriptor on Linux, allow it as an alias for our preferred descriptor: x64 PR-URL: #18052 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
The encoding is already handled by `Writable.prototype.write()`. PR-URL: #18429 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #19120 PR-URL: #17924 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #19120 PR-URL: #17924 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Refine the static and shared lib build process in order to integrate static and shared lib verfication into CI. When building both static and shared lib, we still build node executable now and it uses the shared and static lib. Signed-off-by: Yihong Wang <[email protected]> Refs: #14158 Backport-PR-URL: #19050 PR-URL: #17604 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
To avoid a function call `BufferList.prototype.concat()` is not called when there is only a buffer in the list. That buffer is instead accessed directly. Backport-PR-URL: #19483 PR-URL: #18239 Reviewed-By: Matteo Collina <[email protected]>
The `n` argument of `BufferList.prototype.concat()` is not the number of `Buffer` instances in the list, but their total length when concatenated. Backport-PR-URL: #19483 PR-URL: #18239 Reviewed-By: Matteo Collina <[email protected]>
Also, alphabetize all types in type-parser.js and fix some nits in type formats. Backport-PR-URL: #19500 PR-URL: #18444 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes --with-intl option passed to configure script when without-intl is used Backport-PR-URL: #19485 PR-URL: #17614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Like #17614, but for the `intl-none` option. Backport-PR-URL: #19485 Refs: #17614 PR-URL: #18292 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Up until now, Node did not clear the current error code
attempting to read environment variables on Windows.
Since checking the error code is the way we distinguish between
missing and zero-length environment variables, this could lead to a
false positive when the error code was still tainted.
In the simplest case, accessing a missing variable and then a
zero-length one would lead Node to believe that both calls yielded
an error.
Before:
> process.env.I=''; process.env.Q; process.env.I
undefined
> process.env.I=''; /*process.env.Q;*/ process.env.I
''
After:
> process.env.I=''; process.env.Q; process.env.I
''
> process.env.I=''; /*process.env.Q;*/ process.env.I
''
This only affects Node 8 and above, since before
1aa595e we always constructed a
`v8::String::Value` instance for passing the lookup key to the OS,
which in in turn always made a heap allocation and therefore
reset the error code.
Backport-PR-URL: #19484
PR-URL: #18463
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18651 Refs: #12223 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Due to extensive reliance on timings and the fs module, this test is currently inherently flaky. Refactor it to simply use setImmediate and only one busy loop. PR-URL: #18567 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This test was added over six years ago, and the behavior seems to have changed since then. When the test was originally written, common.mustCall() did not exist. The only assertion in this test was not actually executing. Instead of an 'error' event being emitted as expected, an 'abort' event was emitted. PR-URL: #18508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Assuming less knowledge on the part of the reader, making it easier to get start using Node.js. PR-URL: #17977 Fixes: #17970, Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #18526 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
The timer in NAPI's test_callback_scope/test-resolve-async.js can be removed. If the test fails, it will timeout on its own. The extra timer increases the chances of the test being flaky. Backport-PR-URL: #19447 PR-URL: #18719 Fixes: #18702 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Passing a pointer to a static integer is sufficient for the test. Backport-PR-URL: #19447 PR-URL: #19039 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Documentation for N-API Custom Asynchronous Operations incorrectly stated that async execution happens on the main event loop. Added details to napi_create_async_work about which threads are used to invoke the execute and complete callbacks. Changed 'async' to 'asynchronous' in the documentation for Custom Asynchronous Operations. Changed "executes in parallel" to "can execute in parallel" for the documentation of napi_create_async_work execute parameter. Backport-PR-URL: #19447 PR-URL: #19073 Fixes: #19071 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. Backport-PR-URL: #19447 PR-URL: #19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Document which APIs work while an exception is pending. This is the list of all APIs which do not start with `NAPI_PREAMBLE(env)`. Fixes: nodejs/abi-stable-node#257 Backport-PR-URL: #19447 PR-URL: #19078 Reviewed-By: Michael Dawson <[email protected]>
The last promise created by the test for the purposes of making sure that its type is indeed a promise needs to be resolved so as to avoid having it left in the pending state at the end of the test. Backport-PR-URL: #19447 PR-URL: #19245 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Added a N-API test to verify new.target behavior. Backport-PR-URL: #19447 PR-URL: #19236 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #19447 PR-URL: #19262 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Added some simple tests to verify that the int64 API is correctly handling numbers greater than 32-bits. This is a basic test, but verifies that an implementer hasn't truncated back to 32-bits. Refs: nodejs/node-chakracore#496 Backport-PR-URL: #19447 PR-URL: #19309 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: #19447 PR-URL: #19385 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Add checks for a pending exception in napi_make_callback after the callback has been invoked. If there is a pending exception then we need to avoid checking the result as that will not be able to complete properly. Add additional checks to the unit test for napi_make_callback to catch this case. Backport-PR-URL: #19447 PR-URL: #19362 Fixes: nodejs/node-addon-api#235 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Add function to trigger and uncaught exception. Useful if an async callback throws an exception with no way to recover. Backport-PR-URL: #19447 PR-URL: #19337 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This re-writes the test in C by dropping std::vector<napi_value> in favour of a C99 variable length array, and by dropping the anonymous namespace in favour of static function declarations. Backport-PR-URL: #19447 PR-URL: #19448 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Backport-PR-URL: #19447 PR-URL: #19555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Bump the version due to additions to the api. Backport-PR-URL: #19447 PR-URL: #19497 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Whenever we call into an addon, whether it is for a callback, for module init, or for async work-related reasons, we should make sure that * the last error is cleared, * the scopes before the call are the same as after, and * if an exception was thrown and captured inside the module, then it is re-thrown after the call. Therefore we should call into the module in a unified fashion. This change introduces the macro NAPI_CALL_INTO_MODULE() which should be used whenever invoking a callback provided by the module. Fixes: #19437 Backport-PR-URL: #19447 PR-URL: #19537 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Heed the comment to not use fields of a Reference after calling its finalize callback, because such a call may destroy the Reference. Fixes: #19673 Backport-PR-URL: #19447 PR-URL: #19718 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. Backport-PR-URL: #19447 PR-URL: #19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
force-pushed
the
v6.14.2-proposal
branch
from
c144ebc
to
db4eac8
Compare
|
nit: I have to go through the changelog and remove all the semver minor references that have to do with n-api. It is landing as experimental. CI: https://ci.nodejs.org/job/node-test-pull-request/14339/ |
MylesBorins
force-pushed
the
v6.14.2-proposal
branch
2 times, most recently
from
e7e1642
to
1ee8f94
Compare
|
One more round of tests ci: https://ci.nodejs.org/job/node-test-pull-request/14599/ |
MylesBorins
force-pushed
the
v6.14.2-proposal
branch
from
1ee8f94
to
79592b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-04-30, Version 6.14.2 'Boron' (LTS), @MylesBorins
Notable Changes
Coming Soon
Commits
6ba38e8c2b] - N-API: Reuse ObjectTemplate instances (Gabriel Schulhof) #1399949d8c2e8ae] - build: refine static and shared lib build (Yihong Wang) #17604cc7469eec8] - build: allow x86_64 as a dest_cpu alias for x64 (Rod Vagg) #18052969398d08e] - crypto: reuse variable instead of reevaluation (Tobias Nießen) #1773571acb5205a] - doc: Add a missing comma (jiangq) #19555b9b752ef07] - doc: fix typos on n-api (Kyle Robinson Young) #1938510fe65a0d5] - doc: fix n-api asynchronous threading docs (Eric Bickle) #190738826f185b0] - doc: mark NAPI_AUTO_LENGTH as code (Tobias Nießen) #18697e9e5d56121] - doc: fix exporting a function example (Aonghus O Nia) #186619719b831a3] - doc: fix typo in n-api.md (Vse Mozhet Byt) #18590fdd50fb35f] - doc: small typo in n-api.md (iskore) #1855524a2791173] - doc: remove usage of you in n-api doc (Michael Dawson) #1852874086e19f2] - doc: remove uannecessary Require (Michael Dawson) #18184fed2136857] - doc: napi: make header style consistent (Ali Ijaz Sheikh) #18122e04386a363] - doc: napi: fix unbalanced emphasis (Ali Ijaz Sheikh) #181223d8e1aaf48] - doc: updates examples to use NULL (Michael Dawson) #18008173f29763e] - doc: update example in module registration (Franziska Hinkelmann) #17424c6852126fd] - doc: use "JavaScript" instead of "Javascript" (Rich Trott) #1716335dc8bab9e] - doc: document common pattern for instanceof checks (Michael Dawson) #1669922490dcb91] - doc: fix typos in N-API (Swathi Kalahastri) #1691155fabd7337] - doc: fix a typo in n-api documentation (Vipin Menon) #168790c67f21bcf] - doc: update to use NAPI_AUTO_LENGTH (Michael Dawson) #161875c2bba0931] - doc: fix some links (Vse Mozhet Byt) #16202e9a6dffc65] - doc: fix outdated code sample in n-api.md (rebornix) #15581ca69f1dfe7] - doc: fix new nits in links (Vse Mozhet Byt) #15449a766802bee] - doc: fix doc for napi_get_value_string_utf8 (Daniel Taveras) #14529b0f09a2ee6] - doc: added napi_get_value_string_latin1 (Kyle Farnung) #14678fbcc962727] - doc: delint (Refael Ackermann) #14707831de617b0] - doc: document napi_finalize() signature (cjihrig) #142304b9773effa] - doc: fix some links (Vse Mozhet Byt) #1440036185b343b] - doc: doc lifetime of n-api last error info (Michael Dawson) #13939cc3a4af7c8] - doc: fix a few n-api doc issues (Michael Dawson) #136501e91d5804d] - doc: fix out of date napi_callback doc (XadillaX) #13570c5ae39e401] - doc: fix napi_create_*_error signatures in n-api (Jamen Marzonie) #1354435a3cbb5dd] - doc: fix out of date sections in n-api doc (Michael Dawson) #13508a06cc4684f] - doc: fix typo "ndapi" in n-api.md (Jamen Marz) #1348482f31ff4af] - doc: add ref to option to enable n-api (Michael Dawson) #1340617fe21e83d] - doc: fix typo in n-api.md (JongChan Choi) #133232e2905266e] - doc: fix title/function name mismatch (Michael Dawson) #1312375e91fe5c8] - doc: add reference to node_api.h in docs (Michael Dawson) #130840f74ee5cbf] - doc: clarify operation of napi_cancel_async_work (Michael Dawson) #129745b045374ed] - doc: clarify node.js addons are c++ (Beth Griggs) #128986bcd6d49d5] - doc: fix broken links in n-api doc (Michael Dawson) #128893e388cf819] - doc: Add initial documentation for N-API (Michael Dawson) #125494d67369c1b] - doc: fix various nits (Vse Mozhet Byt) #19743057c80b088] - doc: move Fedor to TSC Emeritus (Myles Borins) #18752bf72ee667e] - doc: add mmarchini to collaborators (Matheus Marchini) #18740280af052d8] - doc: add history for url.parse (Steven) #1868529b0d3b104] - doc: add devsnek to collaborators (Gus Caplan) #18679dc6dc8232f] - doc: add section for strategic initiatives (Michael Dawson) #171046b348d4483] - doc: modify the return value of request.write() (陈刚) #18526dd4d075e51] - doc: be more explicit in the sypnosis (Tim O. Peters) #179770067bccf6f] - doc: fix description of createDecipheriv (Tobias Nießen) #18651bc2f0a5120] - doc: linkify missing types (Vse Mozhet Byt) #1844432089bcbc1] - doc: streamline README intro (Rich Trott) #1848343839f1601] - doc: move Brian White to TSC Emeriti list (Rich Trott) #1848227d3c1a0f4] - doc: add Gibson Fahnestock to TSC (Rich Trott) #1848167fd520539] - doc: reorder section on updating PR branch (Ali Ijaz Sheikh) #18355f81a69aefe] - fs: fixcreateReadStream(…, {end: n})for non-seekable fds (Anna Henningsen) #1932918acad349c] - http: make socketPath work with no agent (Luigi Pinca) #194251edadebaa0] - http: allow _httpMessage to be GC'ed (Luigi Pinca) #18865dbe70b744c] - http: free the parser before emitting 'upgrade' (Luigi Pinca) #1820977a405b92f] - lib: set process.execPath on OpenBSD (Aaron Bieber) #185433aa5b7d939] - n-api: add moreint64\_ttests (Kyle Farnung) #19402abd9fd6797] - n-api: back up env before finalize (Gabriel Schulhof) #19718e6ccdfbde3] - n-api: ensure in-module exceptions are propagated (Gabriel Schulhof) #19537c6d0a66ef2] - (SEMVER-MINOR) n-api: bump version of n-api supported (Michael Dawson) #19497c16a705416] - n-api: re-write test_make_callback (Gabriel Schulhof) #1944849cd4fad89] - (SEMVER-MINOR) n-api: add napi_fatal_exception (Mathias Buus) #19337eb29266878] - n-api: add missing exception checking (Michael Dawson) #193622c1190a93d] - (SEMVER-MINOR) n-api: take n-api out of experimental (Michael Dawson) #19262ce1447920e] - n-api: resolve promise in test (Gabriel Schulhof) #19245a8237efaf1] - n-api: update documentation (Gabriel Schulhof) #19078af62c8fff7] - n-api: update reference test (Gabriel Schulhof) #19086d2463745a7] - n-api: fix object test (Gabriel Schulhof) #19039516c287f8e] - n-api: remove extra reference from test (Gabriel Schulhof) #18542a8dec487f7] - (SEMVER-MINOR) n-api: add methods to open/close callback scope (Michael Dawson) #18089c09a7134e7] - n-api: wrap control flow macro in do/while (Ben Noordhuis) #18532b565ba2d82] - n-api: implement wrapping using private properties (Gabriel Schulhof) #18311d9df8cfe77] - n-api: change assert ok check to notStrictEqual. (Aaron Kau) #184142e24a0bfe7] - n-api: throw RangeError napi_create_typedarray() (Jinho Bang) #1803762427bbed9] - (SEMVER-MINOR) n-api: expose n-api version in process.versions (Michael Dawson) #18067bb99f31f30] - n-api: throw RangeError in napi_create_dataview() with invalid range (Jinho Bang) #1786965ea7abd55] - n-api: fix memory leak in napi_async_destroy() (alnyan) #17714d4284a464b] - n-api: use nullptr instead of NULL in node_api.cc (Daniel Bevenius) #17276f4391b95ee] - (SEMVER-MINOR) n-api: add helper for addons to get the event loop (Anna Henningsen) #171093c84db624a] - n-api: unexpose symbols and remove EXTERNAL_NAPI (Gabriel Schulhof) #1623455aab6bf01] - n-api: check against invalid handle scope usage (Anna Henningsen) #16201169b53e788] - n-api: use module name macro (Michael Dawson) #1618532412a8ded] - n-api: make changes for source compatibility (Gabriel Schulhof) #1610200d094f9c3] - n-api: add check for large strings (Michael Dawson) #156112bc8a59915] - n-api: fix warning about size_t compare with int (Sampson Gao) #155085e29823d1d] - n-api: remove n-api module loading flag (Gabriel Schulhof) #14902f31b50cfc7] - n-api: add optional string length parameters (Sampson Gao) #15343fe87a5944b] - n-api: napi_is_construct_call->napi_get_new_target (Sampson Gao) #146985eadd6249d] - n-api: Context for custom async operations (Jason Ginchereau) #1518950cb48b55c] - n-api: refactor napi_addon_register_func (Taylor Woll) #15088156a8b6069] - (SEMVER-MINOR) n-api: change async resource name to napi_value (Jason Ginchereau) #146977588eead2a] - (SEMVER-MINOR) n-api: use AsyncResource for Work tracking (Anna Henningsen) #14697676cff48bd] - n-api: stop creating references to primitives (Gabriel Schulhof) #152893b4708b025] - n-api: implement napi_run_script (Gabriel Schulhof) #15216ac5b904808] - n-api: adds function to adjust external memory (Chris Young) #14310278a2d069f] - (SEMVER-MINOR) n-api: implement promise (Gabriel Schulhof) #1436573cc251f50] - (SEMVER-MINOR) n-api: add ability to remove a wrapping (Gabriel Schulhof) #14658951adbef3d] - (SEMVER-MINOR) n-api: add napi_get_node_version (Anna Henningsen) #14696b29eb693a0] - (SEMVER-MINOR) n-api: optimize number API performance (Jason Ginchereau) #14573bd032a158a] - (SEMVER-MINOR) n-api: add support for DataView (Shivanth MP) #1438286b101cb60] - n-api: re-use napi_env between modules (Gabriel Schulhof) #142171acab66df4] - n-api: directly create Local from Persistent (Kyle Farnung) #14211f4d1cae634] - n-api: add fast paths for integer getters (Anna Henningsen) #14393aad36b2cd4] - n-api: add napi_fatal_error API (Kyle Farnung) #1397157be12ed97] - (SEMVER-MINOR) n-api: add code parameter to error helpers (Michael Dawson) #13988cd3015408e] - n-api: wrap test macros in do/while (Kyle Farnung) #140957973bd3e63] - n-api: Implement stricter wrapping (Gabriel Schulhof) #138725b0c57cfeb] - n-api: fix warning in test_general (Daniel Bevenius) #14104a5517d80bb] - n-api: add napi_has_own_property() (cjihrig) #140638e2a26d3d0] - n-api: fix -Wmaybe-uninitialized compiler warning (Ben Noordhuis) #1405333821c3087] - n-api: use Maybe version of Object::SetPrototype() (Ben Noordhuis) #1405380cf25a8a5] - n-api: add napi_delete_property() (cjihrig) #13934cadec3b37e] - n-api: add napi_delete_element() (cjihrig) #1394997b628ba8e] - n-api: fix section title typo (Kyle Farnung) #13972c3eb187bd9] - n-api: avoid crash in napi_escape_scope() (Michael Dawson) #13651919556f27a] - n-api: enable napi_wrap() to work with any object (Jason Ginchereau) #1325086c0ebf4e2] - (SEMVER-MINOR) n-api: add napi_get_version (Michael Dawson) #1320770281ba1be] - n-api: Retain last code when getting error info (Jason Ginchereau) #130878d3162d9e6] - n-api: remove compiler warning (Anna Henningsen) #13014a128219a48] - n-api: Handle fatal exception in async callback (Jason Ginchereau) #128382e36365d56] - n-api: napi_get_cb_info should fill array (Jason Ginchereau) #128637507d1e0e6] - n-api: remove unnecessary try-catch bracket from certain APIs (Gabriel Schulhof) #1270549d74c648d] - n-api: Sync with back-compat changes (Jason Ginchereau) #12674bc252509ca] - n-api: Reference and external tests (Jason Ginchereau) #12551c560db9ece] - n-api: Enable scope and ref APIs during exception (Jason Ginchereau) #125248287e7671a] - n-api: tighten null-checking and clean up last error (Gabriel Schulhof) #12539f5cfa09ca4] - n-api: remove napi_get_value_string_length() (Jason Ginchereau) #12496c44f6ffc3c] - n-api: fix coverity scan report (Michael Dawson) #123659bf8e9d48c] - n-api: add string api for latin1 encoding (Sampson Gao) #12368eb51d42d2b] - n-api: fix -Wmismatched-tags compiler warning (Ben Noordhuis) #12333d82fd2a9a0] - n-api: implement async helper methods (taylor.woll) #12250c127b71526] - n-api: change napi_callback to return napi_value (Taylor Woll) #122482a726223ea] - n-api: cache Symbol.hasInstance (Gabriel Schulhof) #12246db36ca5f91] - n-api: Update property attrs enum to match JS spec (Jason Ginchereau) #122401e6d3bb841] - n-api: create napi_env as a real structure (Gabriel Schulhof) #12195f1bdbd17d0] - n-api: break dep between v8 and napi attributes (Michael Dawson) #12191a9562fe30c] - (SEMVER-MINOR) n-api: add support for abi stable module API (Jason Ginchereau) #11975aa0fb7761e] - n-api,test: add int64 bounds tests (Kyle Farnung) #193093f6d80e25c] - n-api,test: add a new.target test to addons-napi (Taylor Woll) #19236011b53e28f] - n-api,test: use module name macro (Gabriel Schulhof) #16146a6af97f76c] - napi: initialize and check status properly (Gabriel Schulhof) #122839b36811d8e] - napi: supress invalid coverity leak message (Michael Dawson) #12192269c2f3ad9] - net: remove redundant code from _writeGeneric() (Luigi Pinca) #18429988cca841e] - process: fix reading zero-length env vars on win32 (Anna Henningsen) #1846372a5710b71] - readline: update references to archived repository (Tobias Nießen) #17924b20c278a7c] - src: add napi_handle_scope_mismatch to msg list (neta) #171610ef0b342e9] - src: replace assert with CHECK_LE in node_api.cc (Ben Noordhuis) #14514a8c73748db] - src: correct endif comment SRC_NODE_API_H__ (Daniel Bevenius) #131900ca2dad3a6] - src: free memory before re-setting URLHost value (Ivan Filenko) #18357e54b8e8184] - stream: cleanup() when unpiping all streams. (陈刚) #182668ab8d6afd6] - stream: fix y.pipe(x)+y.pipe(x)+y.unpipe(x) (Anna Henningsen) #127468f830ca896] - stream: remove unreachable code (Luigi Pinca) #1823964c83d7da9] - stream: simplifysrc.\_readableStatetostate(陈刚) #182647c58045470] - test: remove unnecessary timer (cjihrig) #18719c90b77ed5d] - test: convert new tests to use error types (Jack Horton) #185817f37dc9c48] - test: improve error message output (Bhavani Shankar) #1849859249a1768] - test: show pending exception error in napi tests (Ben Wilcox) #18413eceb70b584] - test: refactor addons-napi/test_exception/test.js (Rich Trott) #18340b3806ecd39] - test: fixed typos in napi test (furstenheim) #18148a6c277e2eb] - test: remove ambiguous error messages from test_error (Nicholas Drane) #17812412cc17748] - test: remove literals that obscure assert messages (Rich Trott) #1764286ddd03608] - test: add unhandled rejection guard (babygoat) #17275e54b58c024] - test: replace assert.throws with common.expectsError (Leko) #17445976f32d189] - test: refactor addons-napi/test_promise/test.js (ka3e) #168142476ab9619] - test: improve error emssage reporting in testNapiRun.js (Paul Ashfield) #16821d4c04e05f7] - test: improve assert messages in napi exception test (Paul Blanche) #16820c14207c77b] - test: add detailed message for assertion failure (Attila Gonda) #16812d31792fcbe] - test: use default assertion messages (John Byrne) #16808087d213f67] - test: include actual value in assertion message (Matthew Cantelon) #159359cc435dc85] - test: improve message for assert.strictEqual() (Jayson D. Henkel) #16013ebbd07dd27] - test: remove redundant error messages (Christina Chan) #160435bba809e01] - test: cleaned up assert messages (mrgorbo) #1603253bd313739] - test: fix race condition in addon test (Kinnan Kwok) #1603737acd806be] - test: remove template literal (Emily Ford) #1595331c97178c1] - test: remove unused parameters (Daniil Shakir) #14968b59eddd082] - test: use regular expressions in throw assertions (Vincent Xue) #1431806b1273464] - test: changed error message validator (Pratik Jain) #144433f3eaf9961] - test: replace string concat with template literal (Song, Bintao Garfield) #1426948274213b1] - test: handle missing V8 tests in n-api test (cjihrig) #141237f126c2069] - test: add coverage for napi_typeof (Michael Dawson) #13990a0cf9b7a73] - test: verify napi_get_property() walks prototype (cjihrig) #139611e25062fa1] - test: add coverage for napi_property_descriptor (Michael Dawson) #13510eb422796cd] - test: fix build warning in addons-napi/test_object (Jason Ginchereau) #134129d70b43bdc] - test: consolidate n-api test addons - part2 (Michael Dawson) #1338006cf9480d3] - test: consolidate n-api test addons (Michael Dawson) #13317652d3218fe] - test: Make N-API weak-ref GC tests asynchronous (Jason Ginchereau) #131210dac33d4f2] - test: improve n-api coverage for typed arrays (Michael Dawson) #132441829d25907] - test: add coverage for napi_has_named_property (Michael Dawson) #13178d89afe8685] - test: increase n-api constructor coverage (Michael Dawson) #1312471aa251671] - test: Improve N-API test coverage (Michael Dawson) #13044314f22dcf4] - test: improve N-API test coverage (Michael Dawson) #13006263a633d5e] - test: add common.mustCall() to NAPI exception test (Rich Trott) #129595936f7c9bb] - test: improve n-api array func coverage (Michael Dawson) #12890ce03977f30] - test: fix napi test_reference for recent V8 (Michaël Zasso) #12864dd7665a68e] - test: port test for make_callback to n-api (Hitesh Kanwathirtha) #12409f09677fdba] - test: add coverage for error apis (Michael Dawson) #127291785f3cf44] - test: fix warning in n-api reference test (Michael Dawson) #127305d2afb2174] - test: replace indexOf with includes (gwer) #12604fcb019f6ea] - test: add coverage for napi_cancel_async_work (Michael Dawson) #1257572c5d976f1] - test: test doc'd napi_get_value_int32 behaviour (Michael Dawson) #12633d9f3e0dd83] - Revert "test: port test for make_callback to n-api" (James M Snell) #12475a003777d96] - test: port test for make_callback to n-api (Hitesh Kanwathirtha) #12409577f327d2c] - test: fix compiler warning in n-api test (Anna Henningsen) #12318f8c2585fe0] - test: add second argument to assert.throws (Michaël Zasso) #122706bf3d04d6c] - test: improve test coverage for n-api (Michael Dawson) #12327d799b1cb61] - test: update a few tests to work on OpenBSD (Aaron Bieber) #18543bc883fb136] - test: refactor test-http-abort-before-end (cjihrig) #1850844ab85018c] - test: fix flaky timers-block-eventloop test (Anatoli Papirovski) #185675bcf668f42] - test: use correct size in test-stream-buffer-list (Luigi Pinca) #18239f3c6febedf] - test: update references to archived repository (Tobias Nießen) #17924b2a2a55271] - test: verify the shell option works properly on execFile (jvelezpo) #18384fd7d1990db] - test: remove orphaned entries from status (Kyle Farnung) #190425ca8dee8cb] - test: remove n-api intermediate files (Gabriel Schulhof) #1937546aed5800f] - test: make common.mustNotCall show file:linenumber (Lance Ball) #172574d2efa2415] - test: remove mark flaky for moved test (Beth Griggs) #19069502781c1d7] - test: fix spelling in test case comments (Tobias Nießen) #18018b2bf6c873f] - test,lib,doc: use function declarations (Rich Trott) #12711a91b1b928c] - win, build: fix intl-none option (Birunthan Mohanathas) #182926ff763bd66] - win, build: fix without-intl option (Bartosz Sosnowski) #17614